Skip to contentSkip to conversation

net: fix build warning in trans_rdma.c

PATCH In review Xishi Qiu 2 participants 2 messages Jul 30, 2013

Subsystems (3)
Networking Network drivers 9P file system
lore
Share & tools
lore

Xishi Qiu

author
#0 lore raw

PATCH 1/1 net: fix build warning in trans_rdma.c

When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.

Signed-off-by Xishi Qiu <[email protected]>
---
 net/9p/trans_rdma.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
net/9p/trans_rdma.c +0 -11
index 928f2bb..8f68df5 100644
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
 	return 1;
 }
 
-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
-{
-	struct p9_trans_rdma *rdma = client->trans;
-
-	atomic_inc(&rdma->excess_rc);
-	return 0;
-}
-
 /**
  * trans_create_rdma - Transport method for creating atransport instance
  * @client: client instance
Signature · 1 line
1.7.1
#1 lore raw
Quoted 23 lines · Xishi Qiu

When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.

Signed-off-by Xishi Qiu <[email protected]>
---
 net/9p/trans_rdma.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
net/9p/trans_rdma.c +0 -4
index 928f2bb..8f68df5 100644
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
        return 1;
 }
 
-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)

net/9p/trans_rdma.c static int rdma_cancel(struct p9_client *client, struct p9_req_t *req) · line 593

Quoted 10 lines
net/9p/trans_rdma.c +0 -7
-{
-       struct p9_trans_rdma *rdma = client->trans;
-
-       atomic_inc(&rdma->excess_rc);
-       return 0;
-}
-
 /**
  * trans_create_rdma - Transport method for creating atransport instance
  * @client: client instance

Hi,

This is wrong.

Please check http://comments.gmane.org/gmane.linux.network/276261.

thanks,
Daniel.