kobs-ng: new package
PATCH 1/1 kobs-ng: new package
--- package/Config.in | 1 + package/kobs-ng/Config.in | 4 ++ package/kobs-ng/kobs-ng.mk | 18 +++++++++++ package/kobs-ng/kobs-ng.patch | 67 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 90 insertions(+), 0 deletions(-) create mode 100644 package/kobs-ng/Config.in create mode 100644 package/kobs-ng/kobs-ng.mk create mode 100644 package/kobs-ng/kobs-ng.patch
package/Config.in +1 -0
@@ -207,6 +207,7 @@ source "package/f2fs-tools/Config.in" source "package/flashbench/Config.in" source "package/genext2fs/Config.in" source "package/genromfs/Config.in" +source "package/kobs-ng/Config.in" source "package/makedevs/Config.in" source "package/mtd/Config.in" source "package/nfs-utils/Config.in"
package/kobs-ng/Config.in new file +4 -0
@@ -0,0 +1,4 @@ +config BR2_PACKAGE_KOBS_NG + bool "kobs-ng" + help + Build freescale kobs-ng utility for burning bootstreams to NAND
package/kobs-ng/kobs-ng.mk new file +18 -0
@@ -0,0 +1,18 @@ +################################################################################ +# +# kobs-ng +# +################################################################################ + +# kobs-ng versions have never made much sense :( +KOBS_NG_VERSION = 3.0.35-4.0.0 +KOBS_NG_SOURCE = kobs-ng-$(KOBS_NG_VERSION).tar.gz +KOBS_NG_SITE = http://repository.timesys.com/buildsources/k/kobs-ng/kobs-ng-$(KOBS_NG_VERSION)/ +KOBS_NG_LICENSE = GPLv2 +KOBS_NG_LICENSE_FILES = COPYING + +define KOBS_NG_INSTALL_TARGET_CMDS + install -D -m 0755 $(@D)/src/kobs-ng $(TARGET_DIR)/usr/sbin +endef + +$(eval $(autotools-package))
package/kobs-ng/kobs-ng.patch new file +67 -0
67 lines not on this page · raw message
Signature · 1 line
1.7.8.6
PATCH 1/1 kobs-ng: new package
Dear Paul B. Henson,
Quoted 16 lines · Paul B. Henson
Signed-off-by Paul B. Henson <[email protected]>--- package/Config.in | 1 + package/kobs-ng/Config.in | 4 ++ package/kobs-ng/kobs-ng.mk | 18 +++++++++++ package/kobs-ng/kobs-ng.patch | 67 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 90 insertions(+), 0 deletions(-) create mode 100644 package/kobs-ng/Config.in create mode 100644 package/kobs-ng/kobs-ng.mk create mode 100644 package/kobs-ng/kobs-ng.patchpackage/Config.in +0
-0
package/Config.in source "package/f2fs-tools/Config.in" · line 213
Quoted 7 lines
package/Config.in +1
-0@@ -207,6 +207,7 @@ source "package/f2fs-tools/Config.in" source "package/flashbench/Config.in" source "package/genext2fs/Config.in" source "package/genromfs/Config.in" +source "package/kobs-ng/Config.in" source "package/makedevs/Config.in" source "package/mtd/Config.in" source "package/nfs-utils/Config.in"
Not sure it should be with the filesystem tools. Maybe just Hardware handling?
package/kobs-ng/Config.in line 4
Quoted 10 lines
package/kobs-ng/Config.in new file +4
-0@@ -0,0 +1,4 @@ +config BR2_PACKAGE_KOBS_NG + bool "kobs-ng" + help + Build freescale kobs-ng utility for burning bootstreams to NAND
Missing upstream URL.
Quoted 6 lines
package/kobs-ng/kobs-ng.mk new file +0
-0
package/kobs-ng/kobs-ng.mk line 9
Quoted 9 lines
package/kobs-ng/kobs-ng.mk new file +9
-0@@ -0,0 +1,18 @@ +################################################################################ +# +# kobs-ng +# +################################################################################ + +# kobs-ng versions have never made much sense :( +KOBS_NG_VERSION = 3.0.35-4.0.0 +KOBS_NG_SOURCE = kobs-ng-$(KOBS_NG_VERSION).tar.gz
Not needed, this is the default.
package/kobs-ng/kobs-ng.mk line 16
Quoted 7 lines
package/kobs-ng/kobs-ng.mk new file +7
-0+KOBS_NG_SITE = http://repository.timesys.com/buildsources/k/kobs-ng/kobs-ng-$(KOBS_NG_VERSION)/ +KOBS_NG_LICENSE = GPLv2 +KOBS_NG_LICENSE_FILES = COPYING + +define KOBS_NG_INSTALL_TARGET_CMDS + install -D -m 0755 $(@D)/src/kobs-ng $(TARGET_DIR)/usr/sbin +endef
Isn't the default 'make install' working properly? Otherwise:
- indentation is one tab, not two spaces
- $(INSTALL) and not install
- when using -D, you must pass a full path as second argument, i.e $(TARGET_DIR)/usr/sbin/kobs-ng
package/kobs-ng/kobs-ng.mk line 18
Quoted 1 line
package/kobs-ng/kobs-ng.mk new file +1
-0+$(eval $(autotools-package))
I'm not sure to understand how this tool is typically used. On the target itself? But then how do you get something on the target from the first place if the tool is needed to flash a bootloader in NAND?
package/kobs-ng/kobs-ng.patch
Quoted 5 lines
package/kobs-ng/kobs-ng.patch new file +0
-0
This patch lacks a header with description and Signed-off-by. Also, is there a chance that you can submit it upstream?
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 kobs-ng: new package
Quoted 2 lines · Thomas Petazzoni
Not sure it should be with the filesystem tools. Maybe just Hardware handling?
The menu says "Filesystem and flash utilities", kobs-ng is a flash utility, so it initially made sense to me. I can move it to the hardware section if you prefer.
Quoted 5 lines
package/kobs-ng/Config.in line 4
Quoted 3 lines
package/kobs-ng/Config.in new file +3
-0+ bool "kobs-ng" + help + Build freescale kobs-ng utility for burning bootstreams to NANDMissing upstream URL.
There isn't really an upstream URL for this specific package. Although it is GPL, and freely distributable, Freescale releases it as part of their board support packages, not as a standalone package. The only way to get it from Freescale is by downloading an entire BSP, each one of which usually has a different version of kobs-ng in it.
It's similar to the existing Freescale elftosb package already in the tree. Although it doesn't look like there is a Config.in in the elftosb directory, only elftosb.mk, so I'm not sure what the current status of that package is.
I see there are also a few other Freescale specific firmware and library packages in the tree (freescale-imx directory), they all say "This library is provided by Freescale as-is and doesn't have an upstream.", should I just put something similar?
Quoted 5 lines
package/kobs-ng/kobs-ng.mk line 9
Quoted 3 lines
package/kobs-ng/kobs-ng.mk new file +3
-0+# kobs-ng versions have never made much sense :( +KOBS_NG_VERSION = 3.0.35-4.0.0 +KOBS_NG_SOURCE = kobs-ng-$(KOBS_NG_VERSION).tar.gzNot needed, this is the default.
You mean the source line, not the version line, right?
Quoted 1 line
Isn't the default 'make install' working properly?
I remember having problems with it on an earlier version, I'll test again with this version and see if they were resolved.
Quoted 3 lines
I'm not sure to understand how this tool is typically used. On the target itself? But then how do you get something on the target from the first place if the tool is needed to flash a bootloader in NAND?
Yes, the tool is typically used on the target itself. I don't have extensive experience with freescale, but my understanding is you typically bootstrap via some other boot method (SD card, USB-DFU, etc) to initially burn a bootstream to NAND. At that point, you can update the bootloader in an environment booted from NAND. u-boot has a tool called mxsboot that tries to generate a bootstream image that can be burned directly to NAND, but it makes a lot of assumptions about things kobs-ng determines dynamically and it seems more reliable to use the freescale purposed tool on the actual target environment.
Quoted 2 lines
This patch lacks a header with description and Signed-off-by. Also, is there a chance that you can submit it upstream?
I'll add a header. I'm really not sure how one would submit changes to freescale upstream; AFAIK their code repository is not public and they don't have a mailing list for this tool's development. They have some general-purpose forums, and there are a fair number of freescale employees subscribed to various embedded oriented mailing lists (perhaps even this one?), but short of purchasing a support contract I don't know that there is any way to get official freescale notice of a patch submission.
Thanks?
PATCH 1/1 kobs-ng: new package
Quoted 8 lines · Paul B. Henson
Quoted 2 lines · Thomas Petazzoni
Not sure it should be with the filesystem tools. Maybe just Hardware handling?
The menu says "Filesystem and flash utilities", kobs-ng is a flash utility, so it initially made sense to me. I can move it to the hardware section if you prefer.
I resubmitted the patch to add kobs-ng; I think I addressed all of your feedback other than the category. I don't think I saw a response to this, so I left it in the flash utility category. I can move it to the hardware handling category and resubmit if you still think that's a better place for it.
Thanks...