Skip to contentSkip to conversation

sf: spansion: Add support for S25FL512S_256K

PATCH New Nobuhiro Iwamatsu 3 participants 4 messages Jul 31, 2013 – Oct 3, 2013 Memory technology devices (MTD)

lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 sf: spansion: Add support for S25FL512S_256K

Add support for Spansion S25FL512S_256K SPI flash.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/mtd/spi/spansion.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/spi/spansion.c +8 -0
index 47a4897..a7dc096 100644
@@ -1,4 +1,5 @@
 /*
+ * Copyright (C) 2013 Renesas Electronics Corporation
  * Copyright (C) 2009 Freescale Semiconductor, Inc.
  *
  * Author: Mingkai Hu (Mingkai.hu at freescale.com)

@@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.nr_sectors = 1024,
 		.name = "S25FL512S_64K",
 	},
+	{
+		.idcode1 = 0x0220,
+		.idcode2 = 0x4d00,
+		.pages_per_sector = 1024,
+		.nr_sectors = 256,
+		.name = "S25FL512S_256K",
+	},
 };
 
 struct spi_flash *spi_flash_probe_spansion(struct spi_slave *spi, u8 *idcode)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 sf: spansion: Add support for S25FL512S_256K

Quoted 12 lines · Nobuhiro Iwamatsu

Add support for Spansion S25FL512S_256K SPI flash.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/mtd/spi/spansion.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/spi/spansion.c +0 -0
index 47a4897..a7dc096 100644

drivers/mtd/spi/spansion.c line 2

Quoted 2 lines
drivers/mtd/spi/spansion.c +1 -0
@@ -1,4 +1,5 @@
 /*
+ * Copyright (C) 2013 Renesas Electronics Corporation

I don't think that this is huge contribution that you should also update header.

Quoted 4 lines
drivers/mtd/spi/spansion.c +0 -0
  * Copyright (C) 2009 Freescale Semiconductor, Inc.
  *
  * Author: Mingkai Hu (Mingkai.hu at freescale.com)

drivers/mtd/spi/spansion.c static const struct spansion_spi_flash_params spansion_spi_flash_table[] = { · line 111

Quoted 10 lines
drivers/mtd/spi/spansion.c +7 -0
@@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.nr_sectors = 1024,
 		.name = "S25FL512S_64K",
 	},
+	{
+		.idcode1 = 0x0220,
+		.idcode2 = 0x4d00,
+		.pages_per_sector = 1024,
+		.nr_sectors = 256,
+		.name = "S25FL512S_256K",
+	},

Jagan sent very similar patch
http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
but nr_sectors and pages_per_sector are swapped.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130731/a5d64088/attachment.pgp>
author
#2 lore raw

PATCH 1/1 sf: spansion: Add support for S25FL512S_256K

Hi,

Thank you for your review.

2013/7/31 Michal Simek <[email protected]>:

Quoted 8 lines · Nobuhiro Iwamatsu
Quoted 7 lines

Add support for Spansion S25FL512S_256K SPI flash.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/mtd/spi/spansion.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Quoted 10 lines

drivers/mtd/spi/spansion.c line 2

Quoted 7 lines
drivers/mtd/spi/spansion.c +1 -0
index 47a4897..a7dc096 100644
@@ -1,4 +1,5 @@
 /*
+ * Copyright (C) 2013 Renesas Electronics Corporation

I don't think that this is huge contribution that you should also update header.

Hm, OK. I remove this line.

Quoted 10 lines
Quoted 10 lines
drivers/mtd/spi/spansion.c +3 -0
  * Copyright (C) 2009 Freescale Semiconductor, Inc.
  *
  * Author: Mingkai Hu (Mingkai.hu at freescale.com)

@@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
              .nr_sectors = 1024,
              .name = "S25FL512S_64K",
      },
+     {
+             .idcode1 = 0x0220,
+             .idcode2 = 0x4d00,
Quoted 8 lines

drivers/mtd/spi/spansion.c static const struct spansion_spi_flash_params spansion_spi_flash_table[] = { · line 111

Quoted 4 lines
drivers/mtd/spi/spansion.c +4 -0
+             .pages_per_sector = 1024,
+             .nr_sectors = 256,
+             .name = "S25FL512S_256K",
+     },

Jagan sent very similar patch
http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
but nr_sectors and pages_per_sector are swapped.

I did not notice this patch, thanks.
I wait patch of Jagan to be merged.

Best regards,
Nobuhiro

Quoted 18 lines

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 1 line
Nobuhiro Iwamatsu
#3 lore raw

PATCH 1/1 sf: spansion: Add support for S25FL512S_256K

Please try to test your part in u-boot-spi.git with master-probe branch. We have a new probe setup code.

Let me know for any issues or concerns.

Quoted 78 lines · Nobuhiro Iwamatsu

Hi,

Thank you for your review.

2013/7/31 Michal Simek <[email protected]>:

Quoted 8 lines · Nobuhiro Iwamatsu
Quoted 7 lines

Add support for Spansion S25FL512S_256K SPI flash.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
---
 drivers/mtd/spi/spansion.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Quoted 10 lines

drivers/mtd/spi/spansion.c line 2

Quoted 7 lines
drivers/mtd/spi/spansion.c +1 -0
index 47a4897..a7dc096 100644
@@ -1,4 +1,5 @@
 /*
+ * Copyright (C) 2013 Renesas Electronics Corporation

I don't think that this is huge contribution that you should also update header.

Hm, OK. I remove this line.

Quoted 10 lines
Quoted 10 lines
drivers/mtd/spi/spansion.c +3 -0
  * Copyright (C) 2009 Freescale Semiconductor, Inc.
  *
  * Author: Mingkai Hu (Mingkai.hu at freescale.com)

@@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
              .nr_sectors = 1024,
              .name = "S25FL512S_64K",
      },
+     {
+             .idcode1 = 0x0220,
+             .idcode2 = 0x4d00,
Quoted 8 lines

drivers/mtd/spi/spansion.c static const struct spansion_spi_flash_params spansion_spi_flash_table[] = { · line 111

Quoted 4 lines
drivers/mtd/spi/spansion.c +4 -0
+             .pages_per_sector = 1024,
+             .nr_sectors = 256,
+             .name = "S25FL512S_256K",
+     },

Jagan sent very similar patch
http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
but nr_sectors and pages_per_sector are swapped.

I did not notice this patch, thanks.
I wait patch of Jagan to be merged.

Best regards,
Nobuhiro

Quoted 13 lines

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Nobuhiro Iwamatsu
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki