Skip to contentSkip to conversation

icu: fix configure error

PATCH In review Bian Naimeng 2 participants 3 messages Aug 5, 2013 – Aug 6, 2013

lore
Share & tools
lore

Bian Naimeng

author
#0 lore raw

PATCH 1/1 icu: fix configure error

If we don't create ${STAGING_ICU_DIR_NATIVE} before doing do_configure for cross target, the following will be caught.

 |configure: error: No such directory ${cross_buildroot} supplied as
 | the argument to --with-cross-build. Use an absolute path.
 |Configure failed. The contents of all config.log files follows to
 | aid debugging
 |ERROR: oe_runconf failed
Signed-off-by Bian Naimeng <[email protected]>
---
 meta/recipes-support/icu/icu.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-support/icu/icu.inc +1 -0
index e3944cd..3987e42 100644
@@ -27,6 +27,7 @@ EXTRA_OECONF_class-native = ""
 # http://bugs.icu-project.org/trac/ticket/9790
 do_configure_prepend() {
     [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
+    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
 }
 
 do_install_append_class-native() {
Signature · 1 line
1.7.7
#1 lore raw
Quoted 9 lines · Bian Naimeng

If we don't create ${STAGING_ICU_DIR_NATIVE} before doing do_configure for cross target, the following will be caught.

  |configure: error: No such directory ${cross_buildroot} supplied as
  | the argument to --with-cross-build. Use an absolute path.
  |Configure failed. The contents of all config.log files follows to
  | aid debugging
  |ERROR: oe_runconf failed

Is this really needed? Which ICU is failing, the target or -native version? The target version depends on the -native version which should have created this directory first.

What are the steps to reproduce this?

Sau!

Quoted 19 lines
Signed-off-by Bian Naimeng <[email protected]>
---
  meta/recipes-support/icu/icu.inc |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-support/icu/icu.inc +1 -0
index e3944cd..3987e42 100644
@@ -27,6 +27,7 @@ EXTRA_OECONF_class-native = ""
  # http://bugs.icu-project.org/trac/ticket/9790
  do_configure_prepend() {
      [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
+    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
  }
 
  do_install_append_class-native() {
author
#2 lore raw
Quoted 4 lines · Saul Wold
Quoted 3 lines · Bian Naimeng

If we don't create ${STAGING_ICU_DIR_NATIVE} before doing do_configure for cross target, the following will be caught.

Quoted 8 lines
Quoted 6 lines
  |configure: error: No such directory ${cross_buildroot} supplied as
  | the argument to --with-cross-build. Use an absolute path.
  |Configure failed. The contents of all config.log files follows to
  | aid debugging
  |ERROR: oe_runconf failed

Is this really needed? Which ICU is failing, the target or -native version? The target version depends on the -native version which should have created this directory first.

We don't need it almost.
As you said, the native version will create this directory first.

Quoted 1 line

What are the steps to reproduce this?

It occurs in my strange case.
My icu-native is different version from icu.

In my opinion, it's better to remove this dependence.

Thanks
Bian

Quoted 21 lines

Sau!

Quoted 18 lines
Signed-off-by Bian Naimeng <[email protected]>
---
  meta/recipes-support/icu/icu.inc |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-support/icu/icu.inc +1 -0
index e3944cd..3987e42 100644
@@ -27,6 +27,7 @@ EXTRA_OECONF_class-native = ""
  # http://bugs.icu-project.org/trac/ticket/9790
  do_configure_prepend() {
      [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
+    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
  }
 
  do_install_append_class-native() {