Skip to contentSkip to conversation

netlink: remove duplicated nla_need_padding_for_64bit() check

PATCH linmiaohe 2 participants 2 messages Aug 24, 2020

lore
Share & tools
lore

linmiaohe

author
#0 lore raw

friendly ping :)

Quoted 24 lines

Miaohe Lin <[email protected]> wrote:
From: Miaohe Lin <[email protected]>

The need for padding 64bit is implicitly checked by nla_align_64bit(), so remove this explicit one.

---
lib/nlattr.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
lib/nlattr.c +1 -3
@@ -816,8 +816,7 @@ EXPORT_SYMBOL(__nla_reserve);  struct nlattr *__nla_reserve_64bit(struct sk_buff *skb, int attrtype,
 				   int attrlen, int padattr)
 {
-	if (nla_need_padding_for_64bit(skb))
-		nla_align_64bit(skb, padattr);
+	nla_align_64bit(skb, padattr);
 
 	return __nla_reserve(skb, attrtype, attrlen);  }
--

2.19.1