Skip to contentSkip to conversation

kexec: remove unnecessary return

PATCH Superseded Xishi Qiu 2 participants 2 messages Aug 6, 2013

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Xishi Qiu

author
#0 lore raw

PATCH 1/1 kexec: remove unnecessary return

Code can not run here forever, so remove the unnecessary return.

---
 kernel/kexec.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/kexec.c +0 -2
index 59f7b55..c14e3ea 100644
@@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
 	else
 		return parse_crashkernel_simple(ck_cmdline, crash_size,
 				crash_base);
-
-	return 0;
 }
 
 /*
Signature · 7 lines
1.7.1


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#1 lore raw
Quoted 13 lines · Xishi Qiu

Code can not run here forever, so remove the unnecessary return.

---
 kernel/kexec.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/kexec.c +0 -0
index 59f7b55..c14e3ea 100644

kernel/kexec.c static int __init __parse_crashkernel(char *cmdline, · line 1482

Quoted 8 lines
kernel/kexec.c +0 -2
@@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
 	else
 		return parse_crashkernel_simple(ck_cmdline, crash_size,
 				crash_base);
-
-	return 0;
 }
 
 /*

Hi Xishi,

change

1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);
1477 else
1478 return parse_crashkernel_simple(ck_cmdline, crash_size,
1479 crash_base);
1480
1481 return 0;

to

1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);

1478 return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);

seems better.

Signature · 2 lines
Thanks.
Zhang Yanfei