acm.c: In acm_port_up, handle noncontiguous pkeys

There can be "holes" in pkey table although this is not usually the case but since IBA spec allows for this, it should be handled.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
 src/acm.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

src/acm.c +0 -5

index 81aeeb4..a15f094 100644
@@ -3192,11 +3192,6 @@ static void acm_port_up(struct acm_port *port)
 			break;
 	}
 
-	for (port->pkey_cnt = 0;; port->pkey_cnt++) {
-		ret = ibv_query_pkey(port->dev->verbs, port->port_num, port-
 >pkey_cnt, &pkey);
-		if (ret || !pkey)
-			break;
-	}
 	port->lid = attr.lid;
 	port->lid_mask = 0xffff - ((1 << attr.lmc) - 1);

@@ -3214,8 +3209,13 @@ static void acm_port_up(struct acm_port *port)
 		return;
 

Quoted 28 lines

There can be "holes" in pkey table although this is not usually the case but since IBA spec allows for this, it should be handled.

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
 src/acm.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

src/acm.c +0 -5

index 81aeeb4..a15f094 100644
@@ -3192,11 +3192,6 @@ static void acm_port_up(struct acm_port *port)
 			break;
 	}
 
-	for (port->pkey_cnt = 0;; port->pkey_cnt++) {
-		ret = ibv_query_pkey(port->dev->verbs, port->port_num, port-
 > pkey_cnt, &pkey);
-		if (ret || !pkey)
-			break;
-	}
 	port->lid = attr.lid;
 	port->lid_mask = 0xffff - ((1 << attr.lmc) - 1);

@@ -3214,8 +3209,13 @@ static void acm_port_up(struct acm_port *port)
 		return;
 

src/acm.c static void acm_port_up(struct acm_port *port) · line 3218

Quoted 10 lines

src/acm.c +7 -2

 	atomic_set(&port->sa_dest.refcnt, 1);
-	for (i = 0; i < port->pkey_cnt; i++)
-		 acm_ep_up(port, (uint16_t) i);
+	for (i = 0; i < attr.pkey_tbl_len; i++) {
+		ret = ibv_query_pkey(port->dev->verbs, port->port_num, i, &pkey);
+		if (ret || !pkey)
+			continue;
+		port->pkey_cnt++;
+		acm_ep_up(port, (uint16_t) i);
+	}

I think we can remove pkey_cnt from struct acm_port as part of this change. If you agree, I can fix that up when applying the patch (no need to update).