Skip to contentSkip to conversation

memory: Return -1 again on reads from unsigned regions

PATCH Applied Jan Kiszka 4 participants 5 messages Jul 16, 2013 – Aug 8, 2013

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 memory: Return -1 again on reads from unsigned regions

This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this.

Signed-off-by Jan Kiszka <[email protected]>
---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
memory.c +1 -1
index 757e9a5..d19b61b 100644
@@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
         cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
                               addr, false, false, 0, size);
     }
-    return 0;
+    return -1ULL;
 }
 
 static void unassigned_mem_write(void *opaque, hwaddr addr,
Signature · 1 line
1.7.3.4
Applied
#1 lore raw

Il 16/07/2013 14:45, Jan Kiszka ha scritto:

Quoted 15 lines

This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this.

Signed-off-by Jan Kiszka <[email protected]>
---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
memory.c +0 -0
index 757e9a5..d19b61b 100644

memory.c static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, · line 865

Quoted 8 lines
memory.c +1 -1
@@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
         cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
                               addr, false, false, 0, size);
     }
-    return 0;
+    return -1ULL;
 }
 
 static void unassigned_mem_write(void *opaque, hwaddr addr,

Applied, thanks.

Paolo

Tested-by on v1 1/1
#2 lore raw
In reply to Jan Kiszka
Quoted 14 lines · Jan Kiszka

This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this.

Signed-off-by Jan Kiszka <[email protected]>
---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
memory.c +0 -0
index 757e9a5..d19b61b 100644

memory.c static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, · line 865

Quoted 8 lines
memory.c +1 -1
@@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
         cpu_unassigned_access(ENV_GET_CPU(cpu_single_env),
                               addr, false, false, 0, size);
     }
-    return 0;
+    return -1ULL;
 }
 
 static void unassigned_mem_write(void *opaque, hwaddr addr,

Fixes the IPMI timeout while booting RHEL 6.4 guests.

Tested-by Stefan Hajnoczi <[email protected]>
#3 lore raw
In reply to Jan Kiszka
Quoted 5 lines · Jan Kiszka

This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this.

Signed-off-by Jan Kiszka <[email protected]>

For the record (I know you have a revert-patch on the list) this patch breaks the 'musicpal' platform (my test image no longer boots with this change).

-- PMM

author
#4 lore raw
Quoted 10 lines · Peter Maydell
Quoted 5 lines · Jan Kiszka

This restore the behavior prior to b018ddf633 which accidentally changed the return code to 0. Specifically guests probing for register existence were affected by this.

Signed-off-by Jan Kiszka <[email protected]>

For the record (I know you have a revert-patch on the list) this patch breaks the 'musicpal' platform (my test image no longer boots with this change).

Yes, that's how I finally found out as well that this patch was wrong.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux