Staging: BCM: Removed more whitespace/Errors
PATCH 2/2 Staging: BCM: Removed more whitespace/Errors
Quoted 1 line
From
9f6231ce16996e35545e20ce1d91abc058f2a6fbMon Sep 17 00:00:00 2001
From: Paul McQuade <[email protected]>
Date: Thu, 8 Aug 2013 17:49:22 +0100
Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors
Interface Whitespace/Errors Removed with the help of checkpatch.pl
--- drivers/staging/bcm/InterfaceMacros.h | 6 +- drivers/staging/bcm/InterfaceMisc.h | 14 +-- drivers/staging/bcm/InterfaceRx.c | 166 ++++++++++++++------------------- drivers/staging/bcm/InterfaceTx.c | 135 +++++++++++---------------- 4 files changed, 136 insertions(+), 185 deletions(-)
drivers/staging/bcm/InterfaceMacros.h +3 -3
@@ -3,14 +3,14 @@#define BCM_USB_MAX_READ_LENGTH 2048 -#define MAXIMUM_USB_TCB 128 -#define MAXIMUM_USB_RCB 128 +#define MAXIMUM_USB_TCB 128 +#define MAXIMUM_USB_RCB 128#define MAX_BUFFERS_PER_QUEUE 256#define MAX_DATA_BUFFER_SIZE 2048 -//Num of Asynchronous reads pending +/* Num of Asynchronous reads pending */ #define NUM_RX_DESC 64#define SYS_CFG 0x0F000C00
drivers/staging/bcm/InterfaceMisc.h +7 -7
@@ -14,13 +14,13 @@ InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter, INT len); -int InterfaceFileDownload (PVOID psIntfAdapter, -struct file *flp, -unsigned int on_chip_loc); +int InterfaceFileDownload (PVOID psIntfAdapter, +struct file *flp, +unsigned int on_chip_loc); -int InterfaceFileReadbackFromChip (PVOID psIntfAdapter, -struct file *flp, -unsigned int on_chip_loc); +int InterfaceFileReadbackFromChip (PVOID psIntfAdapter, +struct file *flp, +unsigned int on_chip_loc); int BcmRDM(PVOID arg,
@@ -39,4 +39,4 @@ VOID Bcm_kill_all_URBs(struct bcm_interface_adapter *psIntfAdapter);#define DISABLE_USB_ZERO_LEN_INT 0x0F011878 -#endif // __INTERFACE_MISC_H +#endif /* __INTERFACE_MISC_H */
drivers/staging/bcm/InterfaceRx.c +70 -96
285 lines not on this page · raw message
drivers/staging/bcm/InterfaceTx.c +56 -79
229 lines not on this page · raw message
Signature · 1 line
1.7.10.4
Please send your changes with an email client
that does not require attaching patches.
drivers/staging/bcm/InterfaceMacros.h line 11
Quoted 8 lines · Paul McQuade
drivers/staging/bcm/InterfaceMacros.h +2
-2-#define MAXIMUM_USB_TCB 128 -#define MAXIMUM_USB_RCB 128 +#define MAXIMUM_USB_TCB 128 +#define MAXIMUM_USB_RCB 128#define MAX_BUFFERS_PER_QUEUE 256#define MAX_DATA_BUFFER_SIZE 2048
If you're going to bother to change whitespace
here, please align these like the others.
There are also many style defect like:
+ } else {
+ BCM_DEBUG_PRINT(Adapter, DBG_TYPE_RX, RX_DPC, DBG_LVL_ALL, "Rx URB has got cancelled. status
so I stopped looking.
drivers/staging/bcm/InterfaceMisc.h InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter, · line 19
Quoted 6 lines · Paul McQuade
drivers/staging/bcm/InterfaceMisc.h +3
-3-int InterfaceFileDownload (PVOID psIntfAdapter, -struct file *flp, -unsigned int on_chip_loc); +int InterfaceFileDownload (PVOID psIntfAdapter, +struct file *flp, +unsigned int on_chip_loc);
The very first line in this patch is totally wrong... :(
This is an automated patch. I'm not going to review any further. Automated patches create a problem for reviews because they are far harder to review than they are to generate. I'm not sure what the solution is...
Anyway, the patch is very wrong.
regards,
dan carpenter
Quoted 11 lines · Dan Carpenter
drivers/staging/bcm/InterfaceMisc.h InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter, · line 19
Quoted 6 lines · Paul McQuade
drivers/staging/bcm/InterfaceMisc.h +3
-3-int InterfaceFileDownload (PVOID psIntfAdapter, -struct file *flp, -unsigned int on_chip_loc); +int InterfaceFileDownload (PVOID psIntfAdapter, +struct file *flp, +unsigned int on_chip_loc);The very first line in this patch is totally wrong... :(
Quoted 1 line
This is an automated patch.
It is?
It doesn't look like an automated patch to me. It looks like there are too many different style choices for it to have been done by a machine.
Why do you think that?
Paul, how did you create this patch?
Dan, if you get a chance, could you try to use checkpatch with the --fix option with specific --types like SPACING and PARENTHESIS_ALIGNMENT and tell me if you think it's OK?