net: fec_mpc52xx_phy: use platform_{get,set}_drvdata()
Subsystems (2)
PATCH 3/8 net: fec_mpc52xx_phy: use platform_{get,set}_drvdata()
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device.
Signed-off-by Libo Chen <[email protected]>
--- drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c +1 -3
@@ -123,12 +123,10 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of)static int mpc52xx_fec_mdio_remove (struct platform_device *of) { -struct device *dev = &of->dev; -struct mii_bus *bus =dev_get_drvdata (dev); +struct mii_bus *bus =platform_get_drvdata (of);struct mpc52xx_fec_mdio_priv *priv = bus->priv;mdiobus_unregister (bus); -dev_set_drvdata (dev,NULL );iounmap (priv->regs);kfree (priv);mdiobus_free (bus);
Signature · 1 line
1.7.1
PATCH RESEND 3/8 net: fec_mpc52xx_phy: use platform_{get,set}_drvdata()
We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &of->dev, it is convenient for user.
Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure.
Signed-off-by Libo Chen <[email protected]>
--- drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c +1 -3
@@ -123,12 +123,10 @@ static int mpc52xx_fec_mdio_probe(struct platform_device *of)static int mpc52xx_fec_mdio_remove (struct platform_device *of) { -struct device *dev = &of->dev; -struct mii_bus *bus =dev_get_drvdata (dev); +struct mii_bus *bus =platform_get_drvdata (of);struct mpc52xx_fec_mdio_priv *priv = bus->priv;mdiobus_unregister (bus); -dev_set_drvdata (dev,NULL );iounmap (priv->regs);kfree (priv);mdiobus_free (bus);
Signature · 1 line
1.7.1