What's cooking in git.git (Apr 2024, #10; Mon, 29)
Here are the topics that have been cooking in my tree. Commits prefixed with '+' are in 'next' (being in 'next' is a sign that a topic is stable enough to be used and are candidate to be in a future release). Commits prefixed with '-' are only in 'seen', and aren't considered "accepted" at all and may be annotated with an URL to a message that raises issues but they are no means exhaustive. A topic without enough support may be discarded after a long period of no activity (of course they can be resubmit when new interests arise).
Git 2.45 has been tagged.
Copies of the source code to Git live in many repositories, and the following is a list of the ones I push into or their mirrors. Some repositories have only a subset of branches.
With maint, master, next, seen, todo:
git://git.kernel.org/pub/scm/git/git.git/ git://repo.or.cz/alt-git.git/ https://kernel.googlesource.com/pub/scm/git/git/ https://github.com/git/git/ https://gitlab.com/git-scm/git/
With all the integration branches and topics broken out:
https://github.com/gitster/git/
Even though the preformatted documentation in HTML and man format are not sources, they are published in these repositories for convenience (replace "htmldocs" with "manpages" for the manual pages):
git://git.kernel.org/pub/scm/git/git-htmldocs.git/
https://github.com/gitster/git-htmldocs.git/
Release tarballs are available at:
https://www.kernel.org/pub/software/scm/git/
--------------------------------------------------
[Graduated to 'master']
* rj/add-i-leak-fix (2024-04-22) 4 commits (merged to 'next' on 2024-04-23 at b10e350a54)
+ add: plug a leak on interactive_add
+ add-patch: plug a leak handling the '/' command
+ add-interactive: plug a leak in get_untracked_files
+ apply: plug a leak in apply_data
Leakfix.
source: <[email protected]>
* rs/vsnprintf-failure-is-not-a-bug (2024-04-21) 1 commit (merged to 'next' on 2024-04-23 at bf66ab6ea7)
+ don't report vsnprintf(3) error as bug
Demote a BUG() to an die() when the failure from vsnprintf() may not be due to a programmer error.
source: <[email protected]>
--------------------------------------------------
[New Topics]
* rh/complete-symbolic-ref (2024-04-25) 3 commits
- completion: add docs on how to add subcommand completions
- completion: improve docs for using __git_complete
- completion: add 'symbolic-ref'
Command line completion script (in contrib/) learned to complete "git symbolic-ref" a bit better (you need to enable plumbing commands to be completed with GIT_COMPLETION_SHOW_ALL_COMMANDS).
Will merge to 'next'.
source: <[email protected]>
* jt/doc-submitting-rerolled-series (2024-04-25) 1 commit
- doc: clarify practices for submitting updated patch versions
Developer doc update.
Will merge to 'next'.
source: <[email protected]>
* bc/zsh-compatibility (2024-04-26) 2 commits
- vimdiff: make script and tests work with zsh
- t4046: avoid continue in &&-chain for zsh
source: <[email protected]>
* jc/rev-parse-fatal-doc (2024-04-28) 1 commit
- rev-parse: document that most of the time you need to be in a repository
--------------------------------------------------
[Cooking]
* ps/undecided-is-not-necessarily-sha1 (2024-04-29) 13 commits
- SQUASH???
- repository: stop setting SHA1 as the default object hash
- builtin/shortlog: don't set up revisions without repo
- builtin/diff: explicitly set hash algo when there is no repo
- builtin/bundle: abort "verify" early when there is no repository
- builtin/blame: don't access potentially unitialized the_hash_algo
- builtin/rev-parse: allow shortening to more than 40 hex characters
- remote-curl: fix parsing of detached SHA256 heads
- attr: fix BUG() when parsing attrs outside of repo
- attr: don't recompute default attribute source
- parse-options-cb: only abbreviate hashes when hash algo is known
- path: move validate_headref() to its only user
- path: harden validation of HEAD with non-standard hashes
Before discovering the repository details, We used to assume SHA-1 as the "default" hash function, which has been corrected. Hopefully this will smoke out codepaths that rely on such an unwarranted assumptions.
fuzz-smoke-test job at GitHub Actions CI breaks with this in 'seen' cf. <[email protected]>
source: <[email protected]>
* aj/stash-staged-fix (2024-04-22) 1 commit
(merged to 'next' on 2024-04-23 at d49e9dade0)
+ stash: fix "--staged" with binary files
"git stash -S" did not handle binary files correctly, which has been corrected.
Will cook in 'next'.
source: <[email protected]>
* rj/add-p-typo-reaction (2024-04-26) 1 commit
- add-patch: response to unknown command
When the user responds to a prompt given by "git add -p" with an unsupported command, list of available commands were given, which was too much if the user knew what they wanted to type but merely made a typo. Now the user gets a much shorter error message.
Expecting a reroll.
cf. <[email protected]>
source: <[email protected]>
* ds/format-patch-rfc-and-k (2024-04-19) 1 commit (merged to 'next' on 2024-04-23 at b3b0c5507a)
+ format-patch: ensure that --rfc and -k are mutually exclusive
The "-k" and "--rfc" options of "format-patch" will now error out when used together, as one tells us not to add anything to the title of the commit, and the other one tells us to add "RFC" in addition to "PATCH".
Will cook in 'next'.
source: <71d195c248879e7c46fac0e84c6b0a8aa90bd2c2.1713488563.git.dsimic@manjaro.org>
* jc/format-patch-rfc-more (2024-04-23) 2 commits
(merged to 'next' on 2024-04-23 at 9f51487974)
+ format-patch: "--rfc=-(WIP)" appends to produce [PATCH (WIP)]
+ format-patch: allow --rfc to optionally take a value, like --rfc=WIP
The "--rfc" option of "git format-patch" learned to take an optional string value to be used in place of "RFC" to tweak the "[PATCH]" on the subject header.
Will cook in 'next'.
source: <[email protected]>
* ps/the-index-is-no-more (2024-04-18) 6 commits
- repository: drop initialize_the_repository()
- repository: drop the_index variable
- builtin/clone: stop using the_index
- repository: initialize index in repo_init()
- builtin: stop using the_index
- t/helper: stop using the_index
The singleton index_state instance "the_index" has been eliminated by always instantiating "the_repository" and replacing references to "the_index" with references to its .index member.
Will merge to 'next'?
source: <[email protected]>
* pw/rebase-m-signoff-fix (2024-04-18) 6 commits (merged to 'next' on 2024-04-23 at 66374c00e2)
+ rebase -m: fix --signoff with conflicts
+ sequencer: store commit message in private context
+ sequencer: move current fixups to private context
+ sequencer: start removing private fields from public API
+ sequencer: always free "struct replay_opts"
+ Merge branch 'pw/t3428-cleanup' into pw/rebase-m-signoff-fix
"git rebase --signoff" used to forget that it needs to add a sign-off to the resulting commit when told to continue after a conflict stops its operation.
Will cook in 'next'.
source: <[email protected]>
* js/for-each-repo-keep-going (2024-04-24) 2 commits (merged to 'next' on 2024-04-25 at d33253d919)
+ maintenance: running maintenance should not stop on errors
+ for-each-repo: optionally keep going on an error
A scheduled "git maintenance" job is expected to work on all repositories it knows about, but it stopped at the first one that errored out. Now it keeps going.
Will cook in 'next'.
source: <[email protected]>
* xx/disable-replace-when-building-midx (2024-04-17) 1 commit (merged to 'next' on 2024-04-23 at 6c8f41740e)
+ midx: disable replace objects
The procedure to build multi-pack-index got confused by the replace-refs mechanism, which has been corrected by disabling the latter.
Will cook in 'next'.
source: <[email protected]>
* kn/update-ref-symrefs (2024-04-26) 7 commits
- ref: support symrefs in 'reference-transaction' hook
- update-ref: add support for 'symref-update' command
- update-ref: add support for 'symref-create' command
- update-ref: add support for 'symref-delete' command
- update-ref: add support for 'symref-verify' command
- files-backend: extract out create_symref_lock
- refs: accept symref values in ref_transaction[_add]_update
"update-ref" learns to also handle symbolic refs.
Expecting a reroll.
cf. <CAOLa=ZT4yVEuZXmiTVB2tf0qaTPCPn=0TcJRc89knZQWZBbFTg@mail.gmail.com>
source: <[email protected]>
* la/doc-use-of-contacts-when-contributing (2024-04-18) 8 commits (merged to 'next' on 2024-04-25 at 5102a45f63)
+ SubmittingPatches: demonstrate using git-contacts with git-send-email
+ SubmittingPatches: add heading for format-patch and send-email
+ SubmittingPatches: dedupe discussion of security patches
+ SubmittingPatches: discuss reviewers first
+ SubmittingPatches: quote commands
+ SubmittingPatches: mention GitGitGadget
+ SubmittingPatches: clarify 'git-contacts' location
+ MyFirstContribution: mention contrib/contacts/git-contacts
Advertise "git contacts", a tool for newcomers to find people to ask review for their patches, a bit more in our developer documentation.
Will cook in 'next'.
source: <[email protected]>
* ps/ci-test-with-jgit (2024-04-12) 13 commits
- t0612: add tests to exercise Git/JGit reftable compatibility
- t0610: fix non-portable variable assignment
- t06xx: always execute backend-specific tests
- ci: install JGit dependency
- ci: make Perforce binaries executable for all users
- ci: merge scripts which install dependencies
- ci: fix setup of custom path for GitLab CI
- ci: merge custom PATH directories
- ci: convert "install-dependencies.sh" to use "/bin/sh"
- ci: drop duplicate package installation for "linux-gcc-default"
- ci: skip sudo when we are already root
- ci: expose distro name in dockerized GitHub jobs
- ci: rename "runs_on_pool" to "distro"
Tests to ensure interoperability between reftable written by jgit and our code have been added and enabled in CI.
Will merge to 'next'.
source: <[email protected]>
* pw/rebase-i-error-message (2024-04-08) 2 commits
- rebase -i: improve error message when picking merge
- rebase -i: pass struct replay_opts to parse_insn_line()
When the user adds to "git rebase -i" instruction to "pick" a merge commit, the error experience is not pleasant. Such an error is now caught earlier in the process that parses the todo list.
Expecting a reroll.
cf. <[email protected]>
source: <[email protected]>
* ps/reftable-write-optim (2024-04-08) 11 commits
- reftable/block: reuse compressed array
- reftable/block: reuse zstream when writing log blocks
- reftable/writer: reset last_key instead of releasing it
- reftable/writer: unify releasing memory
- reftable/writer: refactorings for writer_flush_nonempty_block()
- reftable/writer: refactorings for writer_add_record()
- refs/reftable: don't recompute committer ident
- reftable: remove name checks
- refs/reftable: skip duplicate name checks
- refs/reftable: perform explicit D/F check when writing symrefs
- refs/reftable: fix D/F conflict error message on ref copy
Code to write out reftable has seen some optimization and simplification.
Will merge to 'next'?
source: <[email protected]>
* ds/send-email-per-message-block (2024-04-10) 2 commits
- send-email: make it easy to discern the messages for each patch
- send-email: move newline characters out of a few translatable strings
"git send-email" learned to separate its reports on each message it sends out with an extra blank line in between.
Will merge to 'next'?
source: <[email protected]>
* ew/khash-to-khashl (2024-03-28) 3 commits
- khashl: fix ensemble lookups on empty table
- treewide: switch to khashl for memory savings
- list-objects-filter: use kh_size API
The hashtable library "khash.h" has been replaced with "khashl.h" that has better memory usage characteristics.
Needs review.
cf. <[email protected]>
source: <[email protected]>
* bc/credential-scheme-enhancement (2024-04-16) 16 commits
- credential: add method for querying capabilities
- credential-cache: implement authtype capability
- t: add credential tests for authtype
- credential: add support for multistage credential rounds
- t5563: refactor for multi-stage authentication
- docs: set a limit on credential line length
- credential: enable state capability
- credential: add an argument to keep state
- http: add support for authtype and credential
- docs: indicate new credential protocol fields
- credential: add a field called "ephemeral"
- credential: gate new fields on capability
- credential: add a field for pre-encoded credentials
- http: use new headers for each object request
- remote-curl: reset headers on new request
- credential: add an authtype field
The credential helper protocol, together with the HTTP layer, have been enhanced to support authentication schemes different from username & password pair, like Bearer and NTLM.
Comments?
source: <[email protected]>
* tb/pseudo-merge-reachability-bitmap (2024-03-20) 24 commits
- t/perf: implement performace tests for pseudo-merge bitmaps
- pseudo-merge: implement support for finding existing merges
- ewah: bitmap_equals_ewah()
- pack-bitmap: extra trace2 information
- pack-bitmap.c: use pseudo-merges during traversal
- t/test-lib-functions.sh: support --date in test_commit_bulk()
- pack-bitmap: implement test helpers for pseudo-merge
- ewah: implement ewah_bitmap_popcount()
- pseudo-merge: implement support for reading pseudo-merge commits
- pack-bitmap.c: read pseudo-merge extension
- pseudo-merge: scaffolding for reads
- pack-bitmap: extract read_bitmap() function
- pack-bitmap-write.c: write pseudo-merge table
- pack-bitmap-write.c: select pseudo-merge commits
- pseudo-merge: implement support for selecting pseudo-merge commits
- pack-bitmap: make bitmap_writer_push_bitmapped_commit() public
- pack-bitmap: implement bitmap_writer_has_bitmapped_object_id()
- pack-bitmap-write: support storing pseudo-merge commits
- pseudo-merge.ch: initial commit
- pack-bitmap: move some initialization to bitmap_writer_init()
- pack-bitmap: drop unused max_bitmaps parameter
- ewah: implement ewah_bitmap_is_subset()
- config: repo_config_get_expiry()
- Documentation/technical: describe pseudo-merge bitmaps format
The pack-bitmap machinery learned to write pseudo-merge bitmaps, which act as imaginary octopus merges covering un-bitmapped reference tips. This enhances bitmap coverage, and thus, performance, for repositories with many references using bitmaps.
Expecting a reroll.
cf. <[email protected]>
source: <[email protected]>
* la/hide-trailer-info (2024-04-26) 11 commits
- trailer unit tests: inspect iterator contents
- trailer: document parse_trailers() usage
- trailer: retire trailer_info_get() from API
- trailer: make trailer_info struct private
- trailer: make parse_trailers() return trailer_info pointer
- interpret-trailers: access trailer_info with new helpers
- sequencer: use the trailer iterator
- trailer: teach iterator about non-trailer lines
- trailer: add unit tests for trailer iterator
- Makefile: sort UNIT_TEST_PROGRAMS
+ Merge branch 'la/format-trailer-info' into la/hide-trailer-info
The trailer API has been reshuffled a bit.
Will merge to 'next'?
cf. <CAP8UFD0ZHpo7US6dx_WK6F_1JYsBdHunBaW86qM1CzOKaPC-aA@mail.gmail.com>
source: <[email protected]>
* ds/doc-config-reflow (2024-03-14) 1 commit
- config.txt: perform some minor reformatting
Reflow a paragraph in the documentation source without any effect to the formatted text.
Will discard.
source: <97bdaf075bf5a68554cca1731eca78aff2662907.1710444774.git.dsimic@manjaro.org>
* ie/config-includeif-hostname (2024-03-19) 2 commits
- config: learn the "hostname:" includeIf condition
- t: add a test helper for getting hostname
The conditional inclusion mechanism for configuration files learned to switch on the hostname.
Expecting a reroll.
cf. <[email protected]> cf. <[email protected]>
source: <[email protected]>
* js/build-fuzz-more-often (2024-04-24) 1 commit (merged to 'next' on 2024-04-25 at 28f65d1be2)
+ fuzz: link fuzz programs with make all on Linux
In addition to building the objects needed, try to link the objects that are used in fuzzer tests, to make sure at least they build without bitrot, in Linux CI runs.
Will cook in 'next'.
source: <ba9d24c6445de309226bf7c165499f1969807fef.1713982389.git.steadmon@google.com>
* cw/git-std-lib (2024-02-28) 4 commits
- SQUASH??? get rid of apparent debugging crufts
- test-stdlib: show that git-std-lib is independent
- git-std-lib: introduce Git Standard Library
- pager: include stdint.h because uintmax_t is used
Split libgit.a out to a separate git-std-lib tor easier reuse.
Expecting a reroll.
source: <[email protected]>
* js/cmake-with-test-tool (2024-04-24) 2 commits
- cmake: let test-tool run the unit tests, too
- Merge branch 'js/unit-test-suite-runner' into js/cmake-with-test-tool (this branch uses js/unit-test-suite-runner.)
"test-tool" is now built in CMake build to also run the unit tests.
May want to roll it into the base topic.
Will merge to 'next' together with the base topic.
source: <[email protected]>
* js/unit-test-suite-runner (2024-04-24) 8 commits
- ci: use test-tool as unit test runner on Windows
- t/Makefile: run unit tests alongside shell tests
- unit tests: add rule for running with test-tool
- test-tool run-command testsuite: support unit tests
- test-tool run-command testsuite: remove hardcoded filter
- test-tool run-command testsuite: get shell from env
- t0080: turn t-basic unit test into a helper
- Merge branch 'jk/unit-tests-buildfix' into js/unit-test-suite-runner (this branch is used by js/cmake-with-test-tool.)
The "test-tool" has been taught to run testsuite tests in parallel, bypassing the need to use the "prove" tool.
Needs review.
source: <[email protected]>
* bk/complete-dirname-for-am-and-format-patch (2024-01-12) 1 commit
- completion: dir-type optargs for am, format-patch
Command line completion support (in contrib/) has been updated for a few commands to complete directory names where a directory name is expected.
Expecting a reroll.
cf. <[email protected]>
cf. <[email protected]>
source: <[email protected]>
* bk/complete-send-email (2024-01-12) 1 commit
- completion: don't complete revs when --no-format-patch
Command line completion support (in contrib/) has been taught to avoid offering revision names as candidates to "git send-email" when the command is used to send pre-generated files.
Expecting a reroll.
cf. <CAC4O8c88Z3ZqxH2VVaNPpEGB3moL5dJcg3cOWuLWwQ_hLrJMtA@mail.gmail.com>
source: <[email protected]>
* tb/path-filter-fix (2024-01-31) 16 commits
- bloom: introduce deinit_bloom_filters()
- commit-graph: reuse existing Bloom filters where possible
- object.h: fix mis-aligned flag bits table
- commit-graph: new Bloom filter version that fixes murmur3
- commit-graph: unconditionally load Bloom filters
- bloom: prepare to discard incompatible Bloom filters
- bloom: annotate filters with hash version
- repo-settings: introduce commitgraph.changedPathsVersion
- t4216: test changed path filters with high bit paths
- t/helper/test-read-graph: implement bloom-filters mode
- bloom.h: make load_bloom_filter_from_graph() public
- t/helper/test-read-graph.c: extract dump_graph_info()
- gitformat-commit-graph: describe version 2 of BDAT
- commit-graph: ensure Bloom filters are read with consistent settings
- revision.c: consult Bloom filters for root commits
- t/t4216-log-bloom.sh: harden test_bloom_filters_not_used()
The Bloom filter used for path limited history traversal was broken on systems whose "char" is unsigned; update the implementation and bump the format version to 2.
Waiting for a final ack?
cf. <[email protected]>
source: <[email protected]>
* jc/rerere-cleanup (2023-08-25) 4 commits
- rerere: modernize use of empty strbuf
- rerere: try_merge() should use LL_MERGE_ERROR when it means an error
- rerere: fix comment on handle_file() helper
- rerere: simplify check_one_conflict() helper function
Code clean-up.
Not ready to be reviewed yet.
source: <[email protected]>
Quoted 11 lines · Junio C Hamano
* ds/send-email-per-message-block (2024-04-10) 2 commits
- send-email: make it easy to discern the messages for each patch
- send-email: move newline characters out of a few translatable
strings"git send-email" learned to separate its reports on each message it sends out with an extra blank line in between.
Will merge to 'next'?
source: <[email protected]>
Oh, nice, this is reassuring... I'd be so happy to see those patches accepted, which would avoid wasting all the effort that went into them, while also making "git send-email" a bit more user friendly. :)
Quoted 8 lines · Junio C Hamano
* ps/the-index-is-no-more (2024-04-18) 6 commits
- repository: dropinitialize_the_repository()
- repository: dropthe_indexvariable
- builtin/clone: stop usingthe_index
- repository: initialize index inrepo_init()
- builtin: stop usingthe_index
- t/helper: stop usingthe_index
Quoted 6 lines
The singleton
index_stateinstance "the_index" has been eliminated by always instantiating "the_repository" and replacing references to "the_index" with references to its .index member.Will merge to 'next'?
source: <[email protected]>
I'd be happy to see it gone as one more step towards less global state. It may be debatable whether the index should really be contained in struct repository, but even if we ultimately decide that it is not, dropping the_index would be a necessary step into that direction anyway.
So yeah, I'd be happy to see the_index gone. From thereon we can continue to iterate.
Quoted 13 lines
* ps/reftable-write-optim (2024-04-08) 11 commits
- reftable/block: reuse compressed array
- reftable/block: reuse zstream when writing log blocks
- reftable/writer: resetlast_keyinstead of releasing it
- reftable/writer: unify releasing memory
- reftable/writer: refactorings forwriter_flush_nonempty_block()
- reftable/writer: refactorings forwriter_add_record()
- refs/reftable: don't recompute committer ident
- reftable: remove name checks
- refs/reftable: skip duplicate name checks
- refs/reftable: perform explicit D/F check when writing symrefs
- refs/reftable: fix D/F conflict error message on ref copy
Quoted 5 lines
Code to write out reftable has seen some optimization and simplification.
Will merge to 'next'?
source: <[email protected]>
This series has seen reviews and I don't have any remaining things to address here, so I think it's ready to go.
Patrick
Quoted 13 lines · Junio C Hamano
* la/hide-trailer-info (2024-04-26) 11 commits
- trailer unit tests: inspect iterator contents
- trailer: documentparse_trailers()usage
- trailer: retiretrailer_info_get()from API
- trailer: maketrailer_infostruct private
- trailer: makeparse_trailers()returntrailer_infopointer
- interpret-trailers: accesstrailer_infowith new helpers
- sequencer: use the trailer iterator
- trailer: teach iterator about non-trailer lines
- trailer: add unit tests for trailer iterator
-Makefile: sortUNIT_TEST_PROGRAMS
+ Merge branch 'la/format-trailer-info' into la/hide-trailer-info
Quoted 5 lines
The trailer API has been reshuffled a bit.
Will merge to 'next'?
cf. <CAP8UFD0ZHpo7US6dx_WK6F_1JYsBdHunBaW86qM1CzOKaPC-aA@mail.gmail.com>
source: <[email protected]>
I should be able to send a reroll to address Christian's comments sometime later this week. Thanks