net: fs_enet: use platform_{get,set}_drvdata()
Subsystems (3)
PATCH 4/8 net: fs_enet: use platform_{get,set}_drvdata()
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device.
--- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +0 -1
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev) fep->ops->free_bd (ndev); fep->ops->cleanup_data (ndev); -dev_set_drvdata (fep->dev,NULL );of_node_put (fep->fpi->phy_node);free_netdev (ndev);return 0 ;
Signature · 1 line
1.7.1
Quoted 14 lines · Libo Chen
Use the wrapper functions for getting and setting the driver data using
platform_deviceinstead of using dev_{get,set}_drvdata() with&pdev->dev, so we can directly pass a structplatform_device.Signed-off-by Libo Chen <[email protected]>--- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +0
-0
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c static int fs_enet_remove(struct platform_device *ofdev) · line 1127
Quoted 7 lines
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +0
-1@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev) fep->ops->free_bd (ndev); fep->ops->cleanup_data (ndev); -dev_set_drvdata (fep->dev,NULL );of_node_put (fep->fpi->phy_node);free_netdev (ndev);return 0 ;
Changelog simply doesn't match the patch.
WBR, Sergei
PATCH RESEND 4/8 net: fs_enet: remove unnecessary dev_set_drvdata()
In reply to Libo Chenunnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure.
--- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +0 -1
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev) fep->ops->free_bd (ndev); fep->ops->cleanup_data (ndev); -dev_set_drvdata (fep->dev,NULL );of_node_put (fep->fpi->phy_node);free_netdev (ndev);return 0 ;
Signature · 1 line
1.7.1