Skip to contentSkip to conversation

mxc_spi: bugfix for double incrementing read pointer on unaligned buffers in spi_xchg_single

PATCH Superseded Timo Herbrecher 1 participant 1 message Aug 14, 2013

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mxc_spi: bugfix for double incrementing read pointer on unaligned buffers in spi_xchg_single

If dout buffer is not 32 bit-aligned or data to transmit is not multiple of 32 bit the read data pointer is already incremented on single byte reads.

---
 drivers/spi/mxc_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/mxc_spi.c +0 -0
index fd72a65..95dd03f 100644
@@ -255,8 +255,8 @@ int spi_xchg_single(struct spi_slave *slave,

unsigned int bitlen,

                        } else {
                                data = *(u32 *)dout;
                                data = cpu_to_be32(data);
+                               dout += 4;
                        }
-                       dout += 4;
                }
                debug("Sending SPI 0x%x\n", data);
                reg_write(&regs->txdata, data);
Signature · 1 line
1.7.0.4