Skip to contentSkip to conversation

Port-ids and NIC features

DISCUSSION Marc Sune 3 participants 5 messages Aug 14, 2013 – Aug 15, 2013 3 messages not in the archive

lore
Share & tools
lore

Marc Sune

author
#0 lore raw

Dear all,

Two quick questions:

1) Is there a way to get the features available in the NIC? In particular, I cannot see a way to retrieve the *maximum speed* of the card and I need to determine whether is a FE, GE or 10GE card.

2) For a certain number of NICs installed in the system and bound to the IGB_UIO driver, is it safe to assume that the association phyisical port <-> port_id will always be the same? Even after reboot, and regardless of the order that are bound to the IGB_UIO driver (e.g. using pci_unbind.py)?

Best
marc

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

For the question one, maybe you can detect it before binding to igb_uio

-----邮件原件-----
发件人: [email protected] [mailto:[email protected]] 代表 Marc Sune 发送时间: 2013年8月14日 16:57
收件人: [email protected]
主题: [dpdk-dev] Port-ids and NIC features

Dear all,

Two quick questions:

1) Is there a way to get the features available in the NIC? In particular, I cannot see a way to retrieve the *maximum speed* of the card and I need to determine whether is a FE, GE or 10GE card.

2) For a certain number of NICs installed in the system and bound to the IGB_UIO driver, is it safe to assume that the association phyisical port <-> port_id will always be the same? Even after reboot, and regardless of the order that are bound to the IGB_UIO driver (e.g. using pci_unbind.py)?

Best
marc

#3 lore raw
Quoted 9 lines · On Thu, 15 Aug 2013 09:51:00 +0800 安宏奎 <[email protected]>…

For the question one, maybe you can detect it before binding to igb_uio

-----邮件原件-----
发件人: [email protected] [mailto:[email protected]] 代表 Marc Sune 发送时间: 2013年8月14日 16:57
收件人: [email protected]
主题: [dpdk-dev] Port-ids and NIC features

Quoted 7 lines

Dear all,

Two quick questions:

1) Is there a way to get the features available in the NIC? In particular, I cannot see a way to retrieve the *maximum speed* of the card and I need to determine whether is a FE, GE or 10GE card.

Not at present. You need to look at the information in rte_pci_device for the ethernet (see rte_eth_dev_info) and then do your own matching against ID and features.

As DPDK evolves more of the hardware features need to be abstracted to allow applications to be build once and run on varying hardware. IMHO some of the low level features like read/write thresholds really shouldn't be exposed through the API. Setting them correctly depends too much on the underlying hardware, chip version, and driver and really shouldn't be something the application writer has to worry about.

Quoted 4 lines

2) For a certain number of NICs installed in the system and bound to the IGB_UIO driver, is it safe to assume that the association phyisical port <-> port_id will always be the same? Even after reboot, and regardless of the order that are bound to the IGB_UIO driver (e.g. using pci_unbind.py)?

Since probe is single threaded. The discovery order will be constant on the same system. But will change if hardware added/removed.

Another future area of work that needs to be addressed is hot plugging devices into a running application.

A message that is not in the archive (sent off-list or not yet received): 20130815075704.33261119-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org

author
#5 lore raw

Dear Stephen,

1) The problem is that, if the interfaces are binded to the IGB_UIO driver *before* the DPDK-based application is started, there is no way, as far as I've seen, to get such information. Of course, you cannot use anymore ethtool or whatever to get at least the speeds that the card is supporting. Btw, I don't need them, but offloads would probably be also quite useful. So in general all the "features" or "capabilities" supported by the NIC.

A general and elegant solution, IMHO would be to add to this in the info of the NIC, probably to struct rte_eth_dev_info; something like:

enum rte_eth_features {
ETH_LINK_100MB_HD = 1 << 0,
ETH_LINK_100MB_FD = 1 << 1,
ETH_LINK_1000MB_HD = 1 << 2,
ETH_LINK_1000MB_FD = 1 << 3,
ETH_LINK_10000MB_HD = 1 << 4,
ETH_LINK_10000MB_FD = 1 << 5,

//More features to be added here:
};

struct rte_eth_dev_info {
//...
uint32_t capabilities; //Bitmap of enum rte_eth_features (could be also an uint64_t)
};

I assume this informations are very easily gathered by the driver itself, since it knows the exact NIC model and capabilities.

2) Are the ids determined when the NICs are being binded to the DPDK driver, or when the IGB_UIO driver is insmoded? If it is the former, then the ids won't be consistent across reboots or binding order, which is not very desirable (IMHO), and actually is going to cause some problems in our application.

Best
marc

Quoted 40 lines · Stephen Hemminger
Quoted 9 lines · On Thu, 15 Aug 2013 09:51:00 +0800 安宏奎 <[email protected]>…

For the question one, maybe you can detect it before binding to igb_uio

-----邮件原件-----
发件人: [email protected] [mailto:[email protected]] 代表 Marc Sune 发送时间: 2013年8月14日 16:57
收件人: [email protected]
主题: [dpdk-dev] Port-ids and NIC features

Quoted 7 lines

Dear all,

Two quick questions:

1) Is there a way to get the features available in the NIC? In particular, I cannot see a way to retrieve the *maximum speed* of the card and I need to determine whether is a FE, GE or 10GE card.

Not at present. You need to look at the information in rte_pci_device for the ethernet (see rte_eth_dev_info) and then do your own matching against ID and features.

As DPDK evolves more of the hardware features need to be abstracted to allow applications to be build once and run on varying hardware. IMHO some of the low level features like read/write thresholds really shouldn't be exposed through the API. Setting them correctly depends too much on the underlying hardware, chip version, and driver and really shouldn't be something the application writer has to worry about.

Quoted 4 lines

2) For a certain number of NICs installed in the system and bound to the IGB_UIO driver, is it safe to assume that the association phyisical port <-> port_id will always be the same? Even after reboot, and regardless of the order that are bound to the IGB_UIO driver (e.g. using pci_unbind.py)?

Since probe is single threaded. The discovery order will be constant on the same system. But will change if hardware added/removed.

Another future area of work that needs to be addressed is hot plugging devices into a running application.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 9 lines · On Fri, 16 Aug 2013 00:15:04 +0200 Marc Sune…

Dear Stephen,

1) The problem is that, if the interfaces are binded to the IGB_UIO driver *before* the DPDK-based application is started, there is no way, as far as I've seen, to get such information. Of course, you cannot use anymore ethtool or whatever to get at least the speeds that the card is supporting. Btw, I don't need them, but offloads would probably be also quite useful. So in general all the "features" or "capabilities" supported by the NIC.

The hack for now is doing:

		struct rte_eth_dev_info dev_info;
		rte_eth_dev_info_get(portid, &dev_info);

		if (strncmp(dev_info.driver_name, "rte_ixgbe", 9) == 0)
			/* do stuff for 10G */
                else
                        /* do stuff for 1G */

Obviously, the driver_name approach could be generalized to a lookup table. But it really won't scale when many more drivers are added. Also since speed is negotiable, code should really wait till link is up to look at link speed and decide from that.

Since device is totally owned by user driver at this point, it
is perfectly possible to extend the existing drivers to do more PHY interaction to query/set speed and duplex. The current code just assumes autonegotiation. Since the Intel drivers are based off of BSD source there still is unused code to do this (I think).