isa: fix documentation of isa_register_portio_list

PATCH In review Hervé Poussineau 3 participants 7 messages Aug 13, 2013 – Aug 30, 2013

lore

Share & tools

lore

Hervé Poussineau

author

2013-08-13 10:37 UTC #0 lore raw

PATCH 1/1 isa: fix documentation of isa_register_portio_list

Signed-off-by Hervé Poussineau <[email protected]>

---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/hw/isa/isa.h +1 -1

index 495bcf3..fa45a5b 100644
@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,

Signature · 1 line

1.7.10.4

Hervé Poussineau

author

2013-08-18 20:06 UTC #1 lore raw

Ping.

Quoted 18 lines · Hervé Poussineau

Signed-off-by Hervé Poussineau <[email protected]>

---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/hw/isa/isa.h +1 -1

index 495bcf3..fa45a5b 100644
@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,

Paolo Bonzini

2013-08-30 15:45 UTC #2 lore raw

[Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

In reply to Hervé Poussineau

Il 13/08/2013 12:38, Hervé Poussineau ha scritto:

Quoted 12 lines

Signed-off-by Hervé Poussineau <[email protected]>
---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/hw/isa/isa.h +0 -0
index 495bcf3..fa45a5b 100644

include/hw/isa/isa.h void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); · line 84

Quoted 8 lines

include/hw/isa/isa.h +1 -1

@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,

Ping.

Paolo

Andreas Färber

2013-08-30 15:56 UTC #3 lore raw

Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

Am 30.08.2013 17:45, schrieb Paolo Bonzini:

Quoted 7 lines

Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
Quoted 6 lines
Signed-off-by Hervé Poussineau <[email protected]>
---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 16 lines

Quoted 6 lines

include/hw/isa/isa.h +0 -0
index 495bcf3..fa45a5b 100644

include/hw/isa/isa.h void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); · line 84

Quoted 8 lines

include/hw/isa/isa.h +1 -1

@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,

Ping.

If you actually give it a Reviewed-by I can take it through qom-next.

Commit message does not point to a commit X for trivial verification that it is in fact correct since X.

Andreas

Signature · 2 lines

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Paolo Bonzini

2013-08-30 16:03 UTC #4 lore raw

Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

Il 30/08/2013 17:56, Andreas Färber ha scritto:

Quoted 25 lines

Am 30.08.2013 17:45, schrieb Paolo Bonzini:
Quoted 7 lines
Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
Quoted 6 lines
Signed-off-by Hervé Poussineau <[email protected]>
---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 6 lines
include/hw/isa/isa.h +0 -0
index 495bcf3..fa45a5b 100644
include/hw/isa/isa.h void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); · line 84
Quoted 8 lines
include/hw/isa/isa.h +1 -1
@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,
Ping.

Quoted 4 lines

If you actually give it a Reviewed-by I can take it through qom-next.
Commit message does not point to a commit X for trivial verification that it is in fact correct since X.

Commit b40acf9 (ioport: Switch dispatching to memory core layer, 2013-06-24) removed all instances of old_portio except this, one in docs/memory.txt, and one in hw/ppc/spapr_pci.c.

Paolo

Andreas Färber

2013-08-30 17:25 UTC #5 lore raw

Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

Am 30.08.2013 18:02, schrieb Paolo Bonzini:

Quoted 26 lines

Il 30/08/2013 17:56, Andreas Färber ha scritto:
Quoted 25 lines
Am 30.08.2013 17:45, schrieb Paolo Bonzini:
Quoted 23 lines
Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
Quoted 12 lines
Signed-off-by Hervé Poussineau <[email protected]>
---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/hw/isa/isa.h +0 -0
index 495bcf3..fa45a5b 100644
include/hw/isa/isa.h void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); · line 84
Quoted 8 lines
include/hw/isa/isa.h +1 -1
@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,
Ping.

Quoted 7 lines

Quoted 4 lines
If you actually give it a Reviewed-by I can take it through qom-next.
Commit message does not point to a commit X for trivial verification that it is in fact correct since X.
Commit b40acf9 (ioport: Switch dispatching to memory core layer, 2013-06-24) removed all instances of old_portio

Thanks, I've copied it into the commit message and consider this an Acked-by. Applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next

Andreas

Quoted 5 lines

except this, one in
docs/memory.txt, and one in hw/ppc/spapr_pci.c.
Paolo

Signature · 2 lines

SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Hervé Poussineau

author

2013-08-30 17:06 UTC #6 lore raw

Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

In reply to Andreas Färber

Quoted 23 lines · Andreas Färber

Am 30.08.2013 17:45, schrieb Paolo Bonzini:
Quoted 6 lines
Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
Quoted 5 lines
Signed-off-by Hervé Poussineau <[email protected]>
---
 include/hw/isa/isa.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
include/hw/isa/isa.h +0 -0
index 495bcf3..fa45a5b 100644
include/hw/isa/isa.h void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); · line 84
Quoted 8 lines
include/hw/isa/isa.h +1 -1
@@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
  * @dev: the ISADevice against which these are registered; may be NULL.
  * @start: the base I/O port against which the portio->offset is applied.
  * @portio: the ports, sorted by offset.
- * @opaque: passed into the old_portio callbacks.
+ * @opaque: passed into the portio callbacks.
  * @name: passed into memory_region_init_io.
  */
 void isa_register_portio_list(ISADevice *dev, uint16_t start,
Ping.

Quoted 4 lines

If you actually give it a Reviewed-by I can take it through qom-next.
Commit message does not point to a commit X for trivial verification that it is in fact correct since X.

Just above the changed line, the ports variable is named "portio", not "old_portio".

Hervé