Skip to contentSkip to conversation

ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function

PATCH RESEND Superseded Alexander Shiyan 3 participants 4 messages Jul 2, 2013 – Aug 18, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Alexander Shiyan

author
#0 lore raw

PATCH RESEND 1/1 ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function

When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should enable FIFO but actually switch command is missing in the code. This patch adds this switching.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/plat-samsung/include/plat/uncompress.h +2 -0
index 4afc32f..f48dc0a 100644
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
 			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
 				break;
 		}
+
+		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
 	}
 }
 #else
Signature · 1 line
1.8.1.5
author
#1 lore raw

PATCH RESEND 1/1 ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function

Quoted 24 lines · On Tue, 2 Jul 2013 23:16:33 +0400 Alexander Shiyan <[email protected]> wrote:

When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should enable FIFO but actually switch command is missing in the code. This patch adds this switching.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/plat-samsung/include/plat/uncompress.h +2 -0
index 4afc32f..f48dc0a 100644
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
 			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
 				break;
 		}
+
+		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
 	}
 }
 #else
Signature · 1 line
1.8.1.5

Ping.

Signature · 1 line
Alexander Shiyan <[email protected]>
#2 lore raw

PATCH RESEND 1/1 ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function

In reply to Alexander Shiyan
Quoted 15 lines · On Tuesday 02 of July 2013 23:16:33 Alexander Shiyan wrote:

When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should enable FIFO but actually switch command is missing in the code. This patch adds this switching.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/arch/arm/plat-samsung/include/plat/uncompress.h index 4afc32f..f48dc0a 100644

arch/arm/plat-samsung/include/plat/uncompress.h static inline void arch_enable_uart_fifo(void) · line 152

Quoted 8 lines
arch/arm/plat-samsung/include/plat/uncompress.h +2 -0
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
 			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
 				break;
 		}
+
+		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
 	}
 }
 #else
Reviewed-by Tomasz Figa <[email protected]>

Best regards,
Tomasz

#3 lore raw

PATCH RESEND 1/1 ARM: plat-samsung: Fix switching FIFO in arch_enable_uart_fifo function

In reply to Alexander Shiyan
Quoted 14 lines · Alexander Shiyan

When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should enable FIFO but actually switch command is missing in the code. This patch adds this switching.

Signed-off-by Alexander Shiyan<[email protected]>
---
  arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/plat-samsung/include/plat/uncompress.h +0 -0
index 4afc32f..f48dc0a 100644

arch/arm/plat-samsung/include/plat/uncompress.h static inline void arch_enable_uart_fifo(void) · line 152

Quoted 8 lines
arch/arm/plat-samsung/include/plat/uncompress.h +2 -0
@@ -145,6 +145,8 @@ static inline void arch_enable_uart_fifo(void)
  			if (!(fifocon&  S3C2410_UFCON_RESETBOTH))
  				break;
  		}
+
+		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
  	}
  }
  #else

Sorry for late response, applied.

Thanks,
Kukjin