Skip to contentSkip to conversation

serial: arm_dcc: Convert to use default_serial_puts

PATCH New Axel Lin 4 participants 4 messages Aug 17, 2013 – Aug 19, 2013

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 serial: arm_dcc: Convert to use default_serial_puts

Use default_serial_puts() instead of its own implementation.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/serial/arm_dcc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/serial/arm_dcc.c +1 -7
index 29d9295..5dfb02f 100644
@@ -123,12 +123,6 @@ static void arm_dcc_putc(char ch)
 		write_dcc(ch);
 }
 
-static void arm_dcc_puts(const char *s)
-{
-	while (*s)
-		arm_dcc_putc(*s++);
-}
-
 static int arm_dcc_tstc(void)
 {
 	register unsigned int reg;

@@ -148,7 +142,7 @@ static struct serial_device arm_dcc_drv = {
 	.stop	= NULL,
 	.setbrg	= arm_dcc_setbrg,
 	.putc	= arm_dcc_putc,
-	.puts	= arm_dcc_puts,
+	.puts	= default_serial_puts,
 	.getc	= arm_dcc_getc,
 	.tstc	= arm_dcc_tstc,
 };
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 serial: arm_dcc: Convert to use default_serial_puts

Dear Axel Lin,

Quoted 3 lines

Use default_serial_puts() instead of its own implementation.

Signed-off-by Axel Lin <[email protected]>

Thanks,

Acked-by Marek Vasut <[email protected]>
Quoted 22 lines
---
 drivers/serial/arm_dcc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/serial/arm_dcc.c +0 -6
index 29d9295..5dfb02f 100644
@@ -123,12 +123,6 @@ static void arm_dcc_putc(char ch)
 		write_dcc(ch);
 }
 
-static void arm_dcc_puts(const char *s)
-{
-	while (*s)
-		arm_dcc_putc(*s++);
-}
-
 static int arm_dcc_tstc(void)
 {
 	register unsigned int reg;

drivers/serial/arm_dcc.c static struct serial_device arm_dcc_drv = { · line 148

Quoted 8 lines
drivers/serial/arm_dcc.c +1 -1
@@ -148,7 +142,7 @@ static struct serial_device arm_dcc_drv = {
 	.stop	= NULL,
 	.setbrg	= arm_dcc_setbrg,
 	.putc	= arm_dcc_putc,
-	.puts	= arm_dcc_puts,
+	.puts	= default_serial_puts,
 	.getc	= arm_dcc_getc,
 	.tstc	= arm_dcc_tstc,
 };

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 serial: arm_dcc: Convert to use default_serial_puts

Quoted 9 lines · Marek Vasut

Dear Axel Lin,

Quoted 3 lines

Use default_serial_puts() instead of its own implementation.

Signed-off-by Axel Lin <[email protected]>

Thanks,

Acked-by Marek Vasut <[email protected]>

Ah yeah.

Acked-by Michal Simek <[email protected]>

Tom: Can you please apply this patch directly to your tree?

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130819/27334863/attachment.pgp>
#3 lore raw

PATCH 1/1 serial: arm_dcc: Convert to use default_serial_puts

In reply to Axel Lin
Quoted 3 lines · Axel Lin

Use default_serial_puts() instead of its own implementation.

Signed-off-by Axel Lin <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130819/1c6135f9/attachment.pgp>