Skip to contentSkip to conversation

dma: imx-sdma: remove the unused completion

PATCH New Huang Shijie 3 participants 4 messages Jul 5, 2013 – Aug 19, 2013

Subsystems (2)
Arm i.MX and Layerscape dmaengine
lore
Share & tools
lore

Huang Shijie

author
#0 lore raw

PATCH 1/1 dma: imx-sdma: remove the unused completion

After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic", the "done" completion is not used any more.

Just remove it.

Signed-off-by Huang Shijie <[email protected]>
---
 drivers/dma/imx-sdma.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
drivers/dma/imx-sdma.c +0 -7
index 1e44b8c..2c02a9d 100644
@@ -243,7 +243,6 @@ struct sdma_engine;
  * @event_id1		for channels that use 2 events
  * @word_size		peripheral access size
  * @buf_tail		ID of the buffer that was processed
- * @done		channel completion
  * @num_bd		max NUM_BD. number of descriptors currently handling
  */
 struct sdma_channel {

@@ -255,7 +254,6 @@ struct sdma_channel {
 	unsigned int			event_id1;
 	enum dma_slave_buswidth		word_size;
 	unsigned int			buf_tail;
-	struct completion		done;
 	unsigned int			num_bd;
 	struct sdma_buffer_descriptor	*bd;
 	dma_addr_t			bd_phys;

@@ -547,8 +545,6 @@ static void sdma_tasklet(unsigned long data)
 {
 	struct sdma_channel *sdmac = (struct sdma_channel *) data;
 
-	complete(&sdmac->done);
-
 	if (sdmac->flags & IMX_DMA_SG_LOOP)
 		sdma_handle_channel_loop(sdmac);
 	else

@@ -812,9 +808,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
 	sdma->channel_control[channel].current_bd_ptr = sdmac->bd_phys;
 
 	sdma_set_channel_priority(sdmac, MXC_SDMA_DEFAULT_PRIORITY);
-
-	init_completion(&sdmac->done);
-
 	return 0;
 out:
Signature · 1 line
1.7.1
author
#2 lore raw

PATCH 1/1 dma: imx-sdma: remove the unused completion

In reply to Huang Shijie

? 2013?07?05? 15:50, Huang Shijie ??:

Quoted 40 lines

After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic", the "done" completion is not used any more.

Just remove it.

Signed-off-by Huang Shijie <[email protected]>
---
 drivers/dma/imx-sdma.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
drivers/dma/imx-sdma.c +0 -4
index 1e44b8c..2c02a9d 100644
@@ -243,7 +243,6 @@ struct sdma_engine;
  * @event_id1		for channels that use 2 events
  * @word_size		peripheral access size
  * @buf_tail		ID of the buffer that was processed
- * @done		channel completion
  * @num_bd		max NUM_BD. number of descriptors currently handling
  */
 struct sdma_channel {

@@ -255,7 +254,6 @@ struct sdma_channel {
 	unsigned int			event_id1;
 	enum dma_slave_buswidth		word_size;
 	unsigned int			buf_tail;
-	struct completion		done;
 	unsigned int			num_bd;
 	struct sdma_buffer_descriptor	*bd;
 	dma_addr_t			bd_phys;

@@ -547,8 +545,6 @@ static void sdma_tasklet(unsigned long data)
 {
 	struct sdma_channel *sdmac = (struct sdma_channel *) data;
 
-	complete(&sdmac->done);
-
 	if (sdmac->flags & IMX_DMA_SG_LOOP)
 		sdma_handle_channel_loop(sdmac);
 	else

drivers/dma/imx-sdma.c static int sdma_request_channel(struct sdma_channel *sdmac) · line 813

Quoted 9 lines
drivers/dma/imx-sdma.c +0 -3
@@ -812,9 +808,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
 	sdma->channel_control[channel].current_bd_ptr = sdmac->bd_phys;
 
 	sdma_set_channel_priority(sdmac, MXC_SDMA_DEFAULT_PRIORITY);
-
-	init_completion(&sdmac->done);
-
 	return 0;
 out:

Hi Vinod:
Could you merge this patch?

thanks
Huang Shijie