Skip to contentSkip to conversation

extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

PATCH In review Kishon Vijay Abraham I 4 participants 10 messages Aug 16, 2013 – Aug 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 extcon: palmas: Modified the compatible type to *ti,palmas-usb-vid*

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

---
Changes from v1:
* removed the existing compatible types and changed it to *ti,palmas-usb-vid*

 Documentation/devicetree/bindings/extcon/extcon-palmas.txt |    4 ++--
 drivers/extcon/extcon-palmas.c                             |    3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-palmas.txt +2 -2
index 7dab6a8..00859f6 100644
@@ -2,7 +2,7 @@ EXTCON FOR PALMAS/TWL CHIPS
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".
 
 Optional Properties:
  - ti,wakeup : To enable the wakeup comparator in probe
@@ -10,6 +10,6 @@ Optional Properties:
  - ti,enable-vbus-detection: Perform VBUS detection.
 
 palmas-usb {
-       compatible = "ti,twl6035-usb", "ti,palmas-usb";
+       compatible = "ti,palmas-usb-vid";
        ti,wakeup;
 };
drivers/extcon/extcon-palmas.c +1 -2
index 89fdd05..f3ed2d7 100644
@@ -267,8 +267,7 @@ static const struct dev_pm_ops palmas_pm_ops = {
 };
 
 static struct of_device_id of_palmas_match_tbl[] = {
-	{ .compatible = "ti,palmas-usb", },
-	{ .compatible = "ti,twl6035-usb", },
+	{ .compatible = "ti,palmas-usb-vid", },
 	{ /* end */ }
 };
 
Signature · 1 line
1.7.10.4
#1 lore raw

Documentation/devicetree/bindings/extcon/extcon-palmas.txt EXTCON FOR PALMAS/TWL CHIPS · line 5

Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".

Has the old value been published in a release kernel? If so, it makes sense to document both values, but say the old one is deprecated, and ...

drivers/extcon/extcon-palmas.c static const struct dev_pm_ops palmas_pm_ops = { · line 270

Quoted 6 lines
drivers/extcon/extcon-palmas.c +1 -2
 
 static struct of_device_id of_palmas_match_tbl[] = {
-	{ .compatible = "ti,palmas-usb", },
-	{ .compatible = "ti,twl6035-usb", },
+	{ .compatible = "ti,palmas-usb-vid", },

... perhaps just add the new value here, and don't remove the old values?

If not, ignore this.

#2 lore raw

Hi,

Quoted 4 lines · Stephen Warren
Quoted 2 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Quoted 8 lines

Documentation/devicetree/bindings/extcon/extcon-palmas.txt EXTCON FOR PALMAS/TWL CHIPS · line 5

Quoted 6 lines
Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".

Has the old value been published in a release kernel? If so, it makes

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

Thanks
Kishon

maintainer
#3 lore raw
Quoted 14 lines · Kishon Vijay Abraham I

Hi,

Quoted 11 lines · Stephen Warren
Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".
Quoted 5 lines
Quoted 1 line

Has the old value been published in a release kernel? If so, it makes

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

This patch will be included in 3.12-rc* after 3.12-rc1. and this patch is applied on extcon-linus branch.

Thanks,
Chanwoo Choi

#4 lore raw
In reply to Kishon Vijay Abraham I
Quoted 14 lines · Kishon Vijay Abraham I

Hi,

Quoted 11 lines · Stephen Warren
Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".
Quoted 4 lines
Quoted 1 line

Has the old value been published in a release kernel? If so, it makes

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

Ah.. the old values will be part of 3.11 kernel. So should we retain the old values?

-Kishon

maintainer
#5 lore raw
Quoted 15 lines · Kishon Vijay Abraham I
Quoted 14 lines · Kishon Vijay Abraham I

Hi,

Quoted 11 lines · Stephen Warren
Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Has the old value been published in a release kernel? If so, it makes

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

Ah.. the old values will be part of 3.11 kernel. So should we retain the old values?

What is the meaning of old value? previous value related to extcon-twl.txt?

The extcon-twl.txt was included in 3.11 kernel
and extcon-palmas.txt will be inclued in 3.12 kernel through char-misc repo of GregKH.

Thanks,
Chanwoo Choi

#6 lore raw
Quoted 18 lines · Chanwoo Choi
Quoted 17 lines · Kishon Vijay Abraham I
Quoted 16 lines · Kishon Vijay Abraham I

Hi,

Quoted 12 lines · Stephen Warren

Documentation/devicetree/bindings/extcon/extcon-palmas.txt EXTCON FOR PALMAS/TWL CHIPS · line 5

Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".

Has the old value been published in a release kernel? If so, it makes

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

Ah.. the old values will be part of 3.11 kernel. So should we retain the old values?

What is the meaning of old value? previous value related to extcon-twl.txt?

We were discussing on whether to have "ti,palmas-usb" or "ti,twl6035-usb" in compatible value in addition to "ti,palmas-usb-vid". Stephen wanted the old values ("ti,palmas-usb" or "ti,twl6035-usb") if it has been published in a release kernel.

Quoted 2 lines

The extcon-twl.txt was included in 3.11 kernel

Right. Since it's part of 3.11 kernel, I think we should retain the old compatible values.

Thanks
Kishon

#7 lore raw

Hi Kishon,

Quoted 11 lines · Kishon Vijay Abraham I
Quoted 10 lines · Chanwoo Choi
Quoted 9 lines · Kishon Vijay Abraham I
Quoted 8 lines · Kishon Vijay Abraham I

Hi,

Quoted 5 lines · Stephen Warren

Documentation/devicetree/bindings/extcon/extcon-palmas.txt

Quoted 4 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +0 -0

That file is not yet in 3.11. Only the twl is there. Is this one a rename of the twl one?

Regards,
Benoit

Quoted 29 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines

PALMAS USB COMPARATOR
Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".

Has the old value been published in a release kernel? If so, it makes

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

Ah.. the old values will be part of 3.11 kernel. So should we retain the old values?

What is the meaning of old value? previous value related to extcon-twl.txt?

We were discussing on whether to have "ti,palmas-usb" or "ti,twl6035-usb" in compatible value in addition to "ti,palmas-usb-vid". Stephen wanted the old values ("ti,palmas-usb" or "ti,twl6035-usb") if it has been published in a release kernel.

Quoted 2 lines

The extcon-twl.txt was included in 3.11 kernel

Right. Since it's part of 3.11 kernel, I think we should retain the old compatible values.

Thanks
Kishon

#8 lore raw
Quoted 10 lines · Benoit Cousson

Hi Kishon,

Quoted 7 lines · Kishon Vijay Abraham I
Quoted 6 lines · Chanwoo Choi
Quoted 5 lines · Kishon Vijay Abraham I
Quoted 4 lines · Kishon Vijay Abraham I

Hi,

Quoted 1 line · Stephen Warren

On 08/16/2013 04:20 AM, Kishon Vijay Abraham I wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Documentation/devicetree/bindings/extcon/extcon-palmas.txt

Quoted 5 lines

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +0 -0

That file is not yet in 3.11. Only the twl is there. Is this one a rename of the twl one?

yes Benoit. This is the commit
http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=80d644b297dc26c5126858555044edef76f4ffe8

Thanks
Kishon

#9 lore raw
In reply to Kishon Vijay Abraham I
Quoted 14 lines · Kishon Vijay Abraham I

Hi,

Quoted 11 lines · Stephen Warren
Quoted 9 lines · Kishon Vijay Abraham I

The Palmas device contains only a USB VID detector, so modified the compatible type to *ti,palmas-usb-vid*.

Documentation/devicetree/bindings/extcon/extcon-palmas.txt +1 -1
 
 PALMAS USB COMPARATOR
 Required Properties:
- - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb"
+ - compatible : Should be "ti,palmas-usb-vid".
Quoted 4 lines
Quoted 1 line

Has the old value been published in a release kernel? If so, it makes

No. This was merged only in 3.11-rc1. So I think we should take this version? Chanwoo can you take this patch?

So anything in 3.11-rc1 will make it into 3.11 final, and hence has already been published, and hence should be an ABI. This current patch is only going into 3.12, so really should be amended not to break the ABI.