Skip to contentSkip to conversation

USB: Add EHCI support for MX27 and MX31 based boards

DISCUSSION Dan Carpenter 2 participants 2 messages Aug 21, 2013 Kernel janitors

lore
Share & tools
lore
#0 lore raw

[ This warning is very old actually ]

Hello Daniel Mack,

This is a semi-automatic email about new static checker warnings.

The patch 7e8d5cd93fac: "USB: Add EHCI support for MX27 and MX31 based boards" from Oct 28, 2009, leads to the following Smatch complaint:

drivers/usb/host/ehci-mxc.c:187 ehci_mxc_drv_remove()
error: we previously assumed 'pdata' could be null (see line 184)

drivers/usb/host/ehci-mxc.c
183
184 if (pdata && pdata->exit)

                    ^^^^^

New check.

185 pdata->exit(pdev);
186
187 if (pdata->otg)

                    ^^^^^^^^^^

New dereference.

   188			usb_phy_shutdown(pdata->otg);
   189	

regards,
dan carpenter

#1 lore raw
Quoted 9 lines · Dan Carpenter

[ This warning is very old actually ]

Hello Daniel Mack,

This is a semi-automatic email about new static checker warnings.

The patch 7e8d5cd93fac: "USB: Add EHCI support for MX27 and MX31 based boards" from Oct 28, 2009, leads to the following Smatch complaint:

Indeed, that's quite old. I just sent out a patch to fix this.

Thanks for spotting!

Daniel