Skip to contentSkip to conversation

fec_mxc: set ethaddr if fuses burned and not previously set

PATCH New Eric Nelson 2 participants 4 messages Aug 2, 2013 – Aug 21, 2013 Network drivers

lore
Share & tools
lore

Eric Nelson

author
#0 lore raw

PATCH 1/1 fec_mxc: set ethaddr if fuses burned and not previously set

Without this change, the following message is generated:
Warning: FEC using MAC address from net device

See doc/README.enetaddr for details.

Signed-off-by Eric Nelson <[email protected]>
---
 drivers/net/fec_mxc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/fec_mxc.c +2 -0
index e14a359..886be9c 100644
@@ -980,6 +980,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
 	if (fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
 		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
 		memcpy(edev->enetaddr, ethaddr, 6);
+		if (!getenv("ethaddr"))
+			eth_setenv_enetaddr("ethaddr",mac);
 	}
 	return ret;
 err3:
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 fec_mxc: set ethaddr if fuses burned and not previously set

Hi Eric,

Quoted 7 lines · Eric Nelson

Without this change, the following message is generated:
Warning: FEC using MAC address from net device

See doc/README.enetaddr for details.

Signed-off-by Eric Nelson <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 fec_mxc: set ethaddr if fuses burned and not previously set

In reply to Eric Nelson

Hi Eric,

Quoted 15 lines · Eric Nelson

Without this change, the following message is generated:
Warning: FEC using MAC address from net device

See doc/README.enetaddr for details.

Signed-off-by Eric Nelson <[email protected]>
---
 drivers/net/fec_mxc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/fec_mxc.c +0 -0
index e14a359..886be9c 100644

drivers/net/fec_mxc.c static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr, · line 984

Quoted 5 lines
drivers/net/fec_mxc.c +2 -0
@@ -980,6 +980,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
 	if (fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
 		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
 		memcpy(edev->enetaddr, ethaddr, 6);
+		if (!getenv("ethaddr"))
+			eth_setenv_enetaddr("ethaddr",mac);

                                                       ^--

of course, this should be ethaddr and not mac. I fixed it myself.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#3 lore raw

PATCH 1/1 fec_mxc: set ethaddr if fuses burned and not previously set

Quoted 24 lines · Stefano Babic

Hi Eric,

Quoted 15 lines · Eric Nelson

Without this change, the following message is generated:
Warning: FEC using MAC address from net device

See doc/README.enetaddr for details.

Signed-off-by Eric Nelson <[email protected]>
---
  drivers/net/fec_mxc.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/net/fec_mxc.c +0 -0
index e14a359..886be9c 100644

drivers/net/fec_mxc.c static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr, · line 984

Quoted 5 lines
drivers/net/fec_mxc.c +2 -0
@@ -980,6 +980,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
  	if (fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
  		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
  		memcpy(edev->enetaddr, ethaddr, 6);
+		if (!getenv("ethaddr"))
+			eth_setenv_enetaddr("ethaddr",mac);

                                                        ^--
Quoted 2 lines

of course, this should be ethaddr and not mac. I fixed it myself.

Thanks Stefano.