xfs_repair: add prototype for alloc_ex_data()

PATCH In review Eric Sandeen 5 participants 6 messages Aug 20, 2013 – Aug 21, 2013

lore

Share & tools

lore

Eric Sandeen

author

2013-08-20 23:14 UTC #0 lore raw

PATCH 1/1 xfs_repair: add prototype for alloc_ex_data()

3ac87fbf xfsprogs: fix inode crash in xfs_repair

un-static'd alloc_ex_data and used it in phase6.c, but didn't put a prototype in a header, so:

phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’

Fix it...

Signed-off-by Eric Sandeen <[email protected]>

---

repair/incore.h +5 -0

index 8a578b5..38caa6d 100644
@@ -483,6 +483,11 @@ void		set_inode_parent(ino_tree_node_t *irec, int ino_offset,
 xfs_ino_t	get_inode_parent(ino_tree_node_t *irec, int ino_offset);
 
 /*
+ * Allocate extra inode data
+ */
+void		alloc_ex_data(ino_tree_node_t *irec);
+
+/*
  * bmap cursor for tracking and fixing bmap btrees.  All xfs btrees number
  * the levels with 0 being the leaf and every level up being 1 greater.
  */

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Dave Chinner

Reviewed-by on v1 1/1

2013-08-21 00:07 UTC #1 lore raw

Quoted 19 lines · Eric Sandeen

3ac87fbf xfsprogs: fix inode crash in xfs_repair
un-static'd alloc_ex_data and used it in phase6.c, but didn't put a prototype in a header, so:
phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
Fix it...
Signed-off-by Eric Sandeen <[email protected]>
---
repair/incore.h +0 -0
index 8a578b5..38caa6d 100644
@@ -483,6 +483,11 @@ void		set_inode_parent(ino_tree_node_t *irec, int ino_offset,
 xfs_ino_t	get_inode_parent(ino_tree_node_t *irec, int ino_offset);

repair/incore.h void set_inode_parent(ino_tree_node_t *irec, int ino_offset, · line 493

Quoted 10 lines

repair/incore.h +5 -0

 
 /*
+ * Allocate extra inode data
+ */
+void		alloc_ex_data(ino_tree_node_t *irec);
+
+/*
  * bmap cursor for tracking and fixing bmap btrees.  All xfs btrees number
  * the levels with 0 being the leaf and every level up being 1 greater.
  */

Looks good.

Reviewed-by Dave Chinner <[email protected]>

Signature · 7 lines

Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Mark Tinguely

2013-08-21 14:28 UTC #2 lore raw

In reply to Eric Sandeen

Quoted 5 lines · Eric Sandeen

3ac87fbf xfsprogs: fix inode crash in xfs_repair
un-static'd alloc_ex_data and used it in phase6.c, but didn't put a prototype in a header, so:

Quoted 7 lines

phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
Fix it...
Signed-off-by Eric Sandeen<[email protected]>
---

Thanks and sorry. I knew it and hoped to get it in before it got committed.

--Mark.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Eric Sandeen

2013-08-21 15:28 UTC #3 lore raw

Quoted 9 lines · Mark Tinguely

Quoted 8 lines · Eric Sandeen
3ac87fbf xfsprogs: fix inode crash in xfs_repair
un-static'd alloc_ex_data and used it in phase6.c, but didn't put a prototype in a header, so:
phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’

Quoted 7 lines

Quoted 4 lines
Fix it...
Signed-off-by Eric Sandeen<[email protected]>
---
Thanks and sorry. I knew it and hoped to get it in before it got committed.

Eh, it happens.

Minor demerit for Rich for not catching it before commit, either ;)

-Eric (who has never, NEVER made a mistake like that)

Quoted 8 lines

--Mark.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Rich Johnston

2013-08-21 17:13 UTC #4 lore raw

Quoted 16 lines · Eric Sandeen

Quoted 15 lines · Mark Tinguely
Quoted 12 lines · Eric Sandeen
3ac87fbf xfsprogs: fix inode crash in xfs_repair
un-static'd alloc_ex_data and used it in phase6.c, but didn't put a prototype in a header, so:
phase6.c: In function ‘mk_orphanage’:
phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
Fix it...
Signed-off-by Eric Sandeen<[email protected]>
---

Quoted 5 lines

Quoted 1 line
Thanks and sorry. I knew it and hoped to get it in before it got committed.
Eh, it happens.
Minor demerit for Rich for not catching it before commit, either ;)

***rjohnston: hides head in shame and vows to improve

Quoted 12 lines

-Eric (who has never, NEVER made a mistake like that)
Quoted 8 lines
--Mark.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Rich Johnston

2013-08-21 17:01 UTC #5 lore raw

In reply to Eric Sandeen

Thanks for the patch Eric. it has been committed.

--Rich

commit 2e1622703bb5c01e5f6d5fa087999c768868aa0b

Author: Eric Sandeen <[email protected]>
Date:   Tue Aug 20 23:14:17 2013 +0000

xfs_repair: add prototype for alloc_ex_data()

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs