Skip to contentSkip to conversation

ARM: dts: exynos5420: add ADC device tree node

PATCH In review Naveen Krishna Chatradhi 5 participants 7 messages Aug 1, 2013 – Aug 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: exynos5420: add ADC device tree node

From: Jaehoon Kim <[email protected]>

Add device tree node for ADC in exynos5420.dtsi

---
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/exynos5420.dtsi +11 -0
index 8c54c4b..074e1bc 100644
@@ -145,4 +145,15 @@
 		clocks = <&clock 260>, <&clock 131>;
 		clock-names = "uart", "clk_uart_baud0";
 	};
+
+	adc: adc@12D10000 {
+		compatible = "samsung,exynos-adc-v2";
+		reg = <0x12D10000 0x100>, <0x10040720 0x4>;
+		interrupts = <0 106 0>;
+		#io-channel-cells = <1>;
+		io-channel-ranges;
+		clocks = <&clock 270>;
+		clock-names = "adc";
+		status = "disabled";
+	};
 };
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Naveen,
exynos5250.dtsi also needs this entry.
Pls consider adding adc node in exynos5250.dtsi as well, and move the common content of adc node to exynos5.dtsi.

Regards
Sunil

Quoted 37 lines · Naveen Krishna Chatradhi

From: Jaehoon Kim <[email protected]>

Add device tree node for ADC in exynos5420.dtsi

---
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/exynos5420.dtsi +11 -1
index 8c54c4b..074e1bc 100644
@@ -145,4 +145,15 @@
                clocks = <&clock 260>, <&clock 131>;
                clock-names = "uart", "clk_uart_baud0";
        };
+
+       adc: adc@12D10000 {
+               compatible = "samsung,exynos-adc-v2";
+               reg = <0x12D10000 0x100>, <0x10040720 0x4>;
+               interrupts = <0 106 0>;
+               #io-channel-cells = <1>;
+               io-channel-ranges;
+               clocks = <&clock 270>;
+               clock-names = "adc";
+               status = "disabled";
+       };
 };
--

1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 4 lines · sunil joshi

Hi Naveen,
exynos5250.dtsi also needs this entry.
Pls consider adding adc node in exynos5250.dtsi as well, and move the common content of adc node to exynos5.dtsi.

Sure, sunil will run a boot test and submit the code

Quoted 49 lines

Regards
Sunil

Quoted 33 lines · Naveen Krishna Chatradhi

From: Jaehoon Kim <[email protected]>

Add device tree node for ADC in exynos5420.dtsi

---
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/exynos5420.dtsi +11 -1
index 8c54c4b..074e1bc 100644
@@ -145,4 +145,15 @@
                clocks = <&clock 260>, <&clock 131>;
                clock-names = "uart", "clk_uart_baud0";
        };
+
+       adc: adc@12D10000 {
+               compatible = "samsung,exynos-adc-v2";
+               reg = <0x12D10000 0x100>, <0x10040720 0x4>;
+               interrupts = <0 106 0>;
+               #io-channel-cells = <1>;
+               io-channel-ranges;
+               clocks = <&clock 270>;
+               clock-names = "adc";
+               status = "disabled";
+       };
 };
--

1.7.9.5

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Shine bright,
(: Nav :)
#3 lore raw

PATCH 1/1 ARM: dts: exynos5420/5250: add ADC device tree node

In reply to Naveen Krishna Chatradhi

Add ADC device tree node for exynos5420 and exynos5250

---
 arch/arm/boot/dts/exynos5250.dtsi |   11 +++++++++++
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 2 files changed, 22 insertions(+)
arch/arm/boot/dts/exynos5250.dtsi +11 -0
index 1eec646..518f8cd 100644
@@ -641,4 +641,15 @@
 		clocks = <&clock 133>, <&clock 339>;
 		clock-names = "sclk_fimd", "fimd";
 	};
+
+	adc: adc at 12D10000 {
+		compatible = "samsung,exynos-adc-v1";
+		reg = <0x12D10000 0x100>, <0x10040718 0x4>;
+		interrupts = <0 106 0>;
+		clocks = <&clock 303>;
+		clock-names = "adc";
+		#io-channel-cells = <1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
 };
arch/arm/boot/dts/exynos5420.dtsi +11 -0
index 5353e32..0c5c055 100644
@@ -218,4 +218,15 @@
 		clocks = <&clock 147>, <&clock 421>;
 		clock-names = "sclk_fimd", "fimd";
 	};
+
+	adc: adc at 12D10000 {
+		compatible = "samsung,exynos-adc-v2";
+		reg = <0x12D10000 0x100>, <0x10040720 0x4>;
+		interrupts = <0 106 0>;
+		clocks = <&clock 270>;
+		clock-names = "adc";
+		#io-channel-cells = <1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
 };
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 1/1 ARM: dts: exynos5420/5250: add ADC device tree node

Hi Naveen,

Quoted 8 lines · On Thursday 22 of August 2013 15:48:11 Naveen Krishna Chatradhi wrote:

Add ADC device tree node for exynos5420 and exynos5250

---
 arch/arm/boot/dts/exynos5250.dtsi |   11 +++++++++++
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 2 files changed, 22 insertions(+)

This patch looks good to me, but please resend it with all the recipients present in MAINTAINERS file for the directories from which files it changes, especially the devicetree at vger.kernel.org mailing list.

Best regards,
Tomasz

#5 lore raw

PATCH v2 1/1 ARM: dts: exynos5420/5250: add ADC device tree node

In reply to Naveen Krishna Chatradhi

Add ADC device tree node for exynos5420 and exynos5250

---

Added recipients accordingly, ./scripts/get_maintainer.pl -f of the modified files

 arch/arm/boot/dts/exynos5250.dtsi |   11 +++++++++++
 arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
 2 files changed, 22 insertions(+)
arch/arm/boot/dts/exynos5250.dtsi +11 -0
index 1eec646..518f8cd 100644
@@ -641,4 +641,15 @@
 		clocks = <&clock 133>, <&clock 339>;
 		clock-names = "sclk_fimd", "fimd";
 	};
+
+	adc: adc at 12D10000 {
+		compatible = "samsung,exynos-adc-v1";
+		reg = <0x12D10000 0x100>, <0x10040718 0x4>;
+		interrupts = <0 106 0>;
+		clocks = <&clock 303>;
+		clock-names = "adc";
+		#io-channel-cells = <1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
 };
arch/arm/boot/dts/exynos5420.dtsi +11 -0
index 5353e32..0c5c055 100644
@@ -218,4 +218,15 @@
 		clocks = <&clock 147>, <&clock 421>;
 		clock-names = "sclk_fimd", "fimd";
 	};
+
+	adc: adc at 12D10000 {
+		compatible = "samsung,exynos-adc-v2";
+		reg = <0x12D10000 0x100>, <0x10040720 0x4>;
+		interrupts = <0 106 0>;
+		clocks = <&clock 270>;
+		clock-names = "adc";
+		#io-channel-cells = <1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
 };
Signature · 1 line
1.7.9.5
#6 lore raw

Re: [PATCH v2] ARM: dts: exynos5420/5250: add ADC device tree node

Quoted 43 lines · Naveen Krishna Chatradhi

Add ADC device tree node for exynos5420 and exynos5250

---

Added recipients accordingly, ./scripts/get_maintainer.pl -f of the modified files

  arch/arm/boot/dts/exynos5250.dtsi |   11 +++++++++++
  arch/arm/boot/dts/exynos5420.dtsi |   11 +++++++++++
  2 files changed, 22 insertions(+)
arch/arm/boot/dts/exynos5250.dtsi +11 -0
index 1eec646..518f8cd 100644
@@ -641,4 +641,15 @@
  		clocks =<&clock 133>,<&clock 339>;
  		clock-names = "sclk_fimd", "fimd";
  	};
+
+	adc: adc at 12D10000 {
+		compatible = "samsung,exynos-adc-v1";
+		reg =<0x12D10000 0x100>,<0x10040718 0x4>;
+		interrupts =<0 106 0>;
+		clocks =<&clock 303>;
+		clock-names = "adc";
+		#io-channel-cells =<1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
  };
arch/arm/boot/dts/exynos5420.dtsi +2 -0
index 5353e32..0c5c055 100644
@@ -218,4 +218,15 @@
  		clocks =<&clock 147>,<&clock 421>;
  		clock-names = "sclk_fimd", "fimd";
  	};
+
+	adc: adc at 12D10000 {

arch/arm/boot/dts/exynos5420.dtsi line 232

Quoted 10 lines
arch/arm/boot/dts/exynos5420.dtsi +9 -0
+		compatible = "samsung,exynos-adc-v2";
+		reg =<0x12D10000 0x100>,<0x10040720 0x4>;
+		interrupts =<0 106 0>;
+		clocks =<&clock 270>;
+		clock-names = "adc";
+		#io-channel-cells =<1>;
+		io-channel-ranges;
+		status = "disabled";
+	};
  };

Looks good to me, applied.

Thanks,
Kukjin