h8300: include: asm: Kbuild: add gpio.h for pass compiling

Need add default "gpio.h" for h8300, or can not pass compiling.

The related error (allmodconfig for h8300):

arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory

   #include <asm/gpio.h>
                        ^

Signed-off-by Chen Gang <[email protected]>

---
 arch/h8300/include/asm/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/h8300/include/asm/Kbuild +0 -0

index 8ada3cf..4c627aa 100644

Quoted 7 lines · Chen Gang

Need add default "gpio.h" for h8300, or can not pass compiling.

The related error (allmodconfig for h8300):

arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory

   #include <asm/gpio.h>
                        ^

I this include needed at all? Perhaps it can just be removed?

Quoted 10 lines

Signed-off-by Chen Gang <[email protected]>

---
 arch/h8300/include/asm/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/h8300/include/asm/Kbuild +0 -0

index 8ada3cf..4c627aa 100644

arch/h8300/include/asm/Kbuild line 7

Quoted 7 lines

arch/h8300/include/asm/Kbuild +1 -0

@@ -1,6 +1,7 @@
 
 generic-y += clkdev.h
 generic-y += exec.h
+generic-y += gpio.h
 generic-y += linkage.h
 generic-y += mmu.h
 generic-y += module.h

The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are:

EXPORT_SYMBOL(h8300_reserved_gpio);
EXPORT_SYMBOL(h8300_free_gpio);
EXPORT_SYMBOL(h8300_set_gpio_dir);

and these are definitely not provided by asm-generic/gpio.h.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Quoted 11 lines · Geert Uytterhoeven

Quoted 7 lines · Chen Gang

Need add default "gpio.h" for h8300, or can not pass compiling.

The related error (allmodconfig for h8300):

arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory

   #include <asm/gpio.h>
                        ^

I this include needed at all? Perhaps it can just be removed?

Pardon ? Do you mean, only removing it will be OK ?

Quoted 20 lines

Quoted 10 lines

Signed-off-by Chen Gang <[email protected]>

---
 arch/h8300/include/asm/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/h8300/include/asm/Kbuild +0 -0

index 8ada3cf..4c627aa 100644

arch/h8300/include/asm/Kbuild line 7

Quoted 7 lines

arch/h8300/include/asm/Kbuild +1 -0

@@ -1,6 +1,7 @@
 
 generic-y += clkdev.h
 generic-y += exec.h
+generic-y += gpio.h
 generic-y += linkage.h
 generic-y += mmu.h
 generic-y += module.h

The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are:

Quoted 6 lines

EXPORT_SYMBOL(h8300_reserved_gpio);
EXPORT_SYMBOL(h8300_free_gpio);
EXPORT_SYMBOL(h8300_set_gpio_dir);

and these are definitely not provided by asm-generic/gpio.h.

Yeah, I will try to remove "#include <asm/gpio.h>" to see whether can pass compiling, tomorrow. :-)

And now, I feel (just guess), it will not, for h8300 really need gpio (it has "gpio-internal.h"), commonly it will need "asm/gpio.h" too.

Tomorrow, I will try to prove whether my guess is correct or not. ;-).

Thanks.

Quoted 12 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Quoted 42 lines · Chen Gang

Quoted 11 lines · Geert Uytterhoeven

Quoted 7 lines · Chen Gang

Need add default "gpio.h" for h8300, or can not pass compiling.

The related error (allmodconfig for h8300):

arch/h8300/kernel/h8300_ksyms.c:17:22: fatal error: asm/gpio.h: No such file or directory

   #include <asm/gpio.h>
                        ^

I this include needed at all? Perhaps it can just be removed?

Pardon ? Do you mean, only removing it will be OK ?

Quoted 20 lines

Quoted 10 lines

Signed-off-by Chen Gang <[email protected]>

---
 arch/h8300/include/asm/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/h8300/include/asm/Kbuild +0 -0

index 8ada3cf..4c627aa 100644

arch/h8300/include/asm/Kbuild line 7

Quoted 7 lines

arch/h8300/include/asm/Kbuild +1 -0

@@ -1,6 +1,7 @@
 
 generic-y += clkdev.h
 generic-y += exec.h
+generic-y += gpio.h
 generic-y += linkage.h
 generic-y += mmu.h
 generic-y += module.h

The only gpio-related exports in arch/h8300/kernel/h8300_ksyms.c are:

Quoted 6 lines

EXPORT_SYMBOL(h8300_reserved_gpio);
EXPORT_SYMBOL(h8300_free_gpio);
EXPORT_SYMBOL(h8300_set_gpio_dir);

and these are definitely not provided by asm-generic/gpio.h.

Quoted 8 lines

Yeah, I will try to remove "#include <asm/gpio.h>" to see whether can pass compiling, tomorrow. :-)

And now, I feel (just guess), it will not, for h8300 really need gpio (it has "gpio-internal.h"), commonly it will need "asm/gpio.h" too.

Tomorrow, I will try to prove whether my guess is correct or not. ;-).

After reading the related code (search "gpio.h" in root source tree), it seems what you said is correct, my guess is incorrect. :-(

Hmm... but better to get final conclusion after finish allmodconfig compiling.

Now, I am compiling, and excuse me, I can not finish today because of some issues (mainly for 'gcc 4.8.0', part for 'ld 2.22', and part for kernel), I will 'process' them, hope can finish before 2013-08-31.

Welcome additional suggestions or completions.

Thanks.

Quoted 17 lines

Thanks.

Quoted 12 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds