arm: goni: remove config.mk file

PATCH Superseded Minkyu Kang 2 participants 7 messages Jul 25, 2013 – Aug 28, 2013

lore

Share & tools

lore

Minkyu Kang

author

2013-07-25 01:45 UTC #0 lore raw

PATCH 2/2 arm: goni: remove config.mk file

Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.

Signed-off-by Minkyu Kang <[email protected]>

---
 board/samsung/goni/config.mk |   34 ----------------------------------
 include/configs/s5p_goni.h   |    3 +++
 2 files changed, 3 insertions(+), 34 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk

board/samsung/goni/config.mk deleted +0 ~~-34~~

deleted file mode 100644
index e4581ca..0000000
@@ -1,34 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000

include/configs/s5p_goni.h +3 -0

index 56e8347..02355a6 100644
@@ -45,6 +45,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000
 
+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG

Signature · 4 lines

1.7.9.5
-- 
Thanks,
Minkyu Kang.

Lukasz Majewski

2013-07-25 11:05 UTC #1 lore raw

PATCH 2/2 arm: goni: remove config.mk file

On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com wrote,

Hi Minkyu,

Quoted 55 lines

Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.

Signed-off-by Minkyu Kang <[email protected]>

---
 board/samsung/goni/config.mk |   34
---------------------------------- include/configs/s5p_goni.h   |
3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk

(quoted diff) +0 -0

b/board/samsung/goni/config.mk deleted file mode 100644 index e4581ca..0000000

board/samsung/goni/config.mk deleted +0 ~~-34~~

@@ -1,34 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000

include/configs/s5p_goni.h +0 -0

index 56e8347..02355a6 100644

include/configs/s5p_goni.h line 46

Quoted 2 lines

include/configs/s5p_goni.h +0 -0

@@ -45,6 +45,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000

Would it be possible to change the DMC0 (Memory controller) base address from 0x30000000 to 0x20000000?

This is what the Linux kernel expects.
(at /arch/arm/mach-s5pv210/include/mach/memory.h)

Quoted 7 lines

include/configs/s5p_goni.h +3 -0

+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Minkyu Kang

author

2013-07-26 01:45 UTC #2 lore raw

PATCH 2/2 arm: goni: remove config.mk file

Dear Lukasz,

Quoted 66 lines · Lukasz Majewski

On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com wrote,

Hi Minkyu,

Quoted 55 lines

Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.

Signed-off-by Minkyu Kang <[email protected]>

---
 board/samsung/goni/config.mk |   34
---------------------------------- include/configs/s5p_goni.h   |
3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk

(quoted diff) +0 -0

b/board/samsung/goni/config.mk deleted file mode 100644 index e4581ca..0000000

board/samsung/goni/config.mk deleted +0 ~~-34~~

@@ -1,34 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000

include/configs/s5p_goni.h +0 -0

index 56e8347..02355a6 100644

include/configs/s5p_goni.h line 46

Quoted 2 lines

include/configs/s5p_goni.h +0 -0

@@ -45,6 +45,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000

Would it be possible to change the DMC0 (Memory controller) base address from 0x30000000 to 0x20000000?

Quoted 3 lines

This is what the Linux kernel expects.
(at /arch/arm/mach-s5pv210/include/mach/memory.h)

Maybe it will be possible. but not this patch.
This patch is for removing config.mk.

btw, I don't have goni target any more. So, if possible.. could you send the patch for it?

Quoted 11 lines

include/configs/s5p_goni.h line 53

Quoted 8 lines

include/configs/s5p_goni.h +3 -0

+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG

Thanks,
Minkyu Kang.

Lukasz Majewski

2013-07-26 06:59 UTC #3 lore raw

PATCH 2/2 arm: goni: remove config.mk file

On Fri, 26 Jul 2013 10:45:09 +0900 Minkyu Kang mk7.kang at samsung.com wrote,

Hi Minkyu,

Quoted 73 lines

Dear Lukasz,
Quoted 66 lines · Lukasz Majewski
On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com wrote,
Hi Minkyu,
Quoted 55 lines
Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.
Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/goni/config.mk |   34
---------------------------------- include/configs/s5p_goni.h   |
3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk
(quoted diff) +0 -0
b/board/samsung/goni/config.mk deleted file mode 100644 index e4581ca..0000000
board/samsung/goni/config.mk deleted +0 ~~-18~~
@@ -1,34 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
board/samsung/goni/config.mk deleted +0 ~~-14~~
-# MA 02111-1307 USA
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000
(quoted diff) +0 -0
b/include/configs/s5p_goni.h index 56e8347..02355a6 100644
include/configs/s5p_goni.h line 46
Quoted 2 lines
include/configs/s5p_goni.h +0 -0
@@ -45,6 +45,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000
Would it be possible to change the DMC0 (Memory controller) base address from 0x30000000 to 0x20000000?
Quoted 3 lines
This is what the Linux kernel expects.
(at /arch/arm/mach-s5pv210/include/mach/memory.h)

Quoted 5 lines

Maybe it will be possible. but not this patch.
This patch is for removing config.mk.
btw, I don't have goni target any more. So, if possible.. could you send the patch for it?

No problem.

BTW:

Goni targets are in a heavy use at our group (for testing and middleware development - ext4, usb). Would you consider change of Maintainer for those targets?

The same applies to universal_c210 target.

Quoted 16 lines

Quoted 12 lines
include/configs/s5p_goni.h line 53
Quoted 9 lines
include/configs/s5p_goni.h +3 -0
+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG
Thanks,
Minkyu Kang.

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Minkyu Kang

author

2013-08-06 03:00 UTC #4 lore raw

PATCH 2/2 arm: goni: remove config.mk file

Dear Lukasz Majewski,

Quoted 84 lines · Lukasz Majewski

On Fri, 26 Jul 2013 10:45:09 +0900 Minkyu Kang mk7.kang at samsung.com wrote,
Hi Minkyu,
Quoted 73 lines
Dear Lukasz,
Quoted 66 lines · Lukasz Majewski
On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com wrote,
Hi Minkyu,
Quoted 55 lines
Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.
Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/goni/config.mk |   34
---------------------------------- include/configs/s5p_goni.h   |
3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk
(quoted diff) +0 -0
b/board/samsung/goni/config.mk deleted file mode 100644 index e4581ca..0000000
board/samsung/goni/config.mk deleted +0 ~~-18~~
@@ -1,34 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public
License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
board/samsung/goni/config.mk deleted +0 ~~-14~~
-# MA 02111-1307 USA
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000
(quoted diff) +0 -0
b/include/configs/s5p_goni.h index 56e8347..02355a6 100644
include/configs/s5p_goni.h line 46
Quoted 2 lines
include/configs/s5p_goni.h +0 -0
@@ -45,6 +45,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000
Would it be possible to change the DMC0 (Memory controller) base address from 0x30000000 to 0x20000000?
Quoted 3 lines
This is what the Linux kernel expects.
(at /arch/arm/mach-s5pv210/include/mach/memory.h)
Quoted 5 lines
Maybe it will be possible. but not this patch.
This patch is for removing config.mk.
btw, I don't have goni target any more. So, if possible.. could you send the patch for it?

Quoted 7 lines

No problem.
BTW:
Goni targets are in a heavy use at our group (for testing and middleware development - ext4, usb). Would you consider change of Maintainer for those targets?

OK. reasonable.

Thanks,
Minkyu Kang.

Minkyu Kang

author

2013-08-06 11:57 UTC #5 lore raw

PATCH v2 2/2 arm: goni: remove config.mk file

In reply to Minkyu Kang

Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.

Signed-off-by Minkyu Kang <[email protected]>

---
changes for v2:
rebased.

 board/samsung/goni/config.mk |   18 ------------------
 include/configs/s5p_goni.h   |    3 +++
 2 files changed, 3 insertions(+), 18 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk

board/samsung/goni/config.mk deleted +0 ~~-18~~

deleted file mode 100644
index e1cadbc..0000000
@@ -1,18 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# SPDX-License-Identifier:	GPL-2.0+
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000

include/configs/s5p_goni.h +3 -0

index d0fafd7..c303244 100644
@@ -29,6 +29,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000
 
+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG

Signature · 1 line

1.7.9.5

Minkyu Kang

author

2013-08-28 01:21 UTC #6 lore raw

PATCH v2 2/2 arm: goni: remove config.mk file

Quoted 43 lines · Minkyu Kang

Since config.mk is deprecated, remove this file, and move CONFIG_SYS_TEXT_BASE define to config file.

Signed-off-by Minkyu Kang <[email protected]>

---
changes for v2:
rebased.

 board/samsung/goni/config.mk |   18 ------------------
 include/configs/s5p_goni.h   |    3 +++
 2 files changed, 3 insertions(+), 18 deletions(-)
 delete mode 100644 board/samsung/goni/config.mk

board/samsung/goni/config.mk deleted +0 ~~-18~~

deleted file mode 100644
index e1cadbc..0000000
@@ -1,18 +0,0 @@
-#
-# Copyright (C) 2010 Samsung Electronics
-# Kyungmin Park <[email protected]>
-#
-# SPDX-License-Identifier:	GPL-2.0+
-#
-
-# On S5PC100 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x38000000 to 0x40000000 (128MiB)
-#
-# On S5PC110 we use the 128 MiB OneDRAM bank at
-#
-# 0x30000000 to 0x35000000 (80MiB)
-# 0x40000000 to 0x50000000 (256MiB)
-#
-CONFIG_SYS_TEXT_BASE = 0x34800000

include/configs/s5p_goni.h +0 -0

index d0fafd7..c303244 100644

include/configs/s5p_goni.h line 37

Quoted 9 lines

include/configs/s5p_goni.h +3 -0

@@ -29,6 +29,9 @@
 /* DRAM Base */
 #define CONFIG_SYS_SDRAM_BASE		0x30000000
 
+/* Text Base */
+#define CONFIG_SYS_TEXT_BASE		0x34800000
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG

applied to u-boot-samsung.

Minkyu Kang.