Skip to contentSkip to conversation

h8300/kernel/timer/timer8.c: add the missing semicolon

PATCH Superseded Chen Gang 1 participant 4 messages Aug 29, 2013 libata

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 h8300/kernel/timer/timer8.c: add the missing semicolon

Add the missing semicolon to fix the typo issue.

The related error: (defconfig for H8S):

arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'

Signed-off-by Chen Gang <[email protected]>
---
 arch/h8300/Makefile              |    2 +-
 arch/h8300/kernel/timer/timer8.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/h8300/Makefile +1 -1
index a556447..d2ba710 100644
@@ -25,7 +25,7 @@ model-$(CONFIG_RAMKERNEL)	:= ram
 model-$(CONFIG_ROMKERNEL)	:= rom
 MODEL := $(model-y)
 
-cflags-$(CONFIG_CPU_H8300H)	:= -mh
+cflags-$(CONFIG_CPU_H8300H)	:= -mh -mcpu=h8300h
 ldflags-$(CONFIG_CPU_H8300H)	:= -mh8300helf
 cflags-$(CONFIG_CPU_H8S)	:= -ms
 ldflags-$(CONFIG_CPU_H8S)	:= -mh8300self
arch/h8300/kernel/timer/timer8.c +1 -1
index 505f341..8aac2a7 100644
@@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
 
 #if defined(CONFIG_CPU_H8S)
 	/* Timer module enable */
-	ctrl_bclr(0, MSTPCRL)
+	ctrl_bclr(0, MSTPCRL);
 #endif
 
 	/* initialize timer */
Signature · 1 line
1.7.7.6
author
#1 lore raw
Quoted 18 lines · Chen Gang

Add the missing semicolon to fix the typo issue.

The related error: (defconfig for H8S):

arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'

Signed-off-by Chen Gang <[email protected]>
---
 arch/h8300/Makefile              |    2 +-
 arch/h8300/kernel/timer/timer8.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/h8300/Makefile +0 -0
index a556447..d2ba710 100644

arch/h8300/Makefile model-$(CONFIG_RAMKERNEL) := ram · line 28

Quoted 5 lines
arch/h8300/Makefile +1 -1
@@ -25,7 +25,7 @@ model-$(CONFIG_RAMKERNEL)	:= ram
 model-$(CONFIG_ROMKERNEL)	:= rom
 MODEL := $(model-y)
 
-cflags-$(CONFIG_CPU_H8300H)	:= -mh
+cflags-$(CONFIG_CPU_H8300H)	:= -mh -mcpu=h8300h

Oh, sorry, it contents some waste things, I should send patch v2.

Quoted 17 lines
arch/h8300/Makefile +0 -0
 ldflags-$(CONFIG_CPU_H8300H)	:= -mh8300helf
 cflags-$(CONFIG_CPU_H8S)	:= -ms
 ldflags-$(CONFIG_CPU_H8S)	:= -mh8300self
arch/h8300/kernel/timer/timer8.c +1 -1
index 505f341..8aac2a7 100644
@@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
 
 #if defined(CONFIG_CPU_H8S)
 	/* Timer module enable */
-	ctrl_bclr(0, MSTPCRL)
+	ctrl_bclr(0, MSTPCRL);
 #endif
 
 	/* initialize timer */
Signature · 1 line
Chen Gang
author
#2 lore raw

PATCH v2 1/1 h8300/kernel/timer/timer8.c: add the missing semicolon

In reply to Chen Gang

Add the missing semicolon to fix the typo issue.

The related error: (defconfig for H8S):

arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'

Signed-off-by Chen Gang <[email protected]>
---
 arch/h8300/kernel/timer/timer8.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/h8300/kernel/timer/timer8.c +1 -1
index 505f341..8aac2a7 100644
@@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
 
 #if defined(CONFIG_CPU_H8S)
 	/* Timer module enable */
-	ctrl_bclr(0, MSTPCRL)
+	ctrl_bclr(0, MSTPCRL);
 #endif
 
 	/* initialize timer */
Signature · 1 line
1.7.7.6
author
#3 lore raw

PATCH 1/1 drivers: ide: Kconfig: let IDE_H8300 depends on H8300H_AKI3068NET or H8300H_H8MAX

According to the code in "arch/h8300/Kbuild.ide", IDE_H8300 need depend on "H8300H_AKI3068NET || H8300H_H8MAX", or can not pass compiling with allmodconfig for h8300.

The related error:

drivers/ide/ide-h8300.c: In function 'hw_setup':
drivers/ide/ide-h8300.c:73:27: error: 'CONFIG_H8300_IDE_BASE' undeclared (first use in this function) drivers/ide/ide-h8300.c:73:27: note: each undeclared identifier is reported only once for each function it appears in drivers/ide/ide-h8300.c:74:26: error: 'CONFIG_H8300_IDE_ALT' undeclared (first use in this function) drivers/ide/ide-h8300.c:75:23: error: 'CONFIG_H8300_IDE_IRQ' undeclared (first use in this function) drivers/ide/ide-h8300.c: In function 'h8300_ide_init':
drivers/ide/ide-h8300.c:90:7: error: 'CONFIG_H8300_IDE_BASE' undeclared (first use in this function) drivers/ide/ide-h8300.c:92:7: error: 'CONFIG_H8300_IDE_ALT' undeclared (first use in this function) drivers/ide/ide-h8300.c: At top level:
drivers/ide/ide-h8300.c:109:16: error: expected declaration specifiers or '...' before string constant

Signed-off-by Chen Gang <[email protected]>
---
 drivers/ide/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ide/Kconfig +1 -1
index 02906ca..f79b49f 100644
@@ -724,7 +724,7 @@ config BLK_DEV_IDE_RAPIDE
 
 config IDE_H8300
 	tristate "H8300 IDE support"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	default y
 	help
 	  Enables the H8300 IDE driver.
Signature · 1 line
1.7.7.6