Skip to contentSkip to conversation

drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300

PATCH Superseded Chen Gang 3 participants 7 messages Aug 30, 2013 – Sep 4, 2013

Subsystems (3)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300

Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it will no related irq and base address).

The release error:

CC [M] drivers/net/hamradio/bpqether.o
drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/8390/Kconfig +1 -1
index a5f91e1..becef25 100644
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 2 lines · [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and…

Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it will no related irq and base address).

Do you have an H83000 and really know that is true? I'm guessing no.

Looking at the driver, it is kind of broken that it only assigns I/O and irq for two platforms, but the H8300 arch Kconfig.cpu only allows building a single platform in a given kernel anyway, so a dependency fix is probably acceptable here.

Given that, what you really want to indicate is something like:

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

Quoted 4 lines

The release error:

CC [M] drivers/net/hamradio/bpqether.o

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This file has nothing to do with the problem in question. [If you are going to do a "make -j30" in testing, then at least restart with -j1 to properly capture the error message.]

Please update the commit log appropriately and resubmit.

Paul.
--

Quoted 31 lines

drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/8390/Kconfig +1 -1
index a5f91e1..becef25 100644
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
Signature · 1 line
1.7.7.6
author
#2 lore raw
Quoted 5 lines · Paul Gortmaker
Quoted 2 lines · [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and…

Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it will no related irq and base address).

Quoted 7 lines

Do you have an H83000 and really know that is true? I'm guessing no.

Looking at the driver, it is kind of broken that it only assigns I/O and irq for two platforms, but the H8300 arch Kconfig.cpu only allows building a single platform in a given kernel anyway, so a dependency fix is probably acceptable here.

OK, thanks.

Quoted 8 lines

Given that, what you really want to indicate is something like:

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

Hmm... that sounds good to me.

Quoted 10 lines
Quoted 4 lines

The release error:

CC [M] drivers/net/hamradio/bpqether.o

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This file has nothing to do with the problem in question. [If you are going to do a "make -j30" in testing, then at least restart with -j1 to properly capture the error message.]

Oh, it is a waste, which I should remove, thanks.

Quoted 2 lines

Please update the commit log appropriately and resubmit.

OK, I will send patch v2.

Quoted 25 lines

Paul.
--

Quoted 22 lines

drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/8390/Kconfig +0 -0
index a5f91e1..becef25 100644
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
Quoted 11 lines
Quoted 9 lines
drivers/net/ethernet/8390/Kconfig +1 -1
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
Signature · 1 line
1.7.7.6

Thanks.

Signature · 1 line
Chen Gang
author
#3 lore raw
Quoted 7 lines · Chen Gang
Quoted 6 lines · Paul Gortmaker
Quoted 2 lines · [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and…

Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it will no related irq and base address).

Do you have an H83000 and really know that is true? I'm guessing no.

Oh, sorry, forgot reply this item.

And I have no related hardware (I am just cross compiling).

Hmm... according to the implementation, we can assume original author
though: "currently only H8300H_AKI3068NET and H8300H_H8MAX can/need support NE_H8300" (may better use "need" instead of "can").

Thanks.

Quoted 78 lines
Quoted 6 lines

Looking at the driver, it is kind of broken that it only assigns I/O and irq for two platforms, but the H8300 arch Kconfig.cpu only allows building a single platform in a given kernel anyway, so a dependency fix is probably acceptable here.

OK, thanks.

Quoted 8 lines

Given that, what you really want to indicate is something like:

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

Hmm... that sounds good to me.

Quoted 10 lines
Quoted 4 lines

The release error:

CC [M] drivers/net/hamradio/bpqether.o

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This file has nothing to do with the problem in question. [If you are going to do a "make -j30" in testing, then at least restart with -j1 to properly capture the error message.]

Oh, it is a waste, which I should remove, thanks.

Quoted 2 lines

Please update the commit log appropriately and resubmit.

OK, I will send patch v2.

Quoted 25 lines

Paul.
--

Quoted 22 lines

drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/8390/Kconfig +0 -0
index a5f91e1..becef25 100644
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
Quoted 11 lines
Quoted 9 lines
drivers/net/ethernet/8390/Kconfig +1 -1
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
Signature · 1 line
1.7.7.6

Thanks.

Signature · 1 line
Chen Gang
author
#4 lore raw

PATCH v2 1/1 drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300

In reply to Paul Gortmaker

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

The release error:

drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev':
drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module':
drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat]

---
 drivers/net/ethernet/8390/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/8390/Kconfig +1 -1
index a5f91e1..becef25 100644
@@ -148,7 +148,7 @@ config PCMCIA_PCNET
 
 config NE_H8300
 	tristate "NE2000 compatible support for H8/300"
-	depends on H8300
+	depends on H8300H_AKI3068NET || H8300H_H8MAX
 	---help---
 	  Say Y here if you want to use the NE2000 compatible
 	  controller on the Renesas H8/300 processor.
Signature · 1 line
1.7.7.6
maintainer Applied
#5 lore raw

From: Chen Gang <[email protected]>
Date: Mon, 02 Sep 2013 10:20:02 +0800

Quoted 7 lines

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

The release error:

...

Quoted 1 line

Applied, thanks.

author
#6 lore raw
Quoted 9 lines · David Miller

From: Chen Gang <[email protected]>
Date: Mon, 02 Sep 2013 10:20:02 +0800

Quoted 6 lines

Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically.

Quoted 7 lines
Quoted 1 line

The release error:

...

Quoted 1 line

Applied, thanks.

Thank you too.

And h8300 architecture will be remove from Linux kernel (and I am sorry for forgot to notifying Paul about it),

Do we still need this patch (I am not quite sure, maybe we still need) ?

Thanks.

Signature · 1 line
Chen Gang