Skip to contentSkip to conversation

qmp: Documentation for BLOCK_IMAGE_CORRUPTED

PATCH Superseded Max Reitz 2 participants 3 messages Sep 2, 2013 – Sep 3, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Max Reitz

author
#0 lore raw

PATCH 1/1 qmp: Documentation for BLOCK_IMAGE_CORRUPTED

Add an appropriate entry describing this event and its parameters into qmp-events.txt.

---
Follow-up to:
- Add metadata overlap checks (series, v5); particularly patch 2 (qcow2: Metadata overlap checks)

---
 QMP/qmp-events.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
QMP/qmp-events.txt +22 -0
index 39b6016..6ff74d6 100644
@@ -478,3 +478,25 @@ Example:
 
 { "event": "GUEST_PANICKED",
      "data": { "action": "pause" } }
+
+BLOCK_IMAGE_CORRUPTED
+---------------------
+
+Emitted when a disk image is being marked corrupt.
+
+Data:
+
+- "device": Device name (json-string)
+- "msg":    Informative message (e.g., reason for the corruption) (json-string)
+- "offset": If the corruption resulted from an image access, this is the access
+            offset into the image (json-int)
+- "size":   If the corruption resulted from an image access, this is the access
+            size (json-int)
+
+Example:
+
+{ "event": "BLOCK_IMAGE_CORRUPTED",
+    "data": { "device": "ide0-hd0",
+        "msg": "Prevented active L1 table overwrite", "offset": 196608,
+        "size": 65536 },
+    "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Max Reitz

Add an appropriate entry describing this event and its parameters into qmp-events.txt.

---
Follow-up to:
- Add metadata overlap checks (series, v5); particularly patch 2 (qcow2: Metadata overlap checks)

---
 QMP/qmp-events.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
QMP/qmp-events.txt +0 -0
index 39b6016..6ff74d6 100644

QMP/qmp-events.txt Example: · line 483

Quoted 6 lines
QMP/qmp-events.txt +3 -0
@@ -478,3 +478,25 @@ Example:
 
 { "event": "GUEST_PANICKED",
      "data": { "action": "pause" } }
+
+BLOCK_IMAGE_CORRUPTED
+---------------------

The content is fine, but the location is not. We are trying to keep this file sorted by event name, so this belongs between BALLOON_CHANGE and BLOCK_IO_ERROR.

As sorting is trivial, you can add this to your v2:

Signature · 2 lines
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
author
#2 lore raw
Quoted 19 lines · Eric Blake
Quoted 18 lines · Max Reitz

Add an appropriate entry describing this event and its parameters into qmp-events.txt.

---
Follow-up to:
- Add metadata overlap checks (series, v5); particularly patch 2 (qcow2: Metadata overlap checks)

---
  QMP/qmp-events.txt | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)
QMP/qmp-events.txt +0 -0
index 39b6016..6ff74d6 100644
@@ -478,3 +478,25 @@ Example:
 
Quoted 8 lines

QMP/qmp-events.txt Example: · line 483

Quoted 5 lines
QMP/qmp-events.txt +3 -0
  { "event": "GUEST_PANICKED",
       "data": { "action": "pause" } }
+
+BLOCK_IMAGE_CORRUPTED
+---------------------

The content is fine, but the location is not. We are trying to keep this file sorted by event name, so this belongs between BALLOON_CHANGE and BLOCK_IO_ERROR.

Okay, I was wondering about something like that, but the GUEST_PANICED at the end signaled to me there would be no such sorting. ;-)

Quoted 3 lines

As sorting is trivial, you can add this to your v2:

Thank you, I just sent v2.

Max