clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast
A message that is not in the archive (sent off-list or not yet received): 20130904080151.24562.91334.sendpatchset@w520
Simon Horman
Tested-byQuoted 12 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Update the STI driver by setting
cpu_possible_maskto make EMEV2 SMP work as expected together with the ARM broadcast timer.This breakage was introduced by:
f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.
Quoted 8 lines
Signed-off-by Magnus Damm <[email protected]>---
Thanks to feedback from Stephen Boyd this is is a reworked version of:
[PATCH] clocksource:em_sti: Adjust clock event rating to fix SMP broadcastdrivers/clocksource/em_sti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I will let this sit for a few days to see if there is any further feedback.
Simon Horman
Tested-by[ Droped [email protected] CC, the address seems to bounce
Added Daniel Lezcano CC, I believe he handles clocksource these days ]
Quoted 5 lines · Magnus Damm
From: Magnus Damm <[email protected]>
Update the STI driver by setting
cpu_possible_maskto make EMEV2 SMP work as expected together with the ARM broadcast timer.
Quoted 8 lines
This breakage was introduced by:
f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.
Signed-off-by Magnus Damm <[email protected]>
I will let this sit for a few days to see if there is any further feedback.
Quoted 20 lines
---
Thanks to feedback from Stephen Boyd this is is a reworked version of:
[PATCH] clocksource:em_sti: Adjust clock event rating to fix SMP broadcastdrivers/clocksource/em_sti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/em_sti.c +1
-1@@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s ced->name =dev_name (&p->pdev->dev); ced->features =CLOCK_EVT_FEAT_ONESHOT ; ced->rating =200 ; - ced->cpumask =cpumask_of (0 ); + ced->cpumask = cpu_possible_mask; ced->set_next_event = em_sti_clock_event_next; ced->set_mode = em_sti_clock_event_mode;
Quoted 1 line · Simon Horman
[ Droped [email protected] CC, the address seems to bounce
The address is [email protected]
Quoted 1 line
Added Daniel Lezcano CC, I believe he handles clocksource these days ]
Right.
Quoted 39 lines · Magnus Damm
Quoted 5 lines
From: Magnus Damm <[email protected]>
Update the STI driver by setting
cpu_possible_maskto make EMEV2 SMP work as expected together with the ARM broadcast timer.Quoted 8 lines
This breakage was introduced by:
f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.
Signed-off-by Magnus Damm <[email protected]>Tested-by Simon Horman <[email protected]>I will let this sit for a few days to see if there is any further feedback.
Quoted 20 lines
---
Thanks to feedback from Stephen Boyd this is is a reworked version of:
[PATCH] clocksource:em_sti: Adjust clock event rating to fix SMP broadcastdrivers/clocksource/em_sti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/em_sti.c +1
-1@@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s ced->name =dev_name (&p->pdev->dev); ced->features =CLOCK_EVT_FEAT_ONESHOT ; ced->rating =200 ; - ced->cpumask =cpumask_of (0 ); + ced->cpumask = cpu_possible_mask; ced->set_next_event = em_sti_clock_event_next; ced->set_mode = em_sti_clock_event_mode;
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Stephen Boyd
Reviewed-byQuoted 11 lines · Daniel Lezcano
Quoted 11 lines · Magnus Damm
Quoted 9 lines
From: Magnus Damm <[email protected]>
Update the STI driver by setting
cpu_possible_maskto make EMEV2 SMP work as expected together with the ARM broadcast timer.This breakage was introduced by:
f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.
Signed-off-by Magnus Damm <[email protected]>Tested-by Simon Horman <[email protected]>I will let this sit for a few days to see if there is any further feedback.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 15 lines · Stephen Boyd
Quoted 14 lines · Daniel Lezcano
Quoted 14 lines · Magnus Damm
Quoted 12 lines
From: Magnus Damm <[email protected]>
Update the STI driver by setting
cpu_possible_maskto make EMEV2 SMP work as expected together with the ARM broadcast timer.This breakage was introduced by:
f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Magnus Damm <[email protected]>Tested-by Simon Horman <[email protected]>I will let this sit for a few days to see if there is any further feedback.
Reviewed-by Stephen Boyd <[email protected]>
Thanks, I have queue this up.
I will let it sit in next for a little bit
and then forward it on to Daniel.