Skip to contentSkip to conversation

Pull request for branch yem/misc-updates

GIT PULL New Yann E. MORIN 4 participants 12 messages Sep 4, 2013 – Sep 5, 2013

lore
Share & tools
lore
#0 lore raw

From: "Yann E. MORIN" <[email protected]>

Hello All!

Peter, here are a few changes I've been sitting on since before I switched into holidays mode (and in redo-the-kitchen-from-scrath mode, which ultimately kicked in the has-no-time-to-get-in-front-of-computer mode) three weeks ago.

I'm now back in operational condition! :-]

- two changes RPI-related: bump kernel (rpi_defconfig), bunp firmware
- further cleanup top-level config by moving target options to their own sub-menu
- optionally print toolchain wrapper's args one-per-line in DEBUG mode

I still have to dequeue all my mails, but I'm still on holidays until the end of the week, so... ;-)

Regards,
Yann E. MORIN.

The following changes since commit 5128cc6602d56a2c3af4cf6a0fe072d39d6c1aca:

gcc: pass MAKEINFO=missing in the environment rather than as a ./configure arg (2013-09-04 16:22:30 +0200)

are available in the git repository at:

git://gitorious.org/buildroot/buildroot.git

for you to fetch changes up to e1d03e22b10b073d5906a4b6df22c72d38bfd8c2:

toolchain/wrapper: add option to print one argument per line (2013-09-04 23:27:37 +0200)

----------------------------------------------------------------
Yann E. MORIN (4):
package/rpi-firmware: bump version
configs: bump kernel use for RPi, use simpler defconfig
targets: move target options to their own sub-menu toolchain/wrapper: add option to print one argument per line

 arch/Config.in                                     |  4 ++++
 configs/rpi_defconfig                              |  4 ++--
 package/rpi-firmware/rpi-firmware.mk               |  2 +-
 .../toolchain-external/ext-toolchain-wrapper.c     | 25 +++++++++++++++-------
 4 files changed, 24 insertions(+), 11 deletions(-)
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH 1/4 package/rpi-firmware: bump version

From: "Yann E. MORIN" <[email protected]>

Fixes and improvements for USB, audio sync, camera support, codecs, HDMI framerate and audio, and GPU freezes.

---
 package/rpi-firmware/rpi-firmware.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rpi-firmware/rpi-firmware.mk +1 -1
index 6ea621f..55c1ca4 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 320084a
+RPI_FIRMWARE_VERSION = d4f5315
 RPI_FIRMWARE_SITE = http://github.com/raspberrypi/firmware/tarball/$(RPI_FIRMWARE_VERSION)
 RPI_FIRMWARE_LICENSE = BSD-3c
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/4 package/rpi-firmware: bump version

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Fixes and improvements for USB, audio sync, camera support, Yann> codecs, HDMI framerate and audio, and GPU freezes.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/4 configs: bump kernel use for RPi, use simpler defconfig

In reply to Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

Bump for a slew of USB-related and other fixes.

The bcmrpi defconfig is a huge beast with lots of superfluous drivers. The brcmrpi_quick defconfig is a stripped down minimalist defconfig with all that is needed to bring up a RPi with complete HW support, and nothing superfluous, which is what we need for a board's defconfig in buildroot.

---
 configs/rpi_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
configs/rpi_defconfig +2 -2
index 9d608f1..2b19673 100644
@@ -17,7 +17,7 @@ BR2_DEFAULT_KERNEL_VERSION="3.6.11"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL="git://github.com/raspberrypi/linux.git"
-BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="0006326"
+BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="1587f77"
 BR2_LINUX_KERNEL_USE_DEFCONFIG=y
-BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi"
+BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi_quick"
 BR2_LINUX_KERNEL_ZIMAGE=y
Signature · 1 line
1.8.1.2
#4 lore raw

PATCH 2/4 configs: bump kernel use for RPi, use simpler defconfig

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Bump for a slew of USB-related and other fixes.

Yann> The bcmrpi defconfig is a huge beast with lots of superfluous drivers. Yann> The brcmrpi_quick defconfig is a stripped down minimalist defconfig with Yann> all that is needed to bring up a RPi with complete HW support, and Yann> nothing superfluous, which is what we need for a board's defconfig in Yann> buildroot.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 3/4 targets: move target options to their own sub-menu

In reply to Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

Currently, all target options lie in the top-level menu. This looks a bit clumsy, since all other options are neatly folded into their own sematic sub-menus each.

Move the target option into their own sub-menu too.

Thomas De Schampheleire <[email protected]>

---
 arch/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
arch/Config.in +4 -0
index 14899ca..3fd8c1c 100644
@@ -1,3 +1,5 @@
+menu "Target options"
+
 config BR2_ARCH_IS_64
 	bool
 
@@ -335,3 +337,5 @@ endif
 if BR2_xtensa
 source "arch/Config.in.xtensa"
 endif
+
+endmenu # Target options
Signature · 1 line
1.8.1.2
#6 lore raw

PATCH 3/4 targets: move target options to their own sub-menu

Op 4-sep.-2013 23:36 schreef "Yann E. MORIN" <[email protected]> het volgende:

Quoted 11 lines

From: "Yann E. MORIN" <[email protected]>

Currently, all target options lie in the top-level menu. This looks a bit clumsy, since all other options are neatly folded into their own sematic sub-menus each.

Move the target option into their own sub-menu too.

Thomas De Schampheleire <[email protected]>

This is an Acked-by...

Quoted 23 lines
---
 arch/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
arch/Config.in +4 -1
index 14899ca..3fd8c1c 100644
@@ -1,3 +1,5 @@
+menu "Target options"
+
 config BR2_ARCH_IS_64
        bool
 
@@ -335,3 +337,5 @@ endif
 if BR2_xtensa
 source "arch/Config.in.xtensa"
 endif
+
+endmenu # Target options
--

1.8.1.2

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130905/3ee98aeb/attachment-0001.html>

#7 lore raw

PATCH 3/4 targets: move target options to their own sub-menu

Thomas, All,

On 2013-09-05 04:25 +0200, Thomas De Schampheleire spake thusly:

Quoted 9 lines

Op 4-sep.-2013 23:36 schreef "Yann E. MORIN" <[email protected]> het volgende:

Quoted 7 lines

From: "Yann E. MORIN" <[email protected]>

Currently, all target options lie in the top-level menu. This looks a bit clumsy, since all other options are neatly folded into their own sematic sub-menus each.

Quoted 6 lines
Quoted 4 lines

Move the target option into their own sub-menu too.

Thomas De Schampheleire <[email protected]>

This is an Acked-by...

Doh. Yes, bad cut-n-paste, sorry.

It seems I have to re-train my fingers after being away from the kbd for 15+ days... :-/

Regrads,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#8 lore raw

PATCH 3/4 targets: move target options to their own sub-menu

In reply to Yann E. MORIN
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Yann> From: "Yann E. MORIN" <[email protected]> Yann> Currently, all target options lie in the top-level menu. Yann> This looks a bit clumsy, since all other options are neatly Yann> folded into their own sematic sub-menus each.

Yann> Move the target option into their own sub-menu too.

Yann> Signed-off-by: "Yann E. MORIN" <[email protected]> Yann> Thomas De Schampheleire <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#9 lore raw

PATCH 4/4 toolchain/wrapper: add option to print one argument per line

In reply to Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

In case there are many arguments passed to the tools, the command line can get very long, and difficult to parse visually.

For example, the Linux kernel passes a lot of arguments to gcc (at least 45, which gives 53 with our hard-coded args). Looking at such a command line is daunting.

So, add the possibility to print each argument on its own line.

Also, enclose all args between single quotes, so the command line can be safely copy-pasted without special chars (spaces, $) being inrerpreted by the shell.

---
 .../toolchain-external/ext-toolchain-wrapper.c     | 25 +++++++++++++++-------
 1 file changed, 17 insertions(+), 8 deletions(-)
toolchain/toolchain-external/ext-toolchain-wrapper.c +17 -8
index 565e36b..dfdfcff 100644
@@ -74,7 +74,8 @@ int main(int argc, char **argv)
 	char *relbasedir, *absbasedir;
 	char *progpath = argv[0];
 	char *basename;
-	int ret, i, count = 0;
+	char *env_debug;
+	int ret, i, count = 0, debug;
 
 	/* Calculate the relative paths */
 	basename = strrchr(progpath, '/');
@@ -157,13 +158,21 @@ int main(int argc, char **argv)
 	/* finish with NULL termination */
 	*cur = NULL;
 
-	if (getenv("BR_DEBUG_WRAPPER")) {
-		fprintf(stderr, "Executing");
-
-		for (i = 0; args[i]; i++)
-			fprintf(stderr, " %s", args[i]);
-
-		fprintf(stderr, "\n");
+	/* Debug the wrapper to see actual arguments passed to
+	 * the compiler:
+	 * unset, empty, or 0: do not trace
+	 * set to 1          : trace all arguments on a single line
+	 * set to 2          : trace one argument per line
+	 */
+	if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
+		debug = atoi(env_debug);
+		if (debug > 0) {
+			fprintf(stderr, "Toolchain wrapper executing:");
+			for (i = 0; args[i]; i++)
+				fprintf(stderr, "%s'%s'",
+					(debug == 2)?"\n    ":" ", args[i]);
+			fprintf(stderr, "\n");
+		}
 	}
 
 	if (execv(path, args))
Signature · 1 line
1.8.1.2
#10 lore raw

PATCH 4/4 toolchain/wrapper: add option to print one argument per line

Quoted 9 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

In case there are many arguments passed to the tools, the command line can get very long, and difficult to parse visually.

For example, the Linux kernel passes a lot of arguments to gcc (at least 45, which gives 53 with our hard-coded args). Looking at such a command line is daunting.

Quoted 7 lines

So, add the possibility to print each argument on its own line.

Also, enclose all args between single quotes, so the command line can be safely copy-pasted without special chars (spaces, $) being inrerpreted by the shell.

This feature should be mentioned in the docs.

Apart for that:

[Tested on arm_foundationv8_defconfig]

Luca

#11 lore raw

PATCH 4/4 toolchain/wrapper: add option to print one argument per line

Luca, All,

On 2013-09-05 14:48 +0200, Luca Ceresoli spake thusly:

Quoted 12 lines
Quoted 11 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

In case there are many arguments passed to the tools, the command line can get very long, and difficult to parse visually.

For example, the Linux kernel passes a lot of arguments to gcc (at least 45, which gives 53 with our hard-coded args). Looking at such a command line is daunting.

So, add the possibility to print each argument on its own line.

Quoted 7 lines
Quoted 5 lines

Also, enclose all args between single quotes, so the command line can be safely copy-pasted without special chars (spaces, $) being inrerpreted by the shell.

This feature should be mentioned in the docs.

Well, for now, BR_DEBUG_WRAPPER is not even documented. But I agree this is missing; will add.

Quoted 5 lines

Apart for that:

[Tested on arm_foundationv8_defconfig]

I'll add those when I respin the patch. Thank you! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'