Skip to contentSkip to conversation

Subject: [PATCH v.2] at91: add support for CDU9G25 board

PATCH New Jiri Prchal 3 participants 6 messages Sep 9, 2013 – Sep 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

v.2
Fixed static IP and MAC addr cofiguration by random MAC and DHCP. Added entry to MAINTAINERS.
Fixed line lenght, trailing spaces and other cosmetics.

---
 MAINTAINERS               |    3 +
 board/cdu9g25/Makefile    |   48 +++++++++++
 board/cdu9g25/cdu9g25.c   |  134 +++++++++++++++++++++++++++++
 board/cdu9g25/config.mk   |    1 +
 boards.cfg                |    1 +
 include/configs/cdu9g25.h |  204 +++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 391 insertions(+)
 create mode 100644 board/cdu9g25/Makefile
 create mode 100644 board/cdu9g25/cdu9g25.c
 create mode 100644 board/cdu9g25/config.mk
 create mode 100644 include/configs/cdu9g25.h
MAINTAINERS +3 -0
index bd0f3a0..444500b 100644
@@ -939,6 +939,9 @@ Bo Shen <[email protected]>
 	at91sam9x5ek		ARM926EJS (AT91SAM9G15,G25,G35,X25,X35 SoC)
 	sama5d3xek		ARMV7 (SAMA5D31, D33, D34, D35 SoC)
 
+Jiri Prchal <[email protected]>
+	cdu9g25			ARM926EJS (AT91SAM9G25 SoC)
+
 Rajeshwari Shinde <[email protected]>
 
 	snow			ARM ARMV7 (EXYNOS5250 SoC)
board/cdu9g25/Makefile new file +48 -0

48 lines not on this page · raw message

board/cdu9g25/cdu9g25.c new file +134 -0

134 lines not on this page · raw message

board/cdu9g25/config.mk new file +1 -0
new file mode 100644
index 0000000..528ed4a
@@ -0,0 +1 @@
+CONFIG_SYS_TEXT_BASE = 0x27f00000
boards.cfg +1 -0
index be810c7..572d20d 100644
@@ -77,6 +77,7 @@ integratorcp_cm926ejs        arm         arm926ejs   integrator          armltd
 aspenite                     arm         arm926ejs   -                   Marvell        armada100
 gplugd                       arm         arm926ejs   -                   Marvell        armada100
 afeb9260                     arm         arm926ejs   -                   -              at91
+cdu9g25                      arm         arm926ejs   -                   -              at91
 at91sam9260ek_dataflash_cs0  arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS0
 at91sam9260ek_dataflash_cs1  arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS1
 at91sam9260ek_nandflash      arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_NANDFLASH
include/configs/cdu9g25.h new file +204 -0

204 lines not on this page · raw message

--
1.7.9.5

#1 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

Dear Jiri Prchal,

Quoted 1 line · In message <[email protected]> you…

This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

Please keep the line length of the commit message < 70 characters.

Quoted 4 lines

v.2
Fixed static IP and MAC addr cofiguration by random MAC and DHCP. Added entry to MAINTAINERS.
Fixed line lenght, trailing spaces and other cosmetics.

This comment does not belong into the commit message - please move it to the comment section, i. e. below the "---" line.

MAINTAINERS Bo Shen <[email protected]> · line 945

Quoted 10 lines
MAINTAINERS +3 -0
@@ -939,6 +939,9 @@ Bo Shen <[email protected]>
 	at91sam9x5ek		ARM926EJS (AT91SAM9G15,G25,G35,X25,X35 SoC)
 	sama5d3xek		ARMV7 (SAMA5D31, D33, D34, D35 SoC)
 
+Jiri Prchal <[email protected]>
+	cdu9g25			ARM926EJS (AT91SAM9G25 SoC)
+
 Rajeshwari Shinde <[email protected]>

Please keep the list sorted.

MAINTAINERS Bo Shen <[email protected]>

Quoted 5 lines
MAINTAINERS +5 -0
+#define CONFIG_BOOTARGS		"console=ttyS0,115200 ubi.mtd=root"\
+				"root=ubi0:root rootfstype=ubifs rw"\
+				"g_ether.dev_addr=02:04:25:aa:55:5e"\
+				"g_ether.host_addr=02:04:25:aa:55:5f"
+#define CONFIG_SERVERIP		10.0.1.1

We do not allow static network configuration in board config files! Please get rid of these MAC and IP addresses here.

Best regards,

Wolfgang Denk

Signature · 9 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The project was large enough and management communication poor enough
to prompt many members of the team to see themselves  as  contestants
making  brownie  points,  rather  than as builders making programming
products. Each suboptimized  his  piece  to  meet  his  targets;  few
stopped to think about the total effect on the customer.
                              - Fred Brooks, "The Mythical Man Month"
#2 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

Hi Wolfgang,

Dne 9.9.2013 17:34, Wolfgang Denk napsal(a):

Quoted 7 lines

Dear Jiri Prchal,

Quoted 1 line · In message <[email protected]> you…

This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

Please keep the line length of the commit message < 70 characters.

Quoted 7 lines
Quoted 4 lines

v.2
Fixed static IP and MAC addr cofiguration by random MAC and DHCP. Added entry to MAINTAINERS.
Fixed line lenght, trailing spaces and other cosmetics.

This comment does not belong into the commit message - please move it to the comment section, i. e. below the "---" line.

I'm not sure if I even should number versions of this patch?

Quoted 15 lines

MAINTAINERS Bo Shen <[email protected]> · line 945

Quoted 11 lines
MAINTAINERS +3 -0
@@ -939,6 +939,9 @@ Bo Shen <[email protected]>
  	at91sam9x5ek		ARM926EJS (AT91SAM9G15,G25,G35,X25,X35 SoC)
  	sama5d3xek		ARMV7 (SAMA5D31, D33, D34, D35 SoC)
 
+Jiri Prchal <[email protected]>
+	cdu9g25			ARM926EJS (AT91SAM9G25 SoC)
+
  Rajeshwari Shinde <[email protected]>

Please keep the list sorted.

Quoted 4 lines

MAINTAINERS Bo Shen <[email protected]>

Quoted 4 lines
MAINTAINERS +4 -0
+#define CONFIG_BOOTARGS		"console=ttyS0,115200 ubi.mtd=root"\
+				"root=ubi0:root rootfstype=ubifs rw"\
+				"g_ether.dev_addr=02:04:25:aa:55:5e"\
+				"g_ether.host_addr=02:04:25:aa:55:5f"

This is here for linux connection with PC via USB ethernet gadget. I'd like static IP for this connection but if there is random MAC addr I must set up IP again and again. Is another solution for this?

Quoted 1 line
Quoted 1 line

+#define CONFIG_SERVERIP 10.0.1.1

Please help me with this:
I'd like to have board prepared for download images from TFTP server on address 10.0.1.1.
Is there other way how to do it? Even with MAC addr, I solved it with random MAC, is that OK? I keep in mind that would be nice read unique serial number from F-RAM (is on boart too) on SPI and use it as MAC addr. Will be this way better?

Quoted 8 lines

We do not allow static network configuration in board config files! Please get rid of these MAC and IP addresses here.

Best regards,

Wolfgang Denk

With many thanks,
Jiri

#3 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

Dear Ji?? Prchal,

Quoted 3 lines · Ji?? Prchal

Dne 9.9.2013 17:34, Wolfgang Denk napsal(a):

Quoted 2 lines

In message <[email protected]> you wrote:

<snip>

Quoted 7 lines
Quoted 4 lines

include/configs/cdu9g25.h line 180

Quoted 4 lines
include/configs/cdu9g25.h new file +4 -0
+#define CONFIG_BOOTARGS        "console=ttyS0,115200 ubi.mtd=root"\
+                "root=ubi0:root rootfstype=ubifs rw"\
+                "g_ether.dev_addr=02:04:25:aa:55:5e"\
+                "g_ether.host_addr=02:04:25:aa:55:5f"

This is here for linux connection with PC via USB ethernet gadget. I'd like static IP for this connection but if there is random MAC addr I must set up IP again and again. Is another solution for this?

I have this in my /etc/network/interfaces on host:

---8<---
allow-hotplug usb0
iface usb0 inet static

	address 192.168.50.2
	netmask 255.255.255.0
	broadcast 192.168.50.255
	network 192.168.50.0

--->8---

And something other, hard coded in in embedded firmware config. This works like a charm with changing MAC for usb gadget.

Best regards

Andreas Bie?mann

#4 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

In reply to Jiří Prchal

Dear Ji?? Prchal,

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines

This comment does not belong into the commit message - please move it to the comment section, i. e. below the "---" line.

I'm not sure if I even should number versions of this patch?

But this is mandatory, see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Quoted 10 lines
Quoted 4 lines

include/configs/cdu9g25.h line 180

Quoted 4 lines
include/configs/cdu9g25.h new file +4 -0
+#define CONFIG_BOOTARGS		"console=ttyS0,115200 ubi.mtd=root"\
+				"root=ubi0:root rootfstype=ubifs rw"\
+				"g_ether.dev_addr=02:04:25:aa:55:5e"\
+				"g_ether.host_addr=02:04:25:aa:55:5f"

This is here for linux connection with PC via USB ethernet gadget. I'd like static IP for this connection but if there is random MAC addr I must set up IP again and again. Is another solution for this?

Quoted 1 line
Quoted 1 line

+#define CONFIG_SERVERIP 10.0.1.1

Please help me with this:
I'd like to have board prepared for download images from TFTP server on address 10.0.1.1.

We do not allow static networkj configuations in the U-Boot binary image. what works for you, may be bad for others. It's especially bad when all boards using the same image come p using the same MAC (or IP) addresses.

Quoted 1 line

Is there other way how to do it? Even with MAC addr, I solved it with random MAC, is that OK? I keep in mind that would

No. The image must not contain any static network addresses.

Quoted 1 line

be nice read unique serial number from F-RAM (is on boart too) on SPI and use it as MAC addr. Will be this way better?

There are many ways how to initialize the MAC address on the system during production or by reading any form of product information from EEPROM or F-RAM or whatever you have on your board. This is OK, as long as boards get assigned correct (i. e. different) addresses.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HANDLE WITH EXTREME CARE:  This Product Contains  Minute Electrically
Charged  Particles  Moving  at  Velocities  in Excess of Five Hundred
Million Miles Per Hour.
#5 lore raw

PATCH 1/1 Subject: [PATCH v.2] at91: add support for CDU9G25 board

Hi Wolfgang,

Dne 11.9.2013 00:52, Wolfgang Denk napsal(a):

Quoted 17 lines

Dear Ji?? Prchal,

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines

This comment does not belong into the commit message - please move it to the comment section, i. e. below the "---" line.

I'm not sure if I even should number versions of this patch?

But this is mandatory, see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

Quoted 6 lines
Quoted 4 lines

include/configs/cdu9g25.h line 180

Quoted 4 lines
include/configs/cdu9g25.h new file +4 -0
+#define CONFIG_BOOTARGS		"console=ttyS0,115200 ubi.mtd=root"\
+				"root=ubi0:root rootfstype=ubifs rw"\
+				"g_ether.dev_addr=02:04:25:aa:55:5e"\
+				"g_ether.host_addr=02:04:25:aa:55:5f"

This is here for linux connection with PC via USB ethernet gadget. I'd like static IP for this connection but if there is random MAC addr I must set up IP again and again. Is another solution for this?

I will remove this.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

+#define CONFIG_SERVERIP 10.0.1.1

Please help me with this:
I'd like to have board prepared for download images from TFTP server on address 10.0.1.1.

We do not allow static networkj configuations in the U-Boot binary image. what works for you, may be bad for others. It's especially bad when all boards using the same image come p using the same MAC (or IP) addresses.

I thought that this is default configuration of serverip. Does not affect network communication. And user can change it any time.

Quoted 11 lines
Quoted 2 lines

Is there other way how to do it? Even with MAC addr, I solved it with random MAC, is that OK? I keep in mind that would

No. The image must not contain any static network addresses.

Quoted 1 line

be nice read unique serial number from F-RAM (is on boart too) on SPI and use it as MAC addr. Will be this way better?

There are many ways how to initialize the MAC address on the system during production or by reading any form of product information from EEPROM or F-RAM or whatever you have on your board. This is OK, as long as boards get assigned correct (i. e. different) addresses.

I'll try use F-RAM for MAC, but it will take some time. Can I post patch now with random MAC and sometime in the future post another patch with F-RAM?

Thanks,
Jiri