Skip to contentSkip to conversation

powerpc/p2041: fix I2C controller's offset

PATCH New Shaohui Xie 4 participants 4 messages Sep 10, 2013 – Sep 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/p2041: fix I2C controller's offset

Without this patch, SPD access will fail which leads to DDR init fail.

---
 include/configs/P2041RDB.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/P2041RDB.h +2 -2
index 905bacf..862614b 100644
@@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_I2C_FSL
 #define CONFIG_SYS_FSL_I2C_SPEED	400000
 #define CONFIG_SYS_FSL_I2C_SLAVE	0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET	0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET	0x118000
 #define CONFIG_SYS_FSL_I2C2_SPEED	400000
 #define CONFIG_SYS_FSL_I2C2_SLAVE	0x7F
-#define CONFIG_SYS_FSL_I2C2_OFFSET	0x3100
+#define CONFIG_SYS_FSL_I2C2_OFFSET	0x118100
 
 /*
  * RapidIO
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 powerpc/p2041: fix I2C controller's offset

Hi Xie,

Quoted 25 lines · Shaohui Xie

Without this patch, SPD access will fail which leads to DDR init fail.

---
 include/configs/P2041RDB.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/P2041RDB.h +2 -3
index 905bacf..862614b 100644
@@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_I2C_FSL
 #define CONFIG_SYS_FSL_I2C_SPEED       400000
 #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET      0x118000
 #define CONFIG_SYS_FSL_I2C2_SPEED      400000
 #define CONFIG_SYS_FSL_I2C2_SLAVE      0x7F
-#define CONFIG_SYS_FSL_I2C2_OFFSET     0x3100
+#define CONFIG_SYS_FSL_I2C2_OFFSET     0x118100
 
 /*
  * RapidIO
--
Quoted 2 lines

1.7.0.4

Yes that appears to fix the problem. Thanks for the quick turn around.

#2 lore raw

PATCH 1/1 powerpc/p2041: fix I2C controller's offset

Quoted 33 lines · Chris Packham

Hi Xie,

Quoted 25 lines · Shaohui Xie

Without this patch, SPD access will fail which leads to DDR init fail.

---
 include/configs/P2041RDB.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/P2041RDB.h +2 -3
index 905bacf..862614b 100644
@@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_I2C_FSL
 #define CONFIG_SYS_FSL_I2C_SPEED       400000
 #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET      0x118000
 #define CONFIG_SYS_FSL_I2C2_SPEED      400000
 #define CONFIG_SYS_FSL_I2C2_SLAVE      0x7F
-#define CONFIG_SYS_FSL_I2C2_OFFSET     0x3100
+#define CONFIG_SYS_FSL_I2C2_OFFSET     0x118100
 
 /*
  * RapidIO
--
Quoted 2 lines

1.7.0.4

Yes that appears to fix the problem. Thanks for the quick turn around.

Quoted 2 lines

Thanks for the feedback. I will take it in u-boot-mpc85xx.

York

#3 lore raw

PATCH 1/1 powerpc/p2041: fix I2C controller's offset

Hello York,

Am 10.09.2013 23:14, schrieb York Sun:

Quoted 10 lines · Chris Packham
Quoted 9 lines

Hi Xie,

Quoted 6 lines · Shaohui Xie

Without this patch, SPD access will fail which leads to DDR init fail.

---
  include/configs/P2041RDB.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks for this fix!

Quoted 23 lines
Quoted 23 lines
Quoted 18 lines
include/configs/P2041RDB.h +2 -3
index 905bacf..862614b 100644
@@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
  #define CONFIG_SYS_I2C_FSL
  #define CONFIG_SYS_FSL_I2C_SPEED       400000
  #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET      0x118000
  #define CONFIG_SYS_FSL_I2C2_SPEED      400000
  #define CONFIG_SYS_FSL_I2C2_SLAVE      0x7F
-#define CONFIG_SYS_FSL_I2C2_OFFSET     0x3100
+#define CONFIG_SYS_FSL_I2C2_OFFSET     0x118100
 
  /*
   * RapidIO
--
Quoted 2 lines

1.7.0.4

Yes that appears to fix the problem. Thanks for the quick turn around.

Quoted 1 line
Quoted 1 line

Thanks for testing.

Quoted 1 line

Thanks for the feedback. I will take it in u-boot-mpc85xx.

Ah, Ok, I am fine with this, so:

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany