Skip to contentSkip to conversation

Add Ether DT support for R8A7778/BOCK-W reference board

PATCH New Sergei Shtylyov 4 participants 17 messages Sep 7, 2013 – Oct 17, 2013

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover Add Ether DT support for R8A7778/BOCK-W reference board

Hello.

Here's the set of 4 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20130906' tag. Here we add the Ether device tree support working on the R8A7778/BOCK-W reference board. The patchset requires the 'sh_eth' driver device tree support posted earlier in order to work.

[1/4] ARM: shmobile: r8a7778: add Ether DT support [2/4] ARM: shmobile: r8a7778: add Ether clock for DT case [3/4] ARM: shmobile: bockw-reference: add Ether DT support [4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings

WBR, Sergei

#1 lore raw

PATCH v2 1/4 ARM: shmobile: r8a7778: add Ether DT support

Define the generic R8A7778 part of the Ether device node.

---
Changes in version 2:
- changed the "compatible" property to "renesas,ether-r8a7778".

 arch/arm/boot/dts/r8a7778.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/r8a7778.dtsi +11 -0
Index: renesas/arch/arm/boot/dts/r8a7778.dtsi
===================================================================
@@ -98,4 +98,15 @@
 		reg = <0xfffc000 0x118>;
 		#gpio-range-cells = <3>;
 	};
+
+	ether: ethernet at fde00000 {
+		device_type = "network";
+		compatible = "renesas,ether-r8a7778";
+		reg = <0xfde00000 0x400>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 105 0x4>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
 };
#2 lore raw

PATCH v2 2/4 ARM: shmobile: r8a7778: add Ether clock for DT case

In reply to Sergei Shtylyov

Add extra Ether clock lookup entry in the device tree case.

---
Changes in version 2:
- refreshed the patch.

 arch/arm/mach-shmobile/clock-r8a7778.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/clock-r8a7778.c +1 -0
Index: renesas/arch/arm/mach-shmobile/clock-r8a7778.c
===================================================================
@@ -174,6 +174,7 @@ static struct clk_lookup lookups[] = {
 	CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP322]), /* SDHI1 */
 	CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP321]), /* SDHI2 */
 	CLKDEV_DEV_ID("r8a777x-ether", &mstp_clks[MSTP114]), /* Ether */
+	CLKDEV_DEV_ID("fde00000.ethernet", &mstp_clks[MSTP114]), /* Ether w/DT */
 	CLKDEV_DEV_ID("ehci-platform", &mstp_clks[MSTP100]), /* USB EHCI port0/1 */
 	CLKDEV_DEV_ID("ohci-platform", &mstp_clks[MSTP100]), /* USB OHCI port0/1 */
 	CLKDEV_DEV_ID("renesas_usbhs", &mstp_clks[MSTP100]), /* USB FUNC */
#3 lore raw

PATCH v2 3/4 ARM: shmobile: bockw-reference: add Ether DT support

In reply to Sergei Shtylyov

Define the BOCK-W board dependent part of the Ether device node.

---
 arch/arm/boot/dts/r8a7778-bockw-reference.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/r8a7778-bockw-reference.dts +11 -0
Index: renesas/arch/arm/boot/dts/r8a7778-bockw-reference.dts
===================================================================
@@ -30,3 +30,14 @@
 		reg = <0x60000000 0x10000000>;
 	};
 };
+
+&ether {
+	status = "ok";
+	phy-mode = "rmii";
+	phy-handle = <&phy1>;
+	renesas,no-ether-link;
+
+	phy1: ethernet-phy at 1 {
+		reg = <1>;
+	};
+};
#4 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

In reply to Sergei Shtylyov

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+	/* Ether */
+	PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+				  "ether_rmii", "ether"),
 	/* SCIF0 */
 	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
 				  "scif0_data_a", "scif0"),
maintainer
#5 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 13 lines · Sergei Shtylyov

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Cheers,

/ magnus

#6 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Hello.

Quoted 25 lines · Magnus Damm
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
  arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
  1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
   */
 
  static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
         /* SCIF0 */
         PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                   "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

No, I just repeated what I saw mechanically. Now I'm seeing some evidence
that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Quoted 3 lines

Cheers,

/ magnus

WBR, Sergei

#7 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 36 lines · Sergei Shtylyov

Hello.

Quoted 25 lines · Magnus Damm
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

#8 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Hello.

Quoted 32 lines · Simon Horman
Quoted 31 lines
Quoted 31 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
  arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
  1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
   */
 
  static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
         /* SCIF0 */
         PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                   "scif0_data_a", "scif0"),

Hi Sergei,

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 5 lines
Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

WBR, Sergei

#9 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 40 lines · Sergei Shtylyov

Hello.

Quoted 35 lines · Simon Horman
Quoted 35 lines
Quoted 25 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Quoted 6 lines
Quoted 1 line

Ping.

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

#10 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Hello.

Quoted 38 lines · Simon Horman
Quoted 37 lines
Quoted 37 lines
Quoted 32 lines
Quoted 25 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
  arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
  1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
   */
 
  static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
         /* SCIF0 */
         PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                   "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

Quoted 8 lines
Quoted 4 lines

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

Do you mean we should grant Stephen's requests concerning clock DT support
before we add the DT support to the driver?

WBR, Sergei

#11 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 47 lines · Sergei Shtylyov

Hello.

Quoted 42 lines · Simon Horman
Quoted 42 lines
Quoted 32 lines
Quoted 31 lines
Quoted 31 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 5 lines
Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Quoted 6 lines
Quoted 3 lines

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

Do you mean we should grant Stephen's requests concerning clock
DT support before we add the DT support to the driver?

That seems like the most logical way forwards to me.

Is the main issue that the clocks aren't accessible via DT at this time?

#12 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Hello.

On 09/27/2013 08:38 AM, Simon Horman wrote:

Sorry for the very late reply: I was busy with other stuff and then had ~2
weeks of vacations...

Quoted 43 lines
Quoted 42 lines
Quoted 42 lines
Quoted 42 lines
Quoted 32 lines
Quoted 31 lines
Quoted 31 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
  arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
  1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
   */
 
  static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
         /* SCIF0 */
         PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                   "scif0_data_a", "scif0"),

Hi Sergei,

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 5 lines
Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

Do you mean we should grant Stephen's requests concerning clock
DT support before we add the DT support to the driver?

That seems like the most logical way forwards to me.

Why? Why R-Car I2C driver device tree support was accepted without this,
although the driver uses clocks directly? Why such discrimination is applied only to the Ethernet driver?

Quoted 1 line

Is the main issue that the clocks aren't accessible via DT at this time?

In the eyes of Stephen, yes.

WBR, Sergei

#13 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 54 lines · Sergei Shtylyov

Hello.

On 09/27/2013 08:38 AM, Simon Horman wrote:

Sorry for the very late reply: I was busy with other stuff and
then had ~2 weeks of vacations...

Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 36 lines
Quoted 35 lines
Quoted 35 lines
Quoted 25 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Quoted 6 lines
Quoted 1 line

Ping.

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Do you mean we should grant Stephen's requests concerning clock
DT support before we add the DT support to the driver?

That seems like the most logical way forwards to me.

Why? Why R-Car I2C driver device tree support was accepted
without this, although the driver uses clocks directly? Why such discrimination is applied only to the Ethernet driver?

That is a good point. Have you made it to Stephen.

My point was to point out where I feel the path of least resistance is and thus a possible avenue for you to pursue. The exact path you take to reach your goal isn't of particular interest to me. What is of interest to me is that you get there somehow :)

Quoted 3 lines
Quoted 1 line

Is the main issue that the clocks aren't accessible via DT at this time?

In the eyes of Stephen, yes.

Thanks, to be honest I was not entirely clear about this.

#14 lore raw

PATCH v2 4/4 ARM: shmobile: BOCK-W reference: add Ether PFC settings

Quoted 58 lines · Simon Horman
Quoted 57 lines · Sergei Shtylyov

Hello.

On 09/27/2013 08:38 AM, Simon Horman wrote:

Sorry for the very late reply: I was busy with other stuff and
then had ~2 weeks of vacations...

Quoted 49 lines
Quoted 49 lines
Quoted 38 lines
Quoted 37 lines
Quoted 37 lines
Quoted 32 lines
Quoted 25 lines
Quoted 13 lines

Add the Ether pin group to bockw_pinctrl_map[].

---
 arch/arm/mach-shmobile/board-bockw-reference.c |    3 +++
 1 file changed, 3 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================

arch/arm/mach-shmobile/board-bockw-reference.c line 37

Quoted 9 lines
arch/arm/mach-shmobile/board-bockw-reference.c +3 -0
@@ -29,6 +29,9 @@
  */
 
 static const struct pinctrl_map bockw_pinctrl_map[] = {
+       /* Ether */
+       PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+                                 "ether_rmii", "ether"),
        /* SCIF0 */
        PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
                                  "scif0_data_a", "scif0"),

Hi Sergei,

Quoted 6 lines

Thanks for your patches. In general I think your series looks fine. I have a single comment, and that's about the pinctrl-related hunk above. I can see that this patch is for DT reference for Bock-W, so I expect the code to be in DT. Do you have any plans to use DT to describe the pinmux bits? Perhaps you have some incremental patch planned?

Quoted 3 lines

No, I just repeated what I saw mechanically. Now I'm seeing some
evidence that PFC driver supports the device tree, so I probably need to redo the patchset... let me study this question better.

Ping.

Quoted 8 lines
Quoted 4 lines

Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the driver DT support patch have seemingly stalemated due to the most recent comments...

Thanks for the update.

I guess the key is to move forward on the driver side, somehow.

Do you mean we should grant Stephen's requests concerning clock
DT support before we add the DT support to the driver?

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

That seems like the most logical way forwards to me.

Why? Why R-Car I2C driver device tree support was accepted
without this, although the driver uses clocks directly? Why such discrimination is applied only to the Ethernet driver?

That is a good point. Have you made it to Stephen.

I see in the next email in my inbox that you now have. Thanks.

Quoted 16 lines

My point was to point out where I feel the path of least resistance is and thus a possible avenue for you to pursue. The exact path you take to reach your goal isn't of particular interest to me. What is of interest to me is that you get there somehow :)

Quoted 3 lines
Quoted 1 line

Is the main issue that the clocks aren't accessible via DT at this time?

In the eyes of Stephen, yes.

Thanks, to be honest I was not entirely clear about this. --
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#15 lore raw

v2 cover Add Ether DT support for R8A7778/BOCK-W reference board

In reply to Sergei Shtylyov
Quoted 6 lines · Sergei Shtylyov

Hello.

Here's the set of 4 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20130906' tag. Here we add the Ether device tree support working on the R8A7778/BOCK-W reference board. The patchset requires the 'sh_eth' driver device tree support posted earlier in order to work.

These patches seem fine to me.
Magnus, Morimoto-san, do you have any feedback?

Assuming that is a run-time dependency I think I can go ahead and queue these up for v3.13 once they are reviewed.

Quoted 8 lines

[1/4] ARM: shmobile: r8a7778: add Ether DT support [2/4] ARM: shmobile: r8a7778: add Ether clock for DT case [3/4] ARM: shmobile: bockw-reference: add Ether DT support [4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings

WBR, Sergei

#16 lore raw

v2 cover Add Ether DT support for R8A7778/BOCK-W reference board

Hi Simon

Quoted 7 lines
Quoted 4 lines

Here's the set of 4 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20130906' tag. Here we add the Ether device tree support working on the R8A7778/BOCK-W reference board. The patchset requires the 'sh_eth' driver device tree support posted earlier in order to work.

These patches seem fine to me.
Magnus, Morimoto-san, do you have any feedback?

I have no objection

Best regards
---
Kuninori Morimoto