Skip to contentSkip to conversation

linux: update depmod path for install to target

PATCH New Ryan Coe 3 participants 6 messages Sep 10, 2013 – Sep 11, 2013 1 message not in the archive

lore
Share & tools
lore

Ryan Coe

author
#0 lore raw

PATCH 1/1 linux: update depmod path for install to target

---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
index 649d06b..1650143 100644
@@ -274,7 +274,7 @@ define LINUX_INSTALL_TARGET_CMDS
 	# directories, not relevant on the target
 	@if grep -q "CONFIG_MODULES=y" $(@D)/.config; then 	\
 		$(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
-			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
+			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\
 		rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/build ;		\
 		rm -f $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/source ;	\
 	fi
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 linux: update depmod path for install to target

Dear Ryan Coe,

linux/linux.mk define LINUX_INSTALL_TARGET_CMDS · line 277

Quoted 3 lines · Ryan Coe
linux/linux.mk +1 -1
 		$(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
-			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
+			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\

Not sure why we have to pass DEPMOD here since it's already part of LINUX_MAKE_FLAGS. Am I missing something?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 linux: update depmod path for install to target

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Dear Ryan Coe,

Quoted 3 lines · Ryan Coe

linux/linux.mk define LINUX_INSTALL_TARGET_CMDS · line 277

Quoted 3 lines

$(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) \

linux/linux.mk +1 -1
-			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
+			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\

Thomas> Not sure why we have to pass DEPMOD here since it's already part of Thomas> LINUX_MAKE_FLAGS. Am I missing something?

No, I think you're right. I've removed it in git.

Thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#3 lore raw

PATCH 1/1 linux: update depmod path for install to target

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/[email protected]> writes:

  Thomas> Dear Ryan Coe,
  Thomas> On Tue, 10 Sep 2013 14:58:35 -0700, Ryan Coe wrote:
  >> $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) 		\
  >> -			DEPMOD="$(HOST_DIR)/usr/sbin/depmod" modules_install ;		\
  >> +			DEPMOD="$(HOST_DIR)/sbin/depmod" modules_install ;		\
Quoted 7 lines

Thomas> Not sure why we have to pass DEPMOD here since it's already part of Thomas> LINUX_MAKE_FLAGS. Am I missing something?

No, I think you're right. I've removed it in git.

Thanks.

Without the depmod in the target install, I do not get the necessary files installed to the target. I am unable to load modules until I manually run depmod -a.

#4 lore raw

PATCH 1/1 linux: update depmod path for install to target

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ryan" == Ryan Coe <[email protected]> writes:

Hi,

Ryan> Without the depmod in the target install, I do not get the necessary Ryan> files installed to the target. I am unable to load modules until I Ryan> manually run depmod -a.

Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod, so we ended up passing 2x DEPMOD= to modules_install.

Signature · 1 line
Bye, Peter Korsgaard

A message that is not in the archive (sent off-list or not yet received): CANbLAv=Z6t7RuxrRm+uodNS55WXSKt1Raui8XLcQyoMjqk6mkw@mail.gmail.com

author
#6 lore raw

PATCH 1/1 linux: update depmod path for install to target

Quoted 17 lines · Ryan Coe

I will try it without the second instance and report back.

Quoted 1 line · On Sep 11, 2013 7:20 AM, "Peter Korsgaard" <[email protected]…
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ryan" == Ryan Coe <[email protected]

<mailto:[email protected]>> writes:

Hi,

Ryan> Without the depmod in the target install, I do not get the
necessary
Ryan> files installed to the target. I am unable to load modules
until I
Ryan> manually run depmod -a.

Quoted 6 lines

Really? LINUX_MAKE_FLAGS expands to .. DEPMOD=$(HOST_DIR)/sbin/depmod, so we ended up passing 2x DEPMOD= to modules_install.

--
Bye, Peter Korsgaard

I can confirm that this does work. The second time that depmod was
passed was causing trouble.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130911/8c1d3b3b/attachment.html>