Skip to contentSkip to conversation

makedumpfile: show needed memory

PATCH In review Cliff Wickman 2 participants 2 messages Aug 28, 2013 – Sep 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 makedumpfile: show needed memory

From: Cliff Wickman <[email protected]>

If there is not enough memory available to run in cyclic mode display how much more would be needed to do so.

Diffed against makedumpfile-1.5.4

---
 makedumpfile.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
makedumpfile.c +6 -2
Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================
@@ -7778,11 +7778,15 @@ plenty_of_memory(void)
 {
 	unsigned long free_size;
 	unsigned long needed_size;
+	long slack = 10; /* 10M extra */
+	long meg = 1024*1024;
 
 	free_size = get_free_memory_size();
-	needed_size = (info->max_mapnr * 2) / BITPERBYTE;
-	if (free_size > (needed_size + (10*1024*1024)))
+	needed_size = ((info->max_mapnr * 2) / BITPERBYTE) + (slack * meg);
+	if (free_size > needed_size)
 		return 1;
+	PROGRESS_MSG("Need %ldM more memory to use noncyclic mode.\n",
+		(needed_size - free_size)/meg);
 	return 0;
 }
 

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

Hello Cliff,

Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

If there is not enough memory available to run in cyclic mode display how much more would be needed to do so.

Diffed against makedumpfile-1.5.4

This patch depends on your "use non-cyclic when possible" and it was rejected, I'll reject this patch too.

Thanks
Atsushi Kumagai

Quoted 15 lines
---
  makedumpfile.c |    8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

Index: makedumpfile-1.5.4/makedumpfile.c
===================================================================

makedumpfile.c +2 -0
@@ -7778,11 +7778,15 @@ plenty_of_memory(void)
  {
  	unsigned long free_size;
  	unsigned long needed_size;
+	long slack = 10; /* 10M extra */
+	long meg = 1024*1024;
 

makedumpfile.c plenty_of_memory(void) · line 7791

Quoted 10 lines
makedumpfile.c +4 -2
  	free_size = get_free_memory_size();
-	needed_size = (info->max_mapnr * 2) / BITPERBYTE;
-	if (free_size > (needed_size + (10*1024*1024)))
+	needed_size = ((info->max_mapnr * 2) / BITPERBYTE) + (slack * meg);
+	if (free_size > needed_size)
  		return 1;
+	PROGRESS_MSG("Need %ldM more memory to use noncyclic mode.\n",
+		(needed_size - free_size)/meg);
  	return 0;
  }

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec