clk: bcm2835: Remove duplicate inclusion of clk-provider.h
Subsystems (11)
PATCH 1/10 clk: bcm2835: Remove duplicate inclusion of clk-provider.h
clk-provider.h was included twice.
--- drivers/clk/clk-bcm2835.c | 1 - 1 file changed, 1 deletion(-)
drivers/clk/clk-bcm2835.c +0 -1
@@ -20,7 +20,6 @@#include <linux/clk-provider.h> #include <linux/clkdev.h> #include <linux/clk/bcm2835.h> -#include <linux/clk-provider.h> #include <linux/of.h> static const struct of_device_id clk_match[]__initconst = {
Signature · 1 line
1.7.9.5
PATCH 1/10 clk: bcm2835: Remove duplicate inclusion of clk-provider.h
Mike,
Quoted 21 lines · Sachin Kamat
clk-provider.hwas included twice.Signed-off-by Sachin Kamat <[email protected]>Cc Stephen Warren <[email protected]>--- drivers/clk/clk-bcm2835.c | 1 - 1 file changed, 1 deletion(-)drivers/clk/clk-bcm2835.c +0
-2@@ -20,7 +20,6 @@#include <linux/clk-provider.h> #include <linux/clkdev.h> #include <linux/clk/bcm2835.h> -#include <linux/clk-provider.h> #include <linux/of.h> static const struct of_device_id clk_match[]__initconst = { --
Quoted 2 lines
1.7.9.5
Gentle ping on this series.
Signature · 2 lines
With warm regards, Sachin
PATCH 1/10 clk: bcm2835: Remove duplicate inclusion of clk-provider.h
In reply to Sachin KamatHi Mike,
Quoted 21 lines · Sachin Kamat
clk-provider.hwas included twice.Signed-off-by Sachin Kamat <[email protected]>Cc Stephen Warren <[email protected]>--- drivers/clk/clk-bcm2835.c | 1 - 1 file changed, 1 deletion(-)drivers/clk/clk-bcm2835.c +0
-2@@ -20,7 +20,6 @@#include <linux/clk-provider.h> #include <linux/clkdev.h> #include <linux/clk/bcm2835.h> -#include <linux/clk-provider.h> #include <linux/of.h> static const struct of_device_id clk_match[]__initconst = { --
Quoted 2 lines
1.7.9.5
Gentle ping.
Signature · 2 lines
With warm regards, Sachin
PATCH 1/10 clk: bcm2835: Remove duplicate inclusion of clk-provider.h
In reply to Sachin KamatMike,
Quoted 21 lines · Sachin Kamat
clk-provider.hwas included twice.Signed-off-by Sachin Kamat <[email protected]>Cc Stephen Warren <[email protected]>--- drivers/clk/clk-bcm2835.c | 1 - 1 file changed, 1 deletion(-)drivers/clk/clk-bcm2835.c +0
-2@@ -20,7 +20,6 @@#include <linux/clk-provider.h> #include <linux/clkdev.h> #include <linux/clk/bcm2835.h> -#include <linux/clk-provider.h> #include <linux/of.h> static const struct of_device_id clk_match[]__initconst = { --
Quoted 2 lines
1.7.9.5
This series is pending since a long time. Can you please look into it?
Signature · 2 lines
With warm regards, Sachin
PATCH 2/10 clk: SPEAr: Staticize clk_frac_ops
In reply to Sachin Kamatclk_frac_ops is local to this file. Make it static.
--- drivers/clk/spear/clk-frac-synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/clk-frac-synth.c +1 -1
@@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,return 0 ; } -struct clk_ops clk_frac_ops = { +static struct clk_ops clk_frac_ops = { .recalc_rate = clk_frac_recalc_rate, .round_rate = clk_frac_round_rate, .set_rate = clk_frac_set_rate,
Signature · 1 line
1.7.9.5
PATCH 2/10 clk: SPEAr: Staticize clk_frac_ops
Quoted 13 lines · Sachin Kamat
clk_frac_opsis local to this file. Make it static.Signed-off-by Sachin Kamat <[email protected]>Cc Viresh Kumar <[email protected]>--- drivers/clk/spear/clk-frac-synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/spear/clk-frac-synth.c +0
-0
drivers/clk/spear/clk-frac-synth.c static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate, · line 122
Quoted 8 lines
drivers/clk/spear/clk-frac-synth.c +1
-1@@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,return 0 ; } -struct clk_ops clk_frac_ops = { +static struct clk_ops clk_frac_ops = { .recalc_rate = clk_frac_recalc_rate, .round_rate = clk_frac_round_rate, .set_rate = clk_frac_set_rate,
PATCH 3/10 clk: tegra: Staticize local variables in clk-pll.c
In reply to Sachin KamatLocal variables used only in this file are made static.
--- drivers/clk/tegra/clk-pll.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/clk/tegra/clk-pll.c +5 -5
@@ -1340,7 +1340,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name, }#ifdef CONFIG_ARCH_TEGRA_114_SOC -const struct clk_ops tegra_clk_pllxc_ops = { +static const struct clk_ops tegra_clk_pllxc_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable,
@@ -1349,7 +1349,7 @@ const struct clk_ops tegra_clk_pllxc_ops = { .set_rate = clk_pllxc_set_rate, }; -const struct clk_ops tegra_clk_pllm_ops = { +static const struct clk_ops tegra_clk_pllm_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable,
@@ -1358,7 +1358,7 @@ const struct clk_ops tegra_clk_pllm_ops = { .set_rate = clk_pllm_set_rate, }; -const struct clk_ops tegra_clk_pllc_ops = { +static const struct clk_ops tegra_clk_pllc_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pllc_enable, .disable = clk_pllc_disable,
@@ -1367,7 +1367,7 @@ const struct clk_ops tegra_clk_pllc_ops = { .set_rate = clk_pllc_set_rate, }; -const struct clk_ops tegra_clk_pllre_ops = { +static const struct clk_ops tegra_clk_pllre_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_pll_iddq_enable, .disable = clk_pll_iddq_disable,
@@ -1376,7 +1376,7 @@ const struct clk_ops tegra_clk_pllre_ops = { .set_rate = clk_pllre_set_rate, }; -const struct clk_ops tegra_clk_plle_tegra114_ops = { +static const struct clk_ops tegra_clk_plle_tegra114_ops = { .is_enabled = clk_pll_is_enabled, .enable = clk_plle_tegra114_enable, .disable = clk_plle_tegra114_disable,
Signature · 1 line
1.7.9.5
PATCH 4/10 clk: tegra: Staticize tegra_clk_periph_nodiv_ops
In reply to Sachin Kamattegra_clk_periph_nodiv_ops is used only in this file. Make it static.
--- drivers/clk/tegra/clk-periph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-periph.c +1 -1
@@ -162,7 +162,7 @@ const struct clk_ops tegra_clk_periph_ops = { .disable = clk_periph_disable, }; -const struct clk_ops tegra_clk_periph_nodiv_ops = { +static const struct clk_ops tegra_clk_periph_nodiv_ops = { .get_parent = clk_periph_get_parent, .set_parent = clk_periph_set_parent, .is_enabled = clk_periph_is_enabled,
Signature · 1 line
1.7.9.5
PATCH 5/10 clk: socfpga: Use NULL instead of 0
In reply to Sachin Kamat'div_reg' is a pointer. Assign NULL instead of 0.
--- drivers/clk/socfpga/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/socfpga/clk.c +1 -1
@@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node, socfpga_clk->shift = div_reg[1 ]; socfpga_clk->width = div_reg[2 ]; }else { - socfpga_clk->div_reg =0 ; + socfpga_clk->div_reg =NULL ; }of_property_read_string (node,"clock-output-names" , &clk_name);
Signature · 1 line
1.7.9.5
PATCH 5/10 clk: socfpga: Use NULL instead of 0
Quoted 13 lines · Sachin Kamat
'
div_reg' is a pointer. Assign NULL instead of 0.Signed-off-by Sachin Kamat <[email protected]>Cc Dinh Nguyen <[email protected]>--- drivers/clk/socfpga/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/socfpga/clk.c +0
-0
drivers/clk/socfpga/clk.c static void __init socfpga_gate_clk_init(struct device_node *node, · line 298
Quoted 8 lines
drivers/clk/socfpga/clk.c +1
-1@@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node, socfpga_clk->shift = div_reg[1 ]; socfpga_clk->width = div_reg[2 ]; }else { - socfpga_clk->div_reg =0 ; + socfpga_clk->div_reg =NULL ; }of_property_read_string (node,"clock-output-names" , &clk_name);
PATCH 6/10 clk: versatile: Staticize clk_sp810_timerclken_of_get
In reply to Sachin Kamatclk_sp810_timerclken_of_get is used only in this file. Make it static.
--- drivers/clk/versatile/clk-sp810.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/versatile/clk-sp810.c +1 -1
@@ -123,7 +123,7 @@ static const struct clk_ops clk_sp810_timerclken_ops = { .set_parent = clk_sp810_timerclken_set_parent, }; -struct clk *clk_sp810_timerclken_of_get (struct of_phandle_args *clkspec, +static struct clk *clk_sp810_timerclken_of_get (struct of_phandle_args *clkspec,void *data) {struct clk_sp810 *sp810 = data;
Signature · 1 line
1.7.9.5
PATCH 7/10 clk: mvebu: Staticize of_cpu_clk_setup
In reply to Sachin Kamat'of_cpu_clk_setup' is used only in this file. Make it static.
--- drivers/clk/mvebu/clk-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/mvebu/clk-cpu.c +1 -1
@@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = { .set_rate = clk_cpu_set_rate, }; -void __init of_cpu_clk_setup (struct device_node *node) +static void __init of_cpu_clk_setup (struct device_node *node) {struct cpu_clk *cpuclk;void __iomem *clock_complex_base =of_iomap (node,0 );
Signature · 1 line
1.7.9.5
PATCH 7/10 clk: mvebu: Staticize of_cpu_clk_setup
Quoted 4 lines · Sachin Kamat
'
of_cpu_clk_setup' is used only in this file. Make it static.Signed-off-by Sachin Kamat <[email protected]>Cc Gregory CLEMENT <[email protected]>
Good catch, it should have been part of the "f640c0f clk: mvebu: Use common of_clk_init() function" commit.
Quoted 18 lines
--- drivers/clk/mvebu/clk-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/mvebu/clk-cpu.c +1
-1@@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = { .set_rate = clk_cpu_set_rate, }; -void __init of_cpu_clk_setup (struct device_node *node) +static void __init of_cpu_clk_setup (struct device_node *node) {struct cpu_clk *cpuclk;void __iomem *clock_complex_base =of_iomap (node,0 );
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 8/10 clk: vt8500: Staticize vtwm_pll_ops
In reply to Sachin Kamat'vtwm_pll_ops' is local to this file. Make it static.
--- drivers/clk/clk-vt8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-vt8500.c +1 -1
@@ -620,7 +620,7 @@ static unsigned long vtwm_pll_recalc_rate(struct clk_hw *hw,return pll_freq; } -const struct clk_ops vtwm_pll_ops = { +static const struct clk_ops vtwm_pll_ops = { .round_rate = vtwm_pll_round_rate, .set_rate = vtwm_pll_set_rate, .recalc_rate = vtwm_pll_recalc_rate,
Signature · 1 line
1.7.9.5
PATCH 9/10 clk: ux500: Remove extra semicolon
In reply to Sachin KamatExtra semicolon is redundant. Remove it.
--- drivers/clk/ux500/clk-prcmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/ux500/clk-prcmu.c +1 -1
@@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)if (!ret) clk->is_prepared =1 ; -return ret;; +return ret; }static void clk_prcmu_unprepare (struct clk_hw *hw)
Signature · 1 line
1.7.9.5
PATCH 9/10 clk: ux500: Remove extra semicolon
Quoted 22 lines · Sachin Kamat
Extra semicolon is redundant. Remove it.
Signed-off-by Sachin Kamat <[email protected]>Cc Ulf Hansson <[email protected]>--- drivers/clk/ux500/clk-prcmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/ux500/clk-prcmu.c +1
-2@@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)if (!ret) clk->is_prepared =1 ; -return ret;; +return ret; }static void clk_prcmu_unprepare (struct clk_hw *hw) --
Quoted 2 lines
1.7.9.5
PATCH 10/10 clk: max77686: Remove redundant break
In reply to Sachin Kamat'break' after 'goto' is redundant. Remove it.
--- drivers/clk/clk-max77686.c | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/clk-max77686.c +0 -2
@@ -157,11 +157,9 @@ static int max77686_clk_probe(struct platform_device *pdev)case MAX77686_CLK_AP :dev_err (&pdev->dev,"Fail to register CLK_AP\n" ); goto err_clk_ap; -break ;case MAX77686_CLK_CP :dev_err (&pdev->dev,"Fail to register CLK_CP\n" ); goto err_clk_cp; -break ;case MAX77686_CLK_PMIC :dev_err (&pdev->dev,"Fail to register CLK_PMIC\n" ); goto err_clk_pmic;
Signature · 1 line
1.7.9.5