Skip to contentSkip to conversation

drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

PATCH New Lorenzo Pieralisi 3 participants 5 messages Sep 13, 2013 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

---
 drivers/cpuidle/Kconfig.arm | 2 +-
 drivers/cpuidle/Makefile    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/cpuidle/Kconfig.arm +1 -1
index 8e36603..ea0f045 100644
@@ -27,7 +27,7 @@ config ARM_U8500_CPUIDLE
 	help
 	  Select this to enable cpuidle for ST-E u8500 processors
 
-config CPU_IDLE_BIG_LITTLE
+config ARM_BIG_LITTLE_CPUIDLE
 	bool "Support for ARM big.LITTLE processors"
 	depends on ARCH_VEXPRESS_TC2_PM
 	select ARM_CPU_SUSPEND
drivers/cpuidle/Makefile +1 -1
index cea5ef5..3c693c2 100644
@@ -11,4 +11,4 @@ obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE)	+= cpuidle-calxeda.o
 obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE)	+= cpuidle-kirkwood.o
 obj-$(CONFIG_ARM_ZYNQ_CPUIDLE)		+= cpuidle-zynq.o
 obj-$(CONFIG_ARM_U8500_CPUIDLE)         += cpuidle-ux500.o
-obj-$(CONFIG_CPU_IDLE_BIG_LITTLE)	+= cpuidle-big_little.o
+obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE)	+= cpuidle-big_little.o
Signature · 1 line
1.8.2.2
#1 lore raw

PATCH 1/1 drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

Hi Lorenzo,

Quoted 6 lines · Lorenzo Pieralisi

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

Do you also consider to reorder the entries in alphabetic order? It should help to reduce the merge conflict.

Regards,

Quoted 31 lines
---
 drivers/cpuidle/Kconfig.arm | 2 +-
 drivers/cpuidle/Makefile    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/cpuidle/Kconfig.arm +1 -1
index 8e36603..ea0f045 100644
@@ -27,7 +27,7 @@ config ARM_U8500_CPUIDLE
 	help
 	  Select this to enable cpuidle for ST-E u8500 processors
 
-config CPU_IDLE_BIG_LITTLE
+config ARM_BIG_LITTLE_CPUIDLE
 	bool "Support for ARM big.LITTLE processors"
 	depends on ARCH_VEXPRESS_TC2_PM
 	select ARM_CPU_SUSPEND
drivers/cpuidle/Makefile +1 -1
index cea5ef5..3c693c2 100644
@@ -11,4 +11,4 @@ obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE)	+= cpuidle-calxeda.o
 obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE)	+= cpuidle-kirkwood.o
 obj-$(CONFIG_ARM_ZYNQ_CPUIDLE)		+= cpuidle-zynq.o
 obj-$(CONFIG_ARM_U8500_CPUIDLE)         += cpuidle-ux500.o
-obj-$(CONFIG_CPU_IDLE_BIG_LITTLE)	+= cpuidle-big_little.o
+obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE)	+= cpuidle-big_little.o
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

Quoted 7 lines · Gregory CLEMENT

Hi Lorenzo,

Quoted 4 lines · Lorenzo Pieralisi

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

Quoted 5 lines
Quoted 2 lines

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

Do you also consider to reorder the entries in alphabetic order? It should help to reduce the merge conflict.

Sure, here it is, thanks for pointing that out.

Lorenzo

-- >8 --
Subject: [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and
makefile entries

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

---
 drivers/cpuidle/Kconfig.arm | 22 +++++++++++-----------
 drivers/cpuidle/Makefile    |  2 +-
 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/cpuidle/Kconfig.arm +11 -11
index 8e36603..6a7e6f2 100644
@@ -2,6 +2,17 @@
 # ARM CPU Idle drivers
 #
 
+config ARM_BIG_LITTLE_CPUIDLE
+	bool "Support for ARM big.LITTLE processors"
+	depends on ARCH_VEXPRESS_TC2_PM
+	select ARM_CPU_SUSPEND
+	select CPU_IDLE_MULTIPLE_DRIVERS
+	help
+	  Select this option to enable CPU idle driver for big.LITTLE based
+	  ARM systems. Driver manages CPUs coordination through MCPM and
+	  define different C-states for little and big cores through the
+	  multiple CPU idle drivers infrastructure.
+
 config ARM_HIGHBANK_CPUIDLE
 	bool "CPU Idle Driver for Calxeda processors"
 	depends on ARCH_HIGHBANK
@@ -26,14 +37,3 @@ config ARM_U8500_CPUIDLE
 	depends on ARCH_U8500
 	help
 	  Select this to enable cpuidle for ST-E u8500 processors
-
-config CPU_IDLE_BIG_LITTLE
-	bool "Support for ARM big.LITTLE processors"
-	depends on ARCH_VEXPRESS_TC2_PM
-	select ARM_CPU_SUSPEND
-	select CPU_IDLE_MULTIPLE_DRIVERS
-	help
-	  Select this option to enable CPU idle driver for big.LITTLE based
-	  ARM systems. Driver manages CPUs coordination through MCPM and
-	  define different C-states for little and big cores through the
-	  multiple CPU idle drivers infrastructure.
drivers/cpuidle/Makefile +1 -1
index cea5ef5..d08bd40 100644
@@ -7,8 +7,8 @@ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o
 
 ##################################################################################
 # ARM SoC drivers
+obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE)	+= cpuidle-big_little.o
 obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE)	+= cpuidle-calxeda.o
 obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE)	+= cpuidle-kirkwood.o
 obj-$(CONFIG_ARM_ZYNQ_CPUIDLE)		+= cpuidle-zynq.o
 obj-$(CONFIG_ARM_U8500_CPUIDLE)         += cpuidle-ux500.o
-obj-$(CONFIG_CPU_IDLE_BIG_LITTLE)	+= cpuidle-big_little.o
Signature · 1 line
1.8.2.2
#3 lore raw

PATCH 1/1 drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

Quoted 8 lines · Lorenzo Pieralisi
Quoted 7 lines · Gregory CLEMENT

Hi Lorenzo,

Quoted 4 lines · Lorenzo Pieralisi

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

Do you also consider to reorder the entries in alphabetic order? It should help to reduce the merge conflict.

Sure, here it is, thanks for pointing that out.

FYI, updated patches deep inside threads are very likely to be missed. I saw this because I was looking for it, but would've easily been missed.

Could you resend a v2 with my ack so Daniel can pick up and get it merged for v3.12-rc? Thanks

Kevin

#4 lore raw

PATCH 1/1 drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries

Quoted 13 lines · Kevin Hilman
Quoted 11 lines · Lorenzo Pieralisi
Quoted 10 lines · Gregory CLEMENT

Hi Lorenzo,

Quoted 6 lines · Lorenzo Pieralisi

Following the reorganization of CPU idle drivers configurations into an ARM specific Kconfig, the existing idle drivers Kconfig entries were renamed and moved to the Kconfig.arm file. Makefile entries were updated accordingly.

This patch renames the entries in Kconfig.arm and makefile to make the newly added big.LITTLE CPUidle driver compliant with the new naming convention.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Do you also consider to reorder the entries in alphabetic order? It should help to reduce the merge conflict.

Sure, here it is, thanks for pointing that out.

FYI, updated patches deep inside threads are very likely to be missed. I saw this because I was looking for it, but would've easily been missed.

Got it, thanks for that.

Quoted 2 lines

Could you resend a v2 with my ack so Daniel can pick up and get it merged for v3.12-rc? Thanks

Done.

Thank you,
Lorenzo