ARM: imx: i.mx6d/q: disable the double linefill feature of PL310
Subsystems (3)
PATCH 1/1 ARM: imx: i.mx6d/q: disable the double linefill feature of PL310
The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 But according to ARM PL310 errata: 752271
ID: 752271: Double linefill feature can cause data corruption Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2
Workaround: The only workaround to this erratum is to disable the double linefill feature. This is the default behavior.
without this patch, you will meet the following error when run the memtester application at: http://pyropus.ca/software/memtester/
FAILURE: 0x00100000 != 0x00200000 at offset 0x01365664.
FAILURE: 0x00100000 != 0x00200000 at offset 0x01365668.
FAILURE: 0x00100000 != 0x00200000 at offset 0x0136566c.
FAILURE: 0x00100000 != 0x00200000 at offset 0x01365670.
FAILURE: 0x00100000 != 0x00200000 at offset 0x01365674.
FAILURE: 0x00100000 != 0x00200000 at offset 0x01365678.
FAILURE: 0x00100000 != 0x00200000 at offset 0x0136567c.
--- arch/arm/mach-imx/system.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
arch/arm/mach-imx/system.c +12 -1
@@ -116,7 +116,18 @@ void __init imx_init_l2cache(void)/* Configure the L2 PREFETCH and POWER registers */ val =readl_relaxed (l2x0_base +L2X0_PREFETCH_CTRL ); - val |=0x70800000 ; + val |=0x30000000 ; +/* +* The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 +* The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 +* But according to ARM PL310 errata: 752271 +* ID: 752271: Double linefill feature can cause data corruption +* Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2 +* Workaround: The only workaround to this erratum is to disable the +* double linefill feature. This is the default behavior. +*/ +if (!of_machine_is_compatible ("fsl,imx6q" )) + val |=0x40800000 ;writel_relaxed (val, l2x0_base +L2X0_PREFETCH_CTRL ); val =L2X0_DYNAMIC_CLK_GATING_EN |L2X0_STNDBY_MODE_EN ;writel_relaxed (val, l2x0_base +L2X0_POWER_CTRL );
Signature · 1 line
1.7.10.4
PATCH 1/1 ARM: imx: i.mx6d/q: disable the double linefill feature of PL310
Am 13.09.2013 09:48, schrieb Jason Liu:
Quoted 35 lines
The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 But according to ARM PL310 errata: 752271
ID: 752271: Double linefill feature can cause data corruption Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2
Workaround: The only workaround to this erratum is to disable the double linefill feature. This is the default behavior.without this patch, you will meet the following error when run the memtester application at: http://pyropus.ca/software/memtester/
FAILURE:
0x00100000!=0x00200000at offset0x01365664.
FAILURE:0x00100000!=0x00200000at offset0x01365668.
FAILURE:0x00100000!=0x00200000at offset0x0136566c.
FAILURE:0x00100000!=0x00200000at offset0x01365670.
FAILURE:0x00100000!=0x00200000at offset0x01365674.
FAILURE:0x00100000!=0x00200000at offset0x01365678.
FAILURE:0x00100000!=0x00200000at offset0x0136567c.Signed-off-by Jason Liu <[email protected]>--- arch/arm/mach-imx/system.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)arch/arm/mach-imx/system.c +2
-1@@ -116,7 +116,18 @@ void __init imx_init_l2cache(void)/* Configure the L2 PREFETCH and POWER registers */ val =readl_relaxed (l2x0_base +L2X0_PREFETCH_CTRL ); - val |=0x70800000 ; + val |=0x30000000 ; +/*
arch/arm/mach-imx/system.c void __init imx_init_l2cache(void) · line 130
Quoted 10 lines
arch/arm/mach-imx/system.c +10
-0+* The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 +* The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 +* But according to ARM PL310 errata: 752271 +* ID: 752271: Double linefill feature can cause data corruption +* Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2 +* Workaround: The only workaround to this erratum is to disable the +* double linefill feature. This is the default behavior. +*/ +if (!of_machine_is_compatible ("fsl,imx6q" )) + val |=0x40800000 ;
I've been thinking about this issue some time, too. Therefore two questions:
* Why do you set the 0x8 in 0x40800000 only in the non-imx6q case here? This bit shouldn't be affected by the errata and therefore could be set in all cases?
* To make it more clear what we do here (and in case somebody, e.g. a boot loader?) has already set bit 30, I would do something like:
val |= 0x70800000;
if (!of_machine_is_compatible("fsl,imx6q"))
val &= ~(1 << 30);
What do you think?
Best regards
Dirk
PATCH 1/1 ARM: imx: i.mx6d/q: disable the double linefill feature of PL310
2013/9/14 Dirk Behme <[email protected]>:
Quoted 55 lines
Am 13.09.2013 09:48, schrieb Jason Liu:
Quoted 45 lines
The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 But according to ARM PL310 errata: 752271
ID: 752271: Double linefill feature can cause data corruption Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2
Workaround: The only workaround to this erratum is to disable the double linefill feature. This is the default behavior.without this patch, you will meet the following error when run the memtester application at: http://pyropus.ca/software/memtester/
FAILURE:
0x00100000!=0x00200000at offset0x01365664.
FAILURE:0x00100000!=0x00200000at offset0x01365668.
FAILURE:0x00100000!=0x00200000at offset0x0136566c.
FAILURE:0x00100000!=0x00200000at offset0x01365670.
FAILURE:0x00100000!=0x00200000at offset0x01365674.
FAILURE:0x00100000!=0x00200000at offset0x01365678.
FAILURE:0x00100000!=0x00200000at offset0x0136567c.Signed-off-by Jason Liu <[email protected]>--- arch/arm/mach-imx/system.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)arch/arm/mach-imx/system.c +3
-1@@ -116,7 +116,18 @@ void __init imx_init_l2cache(void)/* Configure the L2 PREFETCH and POWER registers */ val =readl_relaxed (l2x0_base +L2X0_PREFETCH_CTRL ); - val |=0x70800000 ; + val |=0x30000000 ; +/* +* The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0
+ * The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL
is r3p2arch/arm/mach-imx/system.c +3
-0+* But according to ARM PL310 errata: 752271 +* ID: 752271: Double linefill feature can cause data corruption +* Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2
+ * Workaround: The only workaround to this erratum is to disable
thearch/arm/mach-imx/system.c void __init imx_init_l2cache(void) · line 130
Quoted 4 lines
arch/arm/mach-imx/system.c +4
-0+* double linefill feature. This is the default behavior. +*/ +if (!of_machine_is_compatible ("fsl,imx6q" )) + val |=0x40800000 ;I've been thinking about this issue some time, too. Therefore two questions:
Quoted 3 lines
* Why do you set the
0x8in0x40800000only in the non-imx6q case here? This bit shouldn't be affected by the errata and therefore could be set in all cases?
I supposed that you means the bit 23 in the prefetch control register, by looking at the register definition:
[23] Incr double Linefill enable:
0 The L2CC does not issue INCR 8x64-bit read bursts to L3 on reads that miss in the L2 cache. This is the default. 1 The L2CC can issue INCR 8x64-bit read bursts to L3 on reads that miss in the L2 cache.
Since we need disable the double Linefill, we need disable this bit too on the i.MX6Q.
Quoted 7 lines
* To make it more clear what we do here (and in case somebody, e.g. a boot loader?) has already set bit 30, I would do something like:
val |=
0x70800000;
if (!of_machine_is_compatible("fsl,imx6q"))val &= ~(1 << 30);
val &= ~( 1 << 30 | 1 << 23);
Quoted 2 lines
What do you think?
Yes, this is better.
Jason Liu
Quoted 12 lines
Best regards
Dirk
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/1 ARM: imx: i.mx6d/q: disable the double linefill feature of PL310
In reply to Jason LiuJason,
Quoted 6 lines · Jason Liu
arch/arm/mach-imx/system.c +1
-1@@ -116,7 +116,18 @@ void __init imx_init_l2cache(void)/* Configure the L2 PREFETCH and POWER registers */ val =readl_relaxed (l2x0_base +L2X0_PREFETCH_CTRL ); - val |=0x70800000 ; + val |=0x30000000 ;
arch/arm/mach-imx/system.c void __init imx_init_l2cache(void) · line 129
Quoted 10 lines
arch/arm/mach-imx/system.c +10
-0+/* +* The L2 cache controller(PL310) version on the i.MX6D/Q is r3p1-50rel0 +* The L2 cache controller(PL310) version on the i.MX6DL/SOLO/SL is r3p2 +* But according to ARM PL310 errata: 752271 +* ID: 752271: Double linefill feature can cause data corruption +* Fault Status: Present in: r3p0, r3p1, r3p1-50rel0. Fixed in r3p2 +* Workaround: The only workaround to this erratum is to disable the +* double linefill feature. This is the default behavior. +*/ +if (!of_machine_is_compatible ("fsl,imx6q" ))
Can we use cpu_is_imx6q() here? I think we may not want to look at device tree, if the kernel can figure this out by itself.
Shawn
Quoted 8 lines
arch/arm/mach-imx/system.c +1
-0+ val |=0x40800000 ;writel_relaxed (val, l2x0_base +L2X0_PREFETCH_CTRL ); val =L2X0_DYNAMIC_CLK_GATING_EN |L2X0_STNDBY_MODE_EN ;writel_relaxed (val, l2x0_base +L2X0_POWER_CTRL );Signature · 1 line
1.7.10.4