LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3
v2 cover LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3
Change in V2: Add a check for linuxstdbase so it does not print out warnings
at other times.
*Problem
Build core-image-lsb for lsb test which doesn't include meta-qt layer, and there is a LSB 4.1 Library Check failure: unable to find library libqt-mt.so.3
//Hongxu
The following changes since commit dd36930f3f37b2e0e1258de28ac1b1fa99cf196f:
bitbake: data_smart: Account for changes in append/prepend/remove in the config hash (2013-09-12 17:03:17 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib hongxu/fix-lsb-libqt3
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-lsb-libqt3
Hongxu Jia (1):
LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ 1 file changed, 11 insertions(+)
Signature · 1 line
1.8.1.2
PATCH v2 1/1 LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3
The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop, and it locates in meta-qt3 layer.
So if meta-qt3 is not added, there should be a warning to call attention; if added, it will add libqt-mt to RDEPENDS.
[YOCTO #5153]
--- meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ 1 file changed, 11 insertions(+)
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +11 -0
@@ -193,6 +193,16 @@ RDEPENDS_packagegroup-core-lsb-python = "\ python-misc \ " +def get_libqt3(d): + if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "": + return 'libqt-mt3' + + if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "": + bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x') + bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is') + bb.warn('a requirement for LSB') + return '' + SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop" DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to support libraries \ specified in the LSB Desktop specification"
@@ -221,6 +231,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\ atk \ libasound \ ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \ + ${@get_libqt3(d)} \ " RDEPENDS_packagegroup-core-lsb-runtime-add = "\
Signature · 1 line
1.8.1.2
Quoted 17 lines · Hongxu Jia
The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop, and it locates in meta-qt3 layer.
So if meta-qt3 is not added, there should be a warning to call attention; if added, it will add libqt-mt to RDEPENDS.[YOCTO #5153]
Signed-off-by Hongxu Jia <[email protected]>--- meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ 1 file changed, 11 insertions(+)meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +0
-0
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb RDEPENDS_packagegroup-core-lsb-python = "\ · line 199
Quoted 7 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +4
-0@@ -193,6 +193,16 @@ RDEPENDS_packagegroup-core-lsb-python = "\ python-misc \ " +def get_libqt3(d): + if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "": + return 'libqt-mt3' +
I think this might cause unexpected behavoir for people who just happen to have qt3 in their bblayer, I would also wrap the linuxstdbase around the above line.
Sorry for not being clear about the first time.
Sau!
Quoted 18 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +7
-0+ if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "": + bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x') + bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is') + bb.warn('a requirement for LSB') + return '' + SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop" DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to support libraries \ specified in the LSB Desktop specification"@@ -221,6 +231,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\ atk \ libasound \ ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \ + ${@get_libqt3(d)} \ " RDEPENDS_packagegroup-core-lsb-runtime-add = "\
Quoted 22 lines · Saul Wold
Quoted 21 lines · Hongxu Jia
The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop, and it locates in meta-qt3 layer.
So if meta-qt3 is not added, there should be a warning to call attention; if added, it will add libqt-mt to RDEPENDS.[YOCTO #5153]
Signed-off-by Hongxu Jia <[email protected]>--- meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ 1 file changed, 11 insertions(+)meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +0
-0@@ -193,6 +193,16 @@ RDEPENDS_packagegroup-core-lsb-python = "\ python-misc \ "
Quoted 6 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb RDEPENDS_packagegroup-core-lsb-python = "\ · line 199
Quoted 4 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +4
-0+def get_libqt3(d): + if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "": + return 'libqt-mt3' +I think this might cause unexpected behavoir for people who just happen to have qt3 in their bblayer, I would also wrap the linuxstdbase around the above line.
Alright, I will let linuxstdbase move up
Thanks,
Hongxu
Quoted 26 lines
Sorry for not being clear about the first time.
Sau!
Quoted 22 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +6
-0+ if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "": + bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x') + bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is') + bb.warn('a requirement for LSB') + return '' + SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop"DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to
support libraries \
specified in the LSB Desktop specification"meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +1
-0@@ -221,6 +231,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\ atk \ libasound \ ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \ + ${@get_libqt3(d)} \ "RDEPENDS_packagegroup-core-lsb-runtime-add = "\
Hi Saul,
I have updated the branch as your suggestion.
git://git.pokylinux.org/poky-contrib hongxu/fix-lsb-libqt3
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-lsb-libqt3
+def get_libqt3(d):
+ if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "":
+ if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "":
+ return 'libqt-mt3'
+
+ bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x')
+ bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is')
+ bb.warn('a requirement for LSB')+ return ''
+
Thanks,
Hongxu
Quoted 54 lines · Saul Wold
Quoted 18 lines · Hongxu Jia
The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop, and it locates in meta-qt3 layer.
So if meta-qt3 is not added, there should be a warning to call attention; if added, it will add libqt-mt to RDEPENDS.[YOCTO #5153]
Signed-off-by Hongxu Jia <[email protected]>--- meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ 1 file changed, 11 insertions(+)meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +0
-0meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb RDEPENDS_packagegroup-core-lsb-python = "\ · line 199
Quoted 7 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +4
-0@@ -193,6 +193,16 @@ RDEPENDS_packagegroup-core-lsb-python = "\ python-misc \ " +def get_libqt3(d): + if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "": + return 'libqt-mt3' +I think this might cause unexpected behavoir for people who just happen to have qt3 in their bblayer, I would also wrap the linuxstdbase around the above line.
Sorry for not being clear about the first time.
Sau!
Quoted 22 lines
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +6
-0+ if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "": + bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x') + bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is') + bb.warn('a requirement for LSB') + return '' + SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop"DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to
support libraries \
specified in the LSB Desktop specification"meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +1
-0@@ -221,6 +231,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\ atk \ libasound \ ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \ + ${@get_libqt3(d)} \ "RDEPENDS_packagegroup-core-lsb-runtime-add = "\