Skip to contentSkip to conversation

OMAPDSS: Return right error during connector probe

PATCH In review Sathya Prakash M R 2 participants 2 messages Sep 12, 2013 – Sep 16, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAPDSS: Return right error during connector probe

While using HDMI connector driver with sil9022 encoder came across issue where connector driver is probed first. This resulted in error. A deffered probe solved this. Most connector drivers need a encoder driver as their video source. This patch ensures we do a probe defferal if video source is not present for connector drivers.

---
 .../video/omap2/displays-new/connector-analog-tv.c |    2 +-
 drivers/video/omap2/displays-new/connector-dvi.c   |    2 +-
 drivers/video/omap2/displays-new/connector-hdmi.c  |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/video/omap2/displays-new/connector-analog-tv.c +1 -1
index 5338f36..547a604 100644
@@ -177,7 +177,7 @@ static int tvc_probe_pdata(struct platform_device *pdev)
 	in = omap_dss_find_output(pdata->source);
 	if (in == NULL) {
 		dev_err(&pdev->dev, "Failed to find video source\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 
 	ddata->in = in;
drivers/video/omap2/displays-new/connector-dvi.c +1 -1
index bc5f8ce..63d88ee 100644
@@ -263,7 +263,7 @@ static int dvic_probe_pdata(struct platform_device *pdev)
 	in = omap_dss_find_output(pdata->source);
 	if (in == NULL) {
 		dev_err(&pdev->dev, "Failed to find video source\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 
 	ddata->in = in;
drivers/video/omap2/displays-new/connector-hdmi.c +1 -1
index c582671..9abe2c0 100644
@@ -290,7 +290,7 @@ static int hdmic_probe_pdata(struct platform_device *pdev)
 	in = omap_dss_find_output(pdata->source);
 	if (in == NULL) {
 		dev_err(&pdev->dev, "Failed to find video source\n");
-		return -ENODEV;
+		return -EPROBE_DEFER;
 	}
 
 	ddata->in = in;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 8 lines · Sathya Prakash M R

While using HDMI connector driver with sil9022 encoder came across issue where connector driver is probed first. This resulted in error. A deffered probe solved this. Most connector drivers need a encoder driver as their video source. This patch ensures we do a probe defferal if video source is not present for connector drivers.

Thanks, applying to 3.12 fixes.

Tomi