Skip to contentSkip to conversation

net:dccp: do not report ICMP redirects to user space

PATCH Applied Duan Jiong 2 participants 2 messages Sep 18, 2013

Subsystems (2)
lore
Share & tools
lore

Duan Jiong

author
#0 lore raw

PATCH 1/1 net:dccp: do not report ICMP redirects to user space

From: Duan Jiong <[email protected]>

DCCP shouldn't be setting sk_err on redirects as it isn't an error condition. it should be doing exactly what tcp is doing and leaving the error handler without touching the socket.

---
 net/dccp/ipv6.c | 1 +
 1 file changed, 1 insertion(+)
net/dccp/ipv6.c +1 -0
index 9c61f9c..6cf9f77 100644
@@ -135,6 +135,7 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
 
 		if (dst)
 			dst->ops->redirect(dst, sk, skb);
+		goto out;
 	}
 
 	if (type == ICMPV6_PKT_TOOBIG) {
Signature · 1 line
1.8.3.1