Skip to contentSkip to conversation

iputils: new package

PATCH Superseded Matt Weber 3 participants 8 messages Sep 18, 2013 – Sep 19, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 iputils: new package

This new package adds full versions of ping/traceroute/etc.

Built against GCC4.7 ARM, x86 uclibc IPv6 and uclibc no IPv6.

---
 package/Config.in          |    1 +
 package/iputils/Config.in  |    7 +++++
 package/iputils/iputils.mk |   57 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 package/iputils/Config.in
 create mode 100644 package/iputils/iputils.mk
package/Config.in +1 -0
index 973d32c..14ca821 100644
@@ -792,6 +792,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
 source "package/knock/Config.in"
package/iputils/Config.in new file +7 -0
new file mode 100644
index 0000000..92bbea9
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IPUTILS
+	bool "iputils"
+	help
+	  This package is set of small useful utilities for Linux networking.
+	  It includes complete versions of ping, traceroute, etc.
+
+	  http://sourceforge.net/projects/iputils/
package/iputils/iputils.mk new file +57 -0

57 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 iputils: new package

Found a better way to check for uClibc and the state of IPV6 support. Workin on v2 of this patch.

Matt

Matt Weber <[email protected]> wrote on 09/18/2013 02:36:53 PM:

Quoted 38 lines

From: Matt Weber <[email protected]>
To: buildroot at busybox.net
Cc: Matt Weber <[email protected]>
Date: 09/18/2013 02:36 PM
Subject: [PATCH 1/1] iputils: new package

This new package adds full versions of ping/traceroute/etc.

Built against GCC4.7 ARM, x86 uclibc IPv6 and uclibc no IPv6.

---
 package/Config.in          |    1 +
 package/iputils/Config.in  |    7 +++++
 package/iputils/iputils.mk |   57 +++++++++++++++++++++++++++++++++
+++++++++++
 3 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 package/iputils/Config.in
 create mode 100644 package/iputils/iputils.mk
package/Config.in +1 -0
index 973d32c..14ca821 100644
@@ -792,6 +792,7 @@ source "package/iproute2/Config.in"
 source "package/ipsec-tools/Config.in"
 source "package/ipset/Config.in"
 source "package/iptables/Config.in"
+source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
 source "package/knock/Config.in"
package/iputils/Config.in new file +0 -0
new file mode 100644
index 0000000..92bbea9

package/iputils/Config.in line 4

Quoted 4 lines
package/iputils/Config.in new file +4 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IPUTILS
+   bool "iputils"
+   help
+     This package is set of small useful utilities for Linux 

networking.

package/iputils/iputils.mk

Quoted 10 lines
package/iputils/Config.in new file +3 -0
+     It includes complete versions of ping, traceroute, etc.
+
+     http://sourceforge.net/projects/iputils/
package/iputils/iputils.mk new file +0 -0
new file mode 100644
index 0000000..b4576cc
@@ -0,0 +1,57 @@

+################################################################################

package/iputils/iputils.mk line 4

Quoted 4 lines
package/iputils/iputils.mk new file +3 -0
+#
+# iputils
+#

+################################################################################

Quoted 59 lines
package/iputils/iputils.mk new file +32 -0
+
+IPUTILS_VERSION = 20121011
+IPUTILS_SITE = http://www.skbuff.net/iputils/
+IPUTILS_SOURCE = iputils-s$(IPUTILS_VERSION).tar.bz2
+IPUTILS_LICENSE = GPLv2+ BSD-3c
+# Only included a license file for BSD.
+IPUTILS_LICENSE_FILES = COPYING
+
+IPUTILS_DEPENDENCIES = libcap libsysfs openssl
+# Build after busybox so target ends up with this package's full
+# versions of the applications instead of busybox applets.
+ifeq ($(BR2_PACKAGE_BUSYBOX),y)
+IPUTILS_DEPENDENCIES += busybox
+endif
+
+define IPUTILS_IPV6_TARGET_CMDS
+   $(INSTALL) -D -m 755 $(@D)/ping6       $(TARGET_DIR)/bin/ping6
+   $(INSTALL) -D -m 755 $(@D)/tracepath6  $(TARGET_DIR)/bin/tracepath6
+   $(INSTALL) -D -m 755 $(@D)/traceroute6 $(TARGET_DIR)/bin/traceroute6
+endef
+IPUTILS_IPV6_MKTARGETS = ping6 tracepath6 traceroute6
+
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+ifneq ($(BR2_TOOLCHAIN_BUILDROOT_INET_IPV6),y)
+define IPUTILS_IPV6_TARGET_CMDS
+endef
+define IPUTILS_IPV6_MKTARGETS
+endef
+endif
+endif
+
+IPUTILS_MKTARGETS = arping clockdiff ping rarpd rdisc tftpd 

tracepath $(IPUTILS_IPV6_MKTARGETS)

package/iputils/iputils.mk new file +2 -0
+
+IPUTILS_MAKE_CMDS = $(TARGET_CONFIGURE_OPTS) KERNEL_INCLUDE=$

(STAGING_DIR)/usr/include/linux \
+ CFLAGS+="-D_GNU_SOURCE -Wstrict-prototypes -Wall -
DCAPABILITIES -DUSE_SYSFS"

package/iputils/iputils.mk new file +3 -0
+
+define IPUTILS_BUILD_CMDS
+   $(MAKE) -C $(@D) $(IPUTILS_MAKE_CMDS) DESTDIR=$(STAGING_DIR) $

(IPUTILS_MKTARGETS)

package/iputils/iputils.mk new file +14 -0
+endef
+
+define IPUTILS_INSTALL_TARGET_CMDS
+   $(INSTALL) -D -m 755 $(@D)/arping      $(TARGET_DIR)/sbin/arping
+   $(INSTALL) -D -m 755 $(@D)/clockdiff   $(TARGET_DIR)/bin/clockdiff
+   $(INSTALL) -D -m 755 $(@D)/ping        $(TARGET_DIR)/bin/ping
+   $(INSTALL) -D -m 755 $(@D)/rarpd       $(TARGET_DIR)/sbin/rarpd
+   $(INSTALL) -D -m 755 $(@D)/rdisc       $(TARGET_DIR)/sbin/rdisc
+   $(INSTALL) -D -m 755 $(@D)/tftpd $(TARGET_DIR)/usr/sbin/in.tftpd
+   $(INSTALL) -D -m 755 $(@D)/tracepath   $(TARGET_DIR)/bin/tracepath
+   $(IPUTILS_IPV6_TARGET_CMDS)
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/1 iputils: new package

In reply to Matt Weber
Quoted 31 lines · Matt Weber

This new package adds full versions of ping/traceroute/etc.

Built against GCC4.7 ARM, x86 uclibc IPv6 and uclibc no IPv6.

---
  package/Config.in          |    1 +
  package/iputils/Config.in  |    7 +++++
  package/iputils/iputils.mk |   57 ++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 65 insertions(+), 0 deletions(-)

create mode 100644 package/iputils/Config.in
create mode 100644 package/iputils/iputils.mk

package/Config.in +1 -0
index 973d32c..14ca821 100644
@@ -792,6 +792,7 @@ source "package/iproute2/Config.in"
  source "package/ipsec-tools/Config.in"
  source "package/ipset/Config.in"
  source "package/iptables/Config.in"
+source "package/iputils/Config.in"
  source "package/iw/Config.in"
  source "package/kismet/Config.in"
  source "package/knock/Config.in"
package/iputils/Config.in new file +0 -0
new file mode 100644
index 0000000..92bbea9

package/iputils/Config.in line 2

Quoted 2 lines
package/iputils/Config.in new file +2 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IPUTILS
+	bool "iputils"

You're missing a couple of select statements here.

Quoted 11 lines
package/iputils/Config.in new file +5 -0
+	help
+	  This package is set of small useful utilities for Linux networking.
+	  It includes complete versions of ping, traceroute, etc.
+
+	  http://sourceforge.net/projects/iputils/
package/iputils/iputils.mk new file +0 -0
new file mode 100644
index 0000000..b4576cc

package/iputils/iputils.mk line 9

Quoted 9 lines
package/iputils/iputils.mk new file +9 -0
@@ -0,0 +1,57 @@
+################################################################################
+#
+# iputils
+#
+################################################################################
+
+IPUTILS_VERSION = 20121011
+IPUTILS_SITE = http://www.skbuff.net/iputils/
+IPUTILS_SOURCE = iputils-s$(IPUTILS_VERSION).tar.bz2

I think the s should be considered part of the version number.

package/iputils/iputils.mk line 14

Quoted 5 lines
package/iputils/iputils.mk new file +5 -0
+IPUTILS_LICENSE = GPLv2+ BSD-3c
+# Only included a license file for BSD.
+IPUTILS_LICENSE_FILES = COPYING
+
+IPUTILS_DEPENDENCIES = libcap libsysfs openssl

openssl is only needed for ping6. cap and sysfs can be avoided with
USE_CAP=no and USE_SYSFS=no.

package/iputils/iputils.mk line 21

Quoted 7 lines
package/iputils/iputils.mk new file +7 -0
+# Build after busybox so target ends up with this package's full
+# versions of the applications instead of busybox applets.
+ifeq ($(BR2_PACKAGE_BUSYBOX),y)
+IPUTILS_DEPENDENCIES += busybox
+endif
+
+define IPUTILS_IPV6_TARGET_CMDS

I guess you mean INSTALL_TARGET_CMDS.

Also, this define should be in a BR2_INET_IPV6 condition and the
conditions below should be removed.

Quoted 6 lines
package/iputils/iputils.mk new file +6 -0
+	$(INSTALL) -D -m 755 $(@D)/ping6       $(TARGET_DIR)/bin/ping6
+	$(INSTALL) -D -m 755 $(@D)/tracepath6  $(TARGET_DIR)/bin/tracepath6
+	$(INSTALL) -D -m 755 $(@D)/traceroute6 $(TARGET_DIR)/bin/traceroute6
+endef
+IPUTILS_IPV6_MKTARGETS = ping6 tracepath6 traceroute6
+

package/iputils/iputils.mk line 37

Quoted 10 lines
package/iputils/iputils.mk new file +10 -0
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+ifneq ($(BR2_TOOLCHAIN_BUILDROOT_INET_IPV6),y)
+define IPUTILS_IPV6_TARGET_CMDS
+endef
+define IPUTILS_IPV6_MKTARGETS
+endef
+endif
+endif
+
+IPUTILS_MKTARGETS = arping clockdiff ping rarpd rdisc tftpd tracepath $(IPUTILS_IPV6_MKTARGETS)

Define this variable before the IPv6 stuff, and append to it inside the
IPv6 condition. Then you don't need the additional variable.

Also, I would prefer if the variable was called IPUTILS_MAKE_OPT, so it
is the same as what is used by autotools.

package/iputils/iputils.mk line 39

Quoted 2 lines
package/iputils/iputils.mk new file +2 -0
+
+IPUTILS_MAKE_CMDS = $(TARGET_CONFIGURE_OPTS) KERNEL_INCLUDE=$(STAGING_DIR)/usr/include/linux \

This can also be part of the _MAKE_OPT variable.

Since you're not building the module, the KERNEL_INCLUDE isn't used, right?

package/iputils/iputils.mk line 40

Quoted 1 line
package/iputils/iputils.mk new file +1 -0
+		CFLAGS+="-D_GNU_SOURCE -Wstrict-prototypes -Wall -DCAPABILITIES -DUSE_SYSFS"

How about CFLAGS="$(TARGET_CFLAGS) $$(CCOPT) $$(GLIBCFIX) $$(DEFINES)"
i.e. reusing the package's make variables.

package/iputils/iputils.mk line 43

Quoted 3 lines
package/iputils/iputils.mk new file +3 -0
+
+define IPUTILS_BUILD_CMDS
+	$(MAKE) -C $(@D) $(IPUTILS_MAKE_CMDS) DESTDIR=$(STAGING_DIR) $(IPUTILS_MKTARGETS)

The Makefile doesn't use DESTDIR.

Regards,
Arnout

Quoted 15 lines
package/iputils/iputils.mk new file +14 -0
+endef
+
+define IPUTILS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 755 $(@D)/arping      $(TARGET_DIR)/sbin/arping
+	$(INSTALL) -D -m 755 $(@D)/clockdiff   $(TARGET_DIR)/bin/clockdiff
+	$(INSTALL) -D -m 755 $(@D)/ping        $(TARGET_DIR)/bin/ping
+	$(INSTALL) -D -m 755 $(@D)/rarpd       $(TARGET_DIR)/sbin/rarpd
+	$(INSTALL) -D -m 755 $(@D)/rdisc       $(TARGET_DIR)/sbin/rdisc
+	$(INSTALL) -D -m 755 $(@D)/tftpd       $(TARGET_DIR)/usr/sbin/in.tftpd
+	$(INSTALL) -D -m 755 $(@D)/tracepath   $(TARGET_DIR)/bin/tracepath
+	$(IPUTILS_IPV6_TARGET_CMDS)
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 iputils: new package

Arnout Vandecappelle <[email protected]> wrote on 09/18/2013 05:36:30 PM:

Quoted 35 lines

From: Arnout Vandecappelle <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 09/18/2013 05:36 PM
Subject: Re: [Buildroot] [PATCH 1/1] iputils: new package

Quoted 9 lines · Matt Weber

This new package adds full versions of ping/traceroute/etc.

Built against GCC4.7 ARM, x86 uclibc IPv6 and uclibc no IPv6.

---
  package/Config.in          |    1 +
  package/iputils/Config.in  |    7 +++++
  package/iputils/iputils.mk |   57 ++++++++++++++++++++++++++++++

++++++++++++++

Quoted 18 lines
  3 files changed, 65 insertions(+), 0 deletions(-)

create mode 100644 package/iputils/Config.in
create mode 100644 package/iputils/iputils.mk

package/Config.in +1 -0
index 973d32c..14ca821 100644
@@ -792,6 +792,7 @@ source "package/iproute2/Config.in"
  source "package/ipsec-tools/Config.in"
  source "package/ipset/Config.in"
  source "package/iptables/Config.in"
+source "package/iputils/Config.in"
  source "package/iw/Config.in"
  source "package/kismet/Config.in"
  source "package/knock/Config.in"
package/iputils/Config.in new file +0 -0
new file mode 100644
Quoted 9 lines

package/iputils/Config.in line 2

Quoted 6 lines

index 0000000..92bbea9

package/iputils/Config.in new file +2 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IPUTILS
+   bool "iputils"

You're missing a couple of select statements here.

After removing libsysfs and libcap (below) that leaves openssl. Since that's conditional, would something like this be reasonable? if BR2_INET_IPV6
select BR2_OPENSSL
endif

Quoted 2 lines

package/iputils/Config.in line 4

Quoted 2 lines
package/iputils/Config.in new file +2 -0
+   help
+     This package is set of small useful utilities for Linux 

networking.

Quoted 11 lines

package/iputils/iputils.mk

Quoted 10 lines
package/iputils/Config.in new file +3 -0
+     It includes complete versions of ping, traceroute, etc.
+
+     http://sourceforge.net/projects/iputils/
package/iputils/iputils.mk new file +0 -0
new file mode 100644
index 0000000..b4576cc
@@ -0,0 +1,57 @@

+################################################################################

Quoted 5 lines

package/iputils/iputils.mk line 4

Quoted 4 lines
package/iputils/iputils.mk new file +3 -0
+#
+# iputils
+#

+################################################################################

Quoted 6 lines

package/iputils/iputils.mk line 9

Quoted 4 lines
package/iputils/iputils.mk new file +4 -0
+
+IPUTILS_VERSION = 20121011
+IPUTILS_SITE = http://www.skbuff.net/iputils/
+IPUTILS_SOURCE = iputils-s$(IPUTILS_VERSION).tar.bz2

I think the s should be considered part of the version number.

Ok

Quoted 8 lines

package/iputils/iputils.mk line 14

Quoted 6 lines
package/iputils/iputils.mk new file +5 -0
+IPUTILS_LICENSE = GPLv2+ BSD-3c
+# Only included a license file for BSD.
+IPUTILS_LICENSE_FILES = COPYING
+
+IPUTILS_DEPENDENCIES = libcap libsysfs openssl

openssl is only needed for ping6. cap and sysfs can be avoided with

I'll update so it's added to the dependencies only when IPv6 is enabled

Quoted 1 line

USE_CAP=no and USE_SYSFS=no.

I went back and double checked if I needed those options and I don't.

Quoted 11 lines

package/iputils/iputils.mk line 21

Quoted 8 lines
package/iputils/iputils.mk new file +7 -0
+# Build after busybox so target ends up with this package's full
+# versions of the applications instead of busybox applets.
+ifeq ($(BR2_PACKAGE_BUSYBOX),y)
+IPUTILS_DEPENDENCIES += busybox
+endif
+
+define IPUTILS_IPV6_TARGET_CMDS

I guess you mean INSTALL_TARGET_CMDS.

Quoted 2 lines

Also, this define should be in a BR2_INET_IPV6 condition and the
conditions below should be removed.

Ok

Quoted 4 lines

package/iputils/iputils.mk

Quoted 4 lines
package/iputils/iputils.mk new file +3 -0
+   $(INSTALL) -D -m 755 $(@D)/ping6       $(TARGET_DIR)/bin/ping6
+   $(INSTALL) -D -m 755 $(@D)/tracepath6 $(TARGET_DIR)/bin/tracepath6
+   $(INSTALL) -D -m 755 $(@D)/traceroute6 

$(TARGET_DIR)/bin/traceroute6

Quoted 15 lines

package/iputils/iputils.mk

Quoted 13 lines
package/iputils/iputils.mk new file +13 -0
+endef
+IPUTILS_IPV6_MKTARGETS = ping6 tracepath6 traceroute6
+
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+ifneq ($(BR2_TOOLCHAIN_BUILDROOT_INET_IPV6),y)
+define IPUTILS_IPV6_TARGET_CMDS
+endef
+define IPUTILS_IPV6_MKTARGETS
+endef
+endif
+endif
+
+IPUTILS_MKTARGETS = arping clockdiff ping rarpd rdisc tftpd 

tracepath $(IPUTILS_IPV6_MKTARGETS)

Quoted 1 line

Define this variable before the IPv6 stuff, and append to it inside

the

Quoted 1 line

IPv6 condition. Then you don't need the additional variable.

Ok

Quoted 2 lines

Also, I would prefer if the variable was called IPUTILS_MAKE_OPT, so

it

Quoted 1 line

is the same as what is used by autotools.

Sure.

Quoted 8 lines

package/iputils/iputils.mk line 37

Quoted 3 lines
package/iputils/iputils.mk new file +2 -0
+
+IPUTILS_MAKE_CMDS = $(TARGET_CONFIGURE_OPTS) KERNEL_INCLUDE=$

(STAGING_DIR)/usr/include/linux \

This can also be part of the _MAKE_OPT variable.

Since you're not building the module, the KERNEL_INCLUDE isn't used,

right?

Correct, I'll remove.

Quoted 6 lines

package/iputils/iputils.mk line 38

Quoted 2 lines
package/iputils/iputils.mk new file +1 -0
+      CFLAGS+="-D_GNU_SOURCE -Wstrict-prototypes -Wall -

DCAPABILITIES -DUSE_SYSFS"

How about CFLAGS="$(TARGET_CFLAGS) $$(CCOPT) $$(GLIBCFIX) $$(DEFINES)"
i.e. reusing the package's make variables.

I don't believe the $$( will expand out. I tried this quick and they end up as $(CCOPT), etc on the build line with a bash command error of not found.

Quoted 7 lines

package/iputils/iputils.mk

Quoted 4 lines
package/iputils/iputils.mk new file +3 -0
+
+define IPUTILS_BUILD_CMDS
+   $(MAKE) -C $(@D) $(IPUTILS_MAKE_CMDS) DESTDIR=$(STAGING_DIR) $

(IPUTILS_MKTARGETS)

The Makefile doesn't use DESTDIR.

Correct, I'll update.

Thanks,
Matt

[snip]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/666add8a/attachment.html>

#4 lore raw

PATCH 1/1 iputils: new package

Quoted 47 lines · On 19/09/13 15:37, mlweber1 at rockwellcollins.com wrote:

Arnout Vandecappelle <[email protected]> wrote on 09/18/2013 05:36:30 PM:

Quoted 35 lines

From: Arnout Vandecappelle <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 09/18/2013 05:36 PM
Subject: Re: [Buildroot] [PATCH 1/1] iputils: new package

Quoted 9 lines · Matt Weber

This new package adds full versions of ping/traceroute/etc.

Built against GCC4.7 ARM, x86 uclibc IPv6 and uclibc no IPv6.

---
  package/Config.in          |    1 +
  package/iputils/Config.in  |    7 +++++
  package/iputils/iputils.mk |   57 ++++++++++++++++++++++++++++++

++++++++++++++

Quoted 18 lines
  3 files changed, 65 insertions(+), 0 deletions(-)

create mode 100644 package/iputils/Config.in
create mode 100644 package/iputils/iputils.mk

package/Config.in +1 -0
index 973d32c..14ca821 100644
@@ -792,6 +792,7 @@ source "package/iproute2/Config.in"
  source "package/ipsec-tools/Config.in"
  source "package/ipset/Config.in"
  source "package/iptables/Config.in"
+source "package/iputils/Config.in"
  source "package/iw/Config.in"
  source "package/kismet/Config.in"
  source "package/knock/Config.in"
package/iputils/Config.in new file +0 -0
new file mode 100644
Quoted 9 lines

package/iputils/Config.in line 2

Quoted 6 lines

index 0000000..92bbea9

package/iputils/Config.in new file +2 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_IPUTILS
+   bool "iputils"

You're missing a couple of select statements here.

Quoted 5 lines

After removing libsysfs and libcap (below) that leaves openssl. Since that's conditional, would something like this be reasonable? if BR2_INET_IPV6
select BR2_OPENSSL
endif

Correct, except that it should be:

select BR2_OPENSSL if BR2_INET_IPV6

Quoted 40 lines
Quoted 3 lines

package/iputils/Config.in line 4

Quoted 3 lines
package/iputils/Config.in new file +2 -0
+   help
+     This package is set of small useful utilities for Linux

networking.

Quoted 11 lines
Quoted 10 lines
package/iputils/Config.in new file +3 -0
+     It includes complete versions of ping, traceroute, etc.
+
+ http://sourceforge.net/projects/iputils/
package/iputils/iputils.mk new file +0 -0
new file mode 100644
index 0000000..b4576cc
@@ -0,0 +1,57 @@
(quoted diff) +2 -0
+################################################################################
 > > +#
 > > +# iputils
 > > +#
 > >
 >
+################################################################################
 > > +
 > > +IPUTILS_VERSION = 20121011
 > > +IPUTILS_SITE = http://www.skbuff.net/iputils/
 > > +IPUTILS_SOURCE = iputils-s$(IPUTILS_VERSION).tar.bz2
 >
 >   I think the s should be considered part of the version number.

Ok

Quoted 8 lines

package/iputils/iputils.mk line 14

Quoted 6 lines
package/iputils/iputils.mk new file +5 -0
+IPUTILS_LICENSE = GPLv2+ BSD-3c
+# Only included a license file for BSD.
+IPUTILS_LICENSE_FILES = COPYING
+
+IPUTILS_DEPENDENCIES = libcap libsysfs openssl

openssl is only needed for ping6. cap and sysfs can be avoided with

Quoted 5 lines

I'll update so it's added to the dependencies only when IPv6 is enabled

Quoted 1 line

USE_CAP=no and USE_SYSFS=no.

I went back and double checked if I needed those options and I don't.

Er, if you don't set USE_CAP=no then it will try to link with -lcap, so
if you don't have libcap in your staging dir it will fail...

[snip]

Quoted 10 lines
Quoted 6 lines

package/iputils/iputils.mk line 6

Quoted 2 lines
package/iputils/iputils.mk new file +1 -0
+      CFLAGS+="-D_GNU_SOURCE -Wstrict-prototypes -Wall -

DCAPABILITIES -DUSE_SYSFS"

How about CFLAGS="$(TARGET_CFLAGS) $$(CCOPT) $$(GLIBCFIX) $$(DEFINES)"
i.e. reusing the package's make variables.

I don't believe the $$( will expand out. I tried this quick and they end up as $(CCOPT), etc on the build line with a bash command error of not found.

Ah yes forgot about bash... So it should be

CFLAGS="$(TARGET_CFLAGS) \$$(CCOPT) \$$(GLIBCFIX) \$$(DEFINES)"

With that kind of complexity, I guess it's better to stick with what
you had... Only, that means that you'll have to add conditions for -DCAPABILITIES and -DUSE_SYSFS as well.

Regards,
Arnout

Quoted 14 lines
Quoted 7 lines

package/iputils/iputils.mk

Quoted 4 lines
package/iputils/iputils.mk new file +3 -0
+
+define IPUTILS_BUILD_CMDS
+   $(MAKE) -C $(@D) $(IPUTILS_MAKE_CMDS) DESTDIR=$(STAGING_DIR) $

(IPUTILS_MKTARGETS)

The Makefile doesn't use DESTDIR.

Correct, I'll update.

Thanks,
Matt

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 iputils: new package

Arnout, Matthew,

Quoted 9 lines · Arnout Vandecappelle
Quoted 5 lines

After removing libsysfs and libcap (below) that leaves openssl. Since that's conditional, would something like this be reasonable? if BR2_INET_IPV6
select BR2_OPENSSL
endif

Correct, except that it should be:

select BR2_OPENSSL if BR2_INET_IPV6

Just curious: does this package really needs OpenSSL only when IPv6 support is available? At first sight, I don't quite see why SSL support and IPv6 support would be related, but maybe I'm missing something?

At least, this unusual select should carry a comment above it that explains why it is needed.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 iputils: new package

Thomas Petazzoni <[email protected]> wrote on 09/19/2013 09:59:17 AM:

Quoted 11 lines

From: Thomas Petazzoni <[email protected]>
To: Arnout Vandecappelle <[email protected]>
Cc: mlweber1 at rockwellcollins.com, buildroot at busybox.net
Date: 09/19/2013 09:59 AM
Subject: Re: [Buildroot] [PATCH 1/1] iputils: new package

Arnout, Matthew,

Quoted 1 line · Arnout Vandecappelle
Quoted 1 line

After removing libsysfs and libcap (below) that leaves openssl.

Since

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

that's conditional, would something like this be reasonable? if BR2_INET_IPV6
select BR2_OPENSSL
endif

Quoted 8 lines
Quoted 3 lines

Correct, except that it should be:

select BR2_OPENSSL if BR2_INET_IPV6

Just curious: does this package really needs OpenSSL only when IPv6 support is available? At first sight, I don't quite see why SSL support and IPv6 support would be related, but maybe I'm missing something?

Yeah, only for IPv6 doing a md5 sum. What's the cleanest way to comment that in the Config.in? Part of the description?

Quoted 11 lines

At least, this unusual select should carry a comment above it that explains why it is needed.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/c391ebb8/attachment.html>

#7 lore raw

PATCH 1/1 iputils: new package

Hello,

Quoted 2 lines · On Thu, 19 Sep 2013 10:02:28 -0500, mlweber1 at rockwellcollins.com wrote:

Yeah, only for IPv6 doing a md5 sum. What's the cleanest way to comment that in the Config.in? Part of the description?

Just:

# IPv6 support needs to do a MD5 sum for <some reason> select BR2_PACKAGE_OPENSSL if BR2_INET_IPV6

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com