Skip to contentSkip to conversation

mx6sabresd: Fix the fdt file for the mx6dl version

PATCH New Fabio Estevam 4 participants 9 messages Sep 18, 2013 – Sep 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

From: Fabio Estevam <[email protected]>

We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.

---
 include/configs/mx6sabresd.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/mx6sabresd.h +4 -0
index a3dd74a..3229bc7 100644
@@ -16,7 +16,11 @@
 #define CONFIG_MXC_UART_BASE	UART1_BASE
 #define CONFIG_CONSOLE_DEV		"ttymxc0"
 #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
+#if defined(CONFIG_MX6Q)
 #define CONFIG_DEFAULT_FDT_FILE	"imx6q-sabresd.dtb"
+#elif defined(CONFIG_MX6DL)
+#define CONFIG_DEFAULT_FDT_FILE	"imx6dl-sabresd.dtb"
+#endif
 #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
 
 #include "mx6sabre_common.h"
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.

I fully agree with this.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

In reply to Fabio Estevam

Hi Fabio,

Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.

---
  include/configs/mx6sabresd.h | 4 ++++
  1 file changed, 4 insertions(+)
include/configs/mx6sabresd.h +0 -0
index a3dd74a..3229bc7 100644
@@ -16,7 +16,11 @@
  #define CONFIG_MXC_UART_BASE	UART1_BASE

include/configs/mx6sabresd.h line 26

Quoted 10 lines
include/configs/mx6sabresd.h +4 -0
  #define CONFIG_CONSOLE_DEV		"ttymxc0"
  #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
+#if defined(CONFIG_MX6Q)
  #define CONFIG_DEFAULT_FDT_FILE	"imx6q-sabresd.dtb"
+#elif defined(CONFIG_MX6DL)
+#define CONFIG_DEFAULT_FDT_FILE	"imx6dl-sabresd.dtb"
+#endif
  #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
 
  #include "mx6sabre_common.h"

As you know, we're loading the kernel using a boot script, with various flavors for differing locations and environments, so we've found it easier to pass environment variables for board and CPU type to the boot script.

	https://github.com/boundarydevices/u-boot-imx6/commit/4a4fc304e4fe63cde7b3201f0daab5b1856870e4

This allows the boot script to produce the DTB name as shown here:
https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have a separate choice as shown above.

Let me know your thoughts on this.

We didn't generate a proper patch for lack of time, but I think that the small addition of code has merit. We also may want to discuss the specifics in more detail.

Regards,

Eric

#3 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

Hi Eric,

Quoted 10 lines · Eric Nelson

As you know, we're loading the kernel using a boot script, with various flavors for differing locations and environments, so we've found it easier to pass environment variables for board and CPU type to the boot script.

https://github.com/boundarydevices/u-boot-imx6/commit/4a4fc304e4fe63cde7b3201f0daab5b1856870e4

This allows the boot script to produce the DTB name as shown here:

Quoted 6 lines

https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have a separate choice as shown above.

Let me know your thoughts on this.

Yes, it looks interesting for dealing with the single binary goal we want to achieve.

Quoted 3 lines

We didn't generate a proper patch for lack of time, but I think that the small addition of code has merit. We also may want to discuss the specifics in more detail.

When you have a chance please submit a patch.

At least for the upcoming 2013.10, it would be nice to have my original patch of this thread applied for sabresd though.

Regards,

Fabio Estevam

#4 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

Hi Fabio,

Quoted 22 lines · Fabio Estevam

Hi Eric,

Quoted 10 lines · Eric Nelson

As you know, we're loading the kernel using a boot script, with various flavors for differing locations and environments, so we've found it easier to pass environment variables for board and CPU type to the boot script.

https://github.com/boundarydevices/u-boot-imx6/commit/4a4fc304e4fe63cde7b3201f0daab5b1856870e4

This allows the boot script to produce the DTB name as shown here:

Quoted 6 lines

https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have a separate choice as shown above.

Let me know your thoughts on this.

Quoted 9 lines

Yes, it looks interesting for dealing with the single binary goal we want to achieve.

Quoted 3 lines

We didn't generate a proper patch for lack of time, but I think that the small addition of code has merit. We also may want to discuss the specifics in more detail.

When you have a chance please submit a patch.

Will do.

Quoted 3 lines

At least for the upcoming 2013.10, it would be nice to have my original patch of this thread applied for sabresd though.

Works for me.

My response wasn't a comment on this patch. You just prompted me to start a different discussion.

Regards,

Eric

#5 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

In reply to Fabio Estevam
Quoted 4 lines

At least for the upcoming 2013.10, it would be nice to have my original patch of this thread applied for sabresd though.

Agree. I will merge it, and we can then discuss for improvements.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#6 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

In reply to Eric Nelson

Hi Eric,

Quoted 10 lines · Eric Nelson

This allows the boot script to produce the DTB name as shown here:
https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have a separate choice as shown above.

Let me know your thoughts on this.

It would be helpful if we agree on a set of common variables (across architectures) to be automatically set by u-boot at the startup.

The proposed mechanism is already used in u-boot: see the "dieid#" variable for TI's OMAP.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

Thanks, Stefano,

Quoted 12 lines · Stefano Babic

Hi Eric,

Quoted 9 lines · Eric Nelson

This allows the boot script to produce the DTB name as shown here:
https://github.com/boundarydevices/u-boot-imx6/blob/staging/board/boundary/nitrogen6x/6x_bootscript.txt#L72

If/when you move to a single binary for DQ/DL, you won't have a separate choice as shown above.

Quoted 8 lines
Quoted 1 line

Let me know your thoughts on this.

It would be helpful if we agree on a set of common variables (across architectures) to be automatically set by u-boot at the startup.

The proposed mechanism is already used in u-boot: see the "dieid#" variable for TI's OMAP.

This maps to the get_imx_type() routine pretty nicely, though the hash in the environment variable seems weird.

We'll want a board identifier as well, and see other boards using CONFIG_SYS_BOARD, which seems very reasonable, but the Nitrogen6x/SABRE Lite will need some additional logic.

#8 lore raw

PATCH 1/1 mx6sabresd: Fix the fdt file for the mx6dl version

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

We need to load 'imx6dl-sabresd.dtb' in the mx6dl version.

---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================