Skip to contentSkip to conversation

mx6sabresd: Return error if cpu_eth_init() fails

PATCH New Fabio Estevam 2 participants 4 messages Sep 13, 2013 – Sep 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mx6sabresd: Return error if cpu_eth_init() fails

From: Fabio Estevam <[email protected]>

Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.

---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6sabresd/mx6sabresd.c +1 -1
index c832bd9..425f734 100644
@@ -421,7 +421,7 @@ int board_eth_init(bd_t *bis)
 	if (ret)
 		printf("FEC MXC: %s:failed\n", __func__);
 
-	return 0;
+	return ret;
 }
 
 int board_early_init_f(void)
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 2/2 mx6qsabreauto: Return error if cpu_eth_init() fails

From: Fabio Estevam <[email protected]>

Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.

---
 board/freescale/mx6qsabreauto/mx6qsabreauto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6qsabreauto/mx6qsabreauto.c +1 -1
index 1cdf2cb..c55ee87 100644
@@ -200,7 +200,7 @@ int board_eth_init(bd_t *bis)
 	if (ret)
 		printf("FEC MXC: %s:failed\n", __func__);
 
-	return 0;
+	return ret;
 }
 
 #define BOARD_REV_B  0x200
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 2/2 mx6qsabreauto: Return error if cpu_eth_init() fails

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.

---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 mx6sabresd: Return error if cpu_eth_init() fails

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Currently board_eth_init() always return 0, but we should propagate the error when cpu_eth_init() fails.

---

Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================