jffs2: fix unbalanced locking

PATCH New Li Zefan 1 participant 1 message Sep 23, 2013

Subsystems (2)

Memory technology devices (MTD) Journalling flash file system V2 (JFFS2)

lore

Share & tools

lore

Li Zefan

author

2013-09-23 08:52 UTC #0 lore raw

PATCH 1/1 jffs2: fix unbalanced locking

In the failure path in jffs2_do_crccheck_inode() the lock isn't released before returning.

This probably won't cause real bug, because the structure that contains the lock is freed in this case.

Signed-off-by Li Zefan <[email protected]>

---
 fs/jffs2/readinode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

fs/jffs2/readinode.c +2 -1

index ae81b01..55cf63d 100644
@@ -1425,7 +1425,8 @@ int jffs2_do_crccheck_inode(struct jffs2_sb_info *c, struct jffs2_inode_cache *i
 		jffs2_do_clear_inode(c, f);
 	}
 	jffs2_xattr_do_crccheck_inode(c, ic);
-	kfree (f);
+	mutex_unlock(&f->sem);
+	kfree(f);
 	return ret;
 }

Signature · 1 line

1.8.0.2