ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
PATCH 1/1 ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
correct mux mode for mmc1_cmd to detect eMMC on bone-black
--- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/boot/dts/am335x-bone-common.dtsi +1 -1
@@ -117,7 +117,7 @@ emmc_pins: pinmux_emmc_pins { pinctrl-single,pins = < 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */ - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */ + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */ 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */ 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
Signature · 1 line
1.7.5.4
PATCH 1/1 ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
Quoted 3 lines · Balaji T K
correct mux mode for
mmc1_cmdto detect eMMC on bone-blackSigned-off-by Balaji T K <[email protected]>
Tested on my BBB, I see that after this patch eMMC gets detected just fine:
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130920/bc24bfdb/attachment.sig>
PATCH 1/1 ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
In reply to Balaji T KQuoted 13 lines · Balaji T K
correct mux mode for
mmc1_cmdto detect eMMC on bone-blackSigned-off-by Balaji T K <[email protected]>--- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/boot/dts/am335x-bone-common.dtsi +0
-0
arch/arm/boot/dts/am335x-bone-common.dtsi line 123
Quoted 8 lines
arch/arm/boot/dts/am335x-bone-common.dtsi +1
-1@@ -117,7 +117,7 @@ emmc_pins: pinmux_emmc_pins { pinctrl-single,pins = < 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */ - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */ + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */ 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */ 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
is'nt this a common change? why is it "black only"? if it is so, then the pinmux should probably be spun off outside bone-common.dtsi into boneblack.dtsi perhaps?
Signature · 2 lines
Regards, Nishanth Menon
PATCH 1/1 ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
Quoted 17 lines · Nishanth Menon
Quoted 16 lines · Balaji T K
correct mux mode for
mmc1_cmdto detect eMMC on bone-blackSigned-off-by Balaji T K <[email protected]>--- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/boot/dts/am335x-bone-common.dtsi +0
-1@@ -117,7 +117,7 @@ emmc_pins: pinmux_emmc_pins { pinctrl-single,pins = < 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */ - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
Quoted 9 lines
arch/arm/boot/dts/am335x-bone-common.dtsi line 123
Quoted 5 lines
arch/arm/boot/dts/am335x-bone-common.dtsi +1
-0+ 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */ 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */ 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */is'nt this a common change? why is it "black only"? if it is so, then the pinmux should probably be spun off outside
bone-common.dtsiintoboneblack.dtsiperhaps?
It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can remain in bone-common.dtsi.
However I could test only on beagle bone black which has eMMC on board, since I don't have access to eMMC-cape
PATCH 1/1 ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
Quoted 37 lines · Balaji T K
Quoted 26 lines · Nishanth Menon
Quoted 24 lines · Balaji T K
correct mux mode for
mmc1_cmdto detect eMMC on bone-blackSigned-off-by Balaji T K <[email protected]>--- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/boot/dts/am335x-bone-common.dtsi +0
-0@@ -117,7 +117,7 @@ emmc_pins: pinmux_emmc_pins { pinctrl-single,pins = < 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /*gpmc_csn1.mmc1_clk */
-0x84(PIN_INPUT_PULLUP|MUX_MODE1) /*
gpmc_csn2.mmc1_cmd */
+0x84(PIN_INPUT_PULLUP|MUX_MODE2) /*
gpmc_csn2.mmc1_cmd */0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /*gpmc_ad0.mmc1_dat0 */
Quoted 9 lines
Quoted 5 lines
0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /*gpmc_ad2.mmc1_dat2 */
is'nt this a common change? why is it "black only"? if it is so, then the pinmux should probably be spun off outside
bone-common.dtsiintoboneblack.dtsiperhaps?
Quoted 6 lines
It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can
remain inbone-common.dtsi.
However I could test only on beagle bone black which has eMMC on board, since I
don't have access to eMMC-cape
Could you update the patch to the effect please considering you are modifying am335x-bone-common.dtsi
Regards,
Nishanth Menon