Skip to contentSkip to conversation

mx6: Fix use of improper value in enable_ipu_clock

PATCH New Pierre Aubert 3 participants 3 messages Sep 23, 2013 – Sep 27, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6: Fix use of improper value in enable_ipu_clock

The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize the CCGR3 register caused an undefined value for CG0.

---
 arch/arm/cpu/armv7/mx6/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/mx6/clock.c +1 -1
index 7efb0d2..0f7bcbc 100644
@@ -457,7 +457,7 @@ void enable_ipu_clock(void)
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
 	int reg;
 	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
 	writel(reg, &mxc_ccm->CCGR3);
 }
 /***************************************************/
Signature · 1 line
1.7.6.5
#1 lore raw

PATCH 1/1 mx6: Fix use of improper value in enable_ipu_clock

Quoted 15 lines · Pierre Aubert

The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize the CCGR3 register caused an undefined value for CG0.

---
  arch/arm/cpu/armv7/mx6/clock.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/mx6/clock.c +0 -0
index 7efb0d2..0f7bcbc 100644

arch/arm/cpu/armv7/mx6/clock.c void enable_ipu_clock(void) · line 463

Quoted 8 lines
arch/arm/cpu/armv7/mx6/clock.c +1 -1
@@ -457,7 +457,7 @@ void enable_ipu_clock(void)
  	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
  	int reg;
  	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
  	writel(reg, &mxc_ccm->CCGR3);
  }
  /***************************************************/
#2 lore raw

PATCH 1/1 mx6: Fix use of improper value in enable_ipu_clock

Quoted 7 lines · Pierre Aubert
Quoted 6 lines

The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize the CCGR3 register caused an undefined value for CG0.

---

Applied to u-boot-imx (fix), thanks!

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================