Skip to contentSkip to conversation

Renesas clocksource fixes for v3.12

PATCH New Simon Horman 3 participants 4 messages Sep 18, 2013 – Sep 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Renesas clocksource fixes for v3.12

Hi Daniel,

please consider this clocksource fix for v3.12.

This pull request is based on renesas-clocksource-for-v3.12 which I believe you have previously pulled.

The following changes since commit 172705f8a40b6e72c53f8cceda079504ed71c4e0:

clocksource: em_sti: Convert to devm_* managed helpers (2013-08-05 10:47:10 +0900)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocksource-fixes-for-v3.12

for you to fetch changes up to 7b096b40c9d3d2abb6bb747dd148c50c076c2e89:

clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast (2013-09-05 14:47:53 +0900)

----------------------------------------------------------------
Renesas clocksource fixes for v3.12

* em_sti: Set cpu_possible_mask to fix SMP broadcast

This resolves a regression introduced by
f7db706 ("ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event").

This problem has been present since v3.9-rc4.

----------------------------------------------------------------
Magnus Damm (1):
clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast

 drivers/clocksource/em_sti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#1 lore raw

PATCH 1/1 clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast

From: Magnus Damm <[email protected]>

Update the STI driver by setting cpu_possible_mask to make EMEV2 SMP work as expected together with the ARM broadcast timer.

This breakage was introduced by:

f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event

Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.

---
 drivers/clocksource/em_sti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/em_sti.c +1 -1
index b9c81b7..3a5909c 100644
@@ -301,7 +301,7 @@ static void em_sti_register_clockevent(struct em_sti_priv *p)
 	ced->name = dev_name(&p->pdev->dev);
 	ced->features = CLOCK_EVT_FEAT_ONESHOT;
 	ced->rating = 200;
-	ced->cpumask = cpumask_of(0);
+	ced->cpumask = cpu_possible_mask;
 	ced->set_next_event = em_sti_clock_event_next;
 	ced->set_mode = em_sti_clock_event_mode;
 
Signature · 1 line
1.8.4
#2 lore raw

PATCH 1/1 clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast

Quoted 9 lines · Simon Horman

From: Magnus Damm <[email protected]>

Update the STI driver by setting cpu_possible_mask to make EMEV2 SMP work as expected together with the ARM broadcast timer.

This breakage was introduced by:

f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event

Quoted 8 lines

Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.

---

Thanks ! Applied to my tree as 3.12 fix.

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#3 lore raw

PATCH 1/1 clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast

Quoted 13 lines · Daniel Lezcano
Quoted 12 lines · Simon Horman

From: Magnus Damm <[email protected]>

Update the STI driver by setting cpu_possible_mask to make EMEV2 SMP work as expected together with the ARM broadcast timer.

This breakage was introduced by:

f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event

Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores.

Quoted 7 lines
Quoted 5 lines

---

Thanks ! Applied to my tree as 3.12 fix.

Thanks!