pm80xx: Print SAS address of IO failed device.
Subsystems (2)
PATCH v2 6/10 pm80xx: Print SAS address of IO failed device.
Quoted 1 line
From
5ddec5ef3033b4fee08dcdc7ba8b434425453e9dMon Sep 17 00:00:00 2001
From: Anand Kumar Santhanam <[email protected]>
Date: Tue, 17 Sep 2013 16:47:21 +0530
Subject: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device.
--- drivers/scsi/pm8001/pm8001_hwi.c | 65 ++++++++++++++++++++++++++++++++++++++ drivers/scsi/pm8001/pm80xx_hwi.c | 65 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 130 insertions(+), 0 deletions(-)
drivers/scsi/pm8001/pm8001_hwi.c +65 -0
@@ -1868,6 +1868,13 @@ mpi_ssp_completion(struct pm8001_hba_info *pm8001_ha , void *piomb)if (unlikely (!t || !t->lldd_task || !t->dev))return ; ts = &t->task_status; +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%016llx" ,SAS_ADDR (t->dev->sas_addr)-1 )); +switch (status) {case IO_SUCCESS : PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS"
@@ -2276,6 +2283,11 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)u32 param;u32 status;u32 tag; +int i, j; +u8 sata_addr_low[4 ]; +u32 temp_sata_addr_low; +u8 sata_addr_hi[4 ]; +u32 temp_sata_addr_hi;struct sata_completion_resp *psataPayload;struct task_status_struct *ts;struct ata_task_resp *resp ;
@@ -2325,7 +2337,60 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) pm8001_printk("ts null\n"));return ; } +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) { +if (!((t->dev->parent) && + (DEV_IS_EXPANDER (t->dev->parent->dev_type)))) { +for (i =0 , j =4 ; j <=7 && i <=3 ; i++ , j++) + sata_addr_low[i] = pm8001_ha->sas_addr[j]; +for (i =0 , j =0 ; j <=3 && i <=3 ; i++ , j++) + sata_addr_hi[i] = pm8001_ha->sas_addr[j]; +memcpy (&temp_sata_addr_low, sata_addr_low, +sizeof (sata_addr_low)); +memcpy (&temp_sata_addr_hi, sata_addr_hi, +sizeof (sata_addr_hi)); + temp_sata_addr_hi = (((temp_sata_addr_hi >>24 ) &0xff ) + |((temp_sata_addr_hi <<8 ) & +0xff0000 ) | + ((temp_sata_addr_hi >>8 ) + &0xff00 ) | + ((temp_sata_addr_hi <<24 ) & +0xff000000 )); + temp_sata_addr_low = ((((temp_sata_addr_low >>24 ) + &0xff ) | + ((temp_sata_addr_low <<8 ) + &0xff0000 ) | + ((temp_sata_addr_low >>8 ) + &0xff00 ) | + ((temp_sata_addr_low <<24 ) + &0xff000000 )) + + pm8001_dev->attached_phy + +0x10 ); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + }else { +for (i =0 , j =4 ; j <=7 && i <=3 ; i++ , j++) + sata_addr_low[i] = t->dev->sas_addr[j]; +for (i =0 , j =0 ; j <=3 && i <=3 ; i++ , j++) + sata_addr_hi[i] = t->dev->sas_addr[j]; + temp_sata_addr_low = (sata_addr_low[0 ] <<24 ) | + (sata_addr_low[1 ] <<16 ) | + (sata_addr_low[2 ] <<8 ) | + (sata_addr_low[3 ]); + temp_sata_addr_hi = (sata_addr_hi[0 ] <<24 )| + (sata_addr_hi[1 ] <<16 )| + (sata_addr_hi[2 ] <<8 )| + (sata_addr_hi[3 ]); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + } + }switch (status) {case IO_SUCCESS :PM8001_IO_DBG (pm8001_ha,pm8001_printk ("IO_SUCCESS\n" ));
drivers/scsi/pm8001/pm80xx_hwi.c +65 -0
84 lines not on this page · raw message
Signature · 1 line
1.7.1
Quoted 179 lines · Anand
From
5ddec5ef3033b4fee08dcdc7ba8b434425453e9dMon Sep 17 00:00:00 2001
From: Anand Kumar Santhanam <[email protected]>
Date: Tue, 17 Sep 2013 16:47:21 +0530
Subject: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device.Signed-off-by [email protected]--- drivers/scsi/pm8001/pm8001_hwi.c | 65 ++++++++++++++++++++++++++++++++++++++ drivers/scsi/pm8001/pm80xx_hwi.c | 65 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 130 insertions(+), 0 deletions(-)drivers/scsi/pm8001/pm8001_hwi.c +65
-0@@ -1868,6 +1868,13 @@ mpi_ssp_completion(struct pm8001_hba_info *pm8001_ha , void *piomb)if (unlikely (!t || !t->lldd_task || !t->dev))return ; ts = &t->task_status; +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%016llx" ,SAS_ADDR (t->dev->sas_addr)-1 )); +switch (status) {case IO_SUCCESS : PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS"@@ -2276,6 +2283,11 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)u32 param;u32 status;u32 tag; +int i, j; +u8 sata_addr_low[4 ]; +u32 temp_sata_addr_low; +u8 sata_addr_hi[4 ]; +u32 temp_sata_addr_hi;struct sata_completion_resp *psataPayload;struct task_status_struct *ts;struct ata_task_resp *resp ;@@ -2325,7 +2337,60 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) pm8001_printk("ts null\n"));return ; } +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) { +if (!((t->dev->parent) && + (DEV_IS_EXPANDER (t->dev->parent->dev_type)))) { +for (i =0 , j =4 ; j <=7 && i <=3 ; i++ , j++) + sata_addr_low[i] = pm8001_ha->sas_addr[j]; +for (i =0 , j =0 ; j <=3 && i <=3 ; i++ , j++) + sata_addr_hi[i] = pm8001_ha->sas_addr[j]; +memcpy (&temp_sata_addr_low, sata_addr_low, +sizeof (sata_addr_low)); +memcpy (&temp_sata_addr_hi, sata_addr_hi, +sizeof (sata_addr_hi)); + temp_sata_addr_hi = (((temp_sata_addr_hi >>24 ) &0xff ) + |((temp_sata_addr_hi <<8 ) & +0xff0000 ) | + ((temp_sata_addr_hi >>8 ) + &0xff00 ) | + ((temp_sata_addr_hi <<24 ) & +0xff000000 )); + temp_sata_addr_low = ((((temp_sata_addr_low >>24 ) + &0xff ) | + ((temp_sata_addr_low <<8 ) + &0xff0000 ) | + ((temp_sata_addr_low >>8 ) + &0xff00 ) | + ((temp_sata_addr_low <<24 ) + &0xff000000 )) + + pm8001_dev->attached_phy + +0x10 ); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + }else { +for (i =0 , j =4 ; j <=7 && i <=3 ; i++ , j++) + sata_addr_low[i] = t->dev->sas_addr[j]; +for (i =0 , j =0 ; j <=3 && i <=3 ; i++ , j++) + sata_addr_hi[i] = t->dev->sas_addr[j]; + temp_sata_addr_low = (sata_addr_low[0 ] <<24 ) | + (sata_addr_low[1 ] <<16 ) | + (sata_addr_low[2 ] <<8 ) | + (sata_addr_low[3 ]); + temp_sata_addr_hi = (sata_addr_hi[0 ] <<24 )| + (sata_addr_hi[1 ] <<16 )| + (sata_addr_hi[2 ] <<8 )| + (sata_addr_hi[3 ]); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + } + }switch (status) {case IO_SUCCESS :PM8001_IO_DBG (pm8001_ha,pm8001_printk ("IO_SUCCESS\n" ));drivers/scsi/pm8001/pm80xx_hwi.c +54
-0@@ -1296,6 +1296,13 @@ mpi_ssp_completion(struct pm8001_hba_info *pm8001_ha , void *piomb)if (unlikely (!t || !t->lldd_task || !t->dev))return ; ts = &t->task_status; +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive" +":%016llx" ,SAS_ADDR (t->dev->sas_addr)-1 )); +switch (status) {case IO_SUCCESS : PM8001_IO_DBG(pm8001_ha,@@ -1719,6 +1726,10 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)u32 param;u32 status;u32 tag; +int i, j; +u8 sata_addr_low[4 ]; +u32 temp_sata_addr_low, temp_sata_addr_hi; +u8 sata_addr_hi[4 ];struct sata_completion_resp *psataPayload;struct task_status_struct *ts;struct ata_task_resp *resp ;@@ -1768,7 +1779,61 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) pm8001_printk("ts null\n"));return ; } +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) { +if (!((t->dev->parent) && + (DEV_IS_EXPANDER (t->dev->parent->dev_type)))) { +for (i =0 , j =4 ; i <=3 && j <=7 ; i++ , j++) + sata_addr_low[i] = pm8001_ha->sas_addr[j]; +for (i =0 , j =0 ; i <=3 && j <=3 ; i++ , j++) + sata_addr_hi[i] = pm8001_ha->sas_addr[j]; +memcpy (&temp_sata_addr_low, sata_addr_low, +sizeof (sata_addr_low)); +memcpy (&temp_sata_addr_hi, sata_addr_hi, +sizeof (sata_addr_hi)); + temp_sata_addr_hi = (((temp_sata_addr_hi >>24 ) &0xff ) + |((temp_sata_addr_hi <<8 ) & +0xff0000 ) | + ((temp_sata_addr_hi >>8 ) + &0xff00 ) | + ((temp_sata_addr_hi <<24 ) & +0xff000000 )); + temp_sata_addr_low = ((((temp_sata_addr_low >>24 ) + &0xff ) | + ((temp_sata_addr_low <<8 ) + &0xff0000 ) | + ((temp_sata_addr_low >>8 ) + &0xff00 ) | + ((temp_sata_addr_low <<24 ) + &0xff000000 )) + + pm8001_dev->attached_phy + +0x10 ); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + + }else { +for (i =0 , j =4 ; i <=3 && j <=7 ; i++ , j++) + sata_addr_low[i] = t->dev->sas_addr[j]; +for (i =0 , j =0 ; i <=3 && j <=3 ; i++ , j++) + sata_addr_hi[i] = t->dev->sas_addr[j]; + temp_sata_addr_low = (sata_addr_low[0 ] <<24 ) | + (sata_addr_low[1 ] <<16 ) | + (sata_addr_low[2] << 8) |
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) · line 1834
Quoted 10 lines
drivers/scsi/pm8001/pm80xx_hwi.c +9
-0+ (sata_addr_low[3 ]); + temp_sata_addr_hi = (sata_addr_hi[0 ] <<24 )| + (sata_addr_hi[1 ] <<16 )| + (sata_addr_hi[2 ] <<8 )| + (sata_addr_hi[3 ]); +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low));
you don't need convert for second else case just use
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) · line 1835
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ ":%016llx", SAS_ADDR(t->dev->sas_addr)-1)); should be fine?
Jack
Quoted 5 lines
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ }switch (status) {case IO_SUCCESS :PM8001_IO_DBG (pm8001_ha,pm8001_printk ("IO_SUCCESS\n" ));
We will resend the updated patch with this change.
-----Original Message-----
From: Jack Wang [mailto:[email protected]]
Sent: Thursday, September 26, 2013 12:33 PM
To: Anand Kumar Santhanam
Cc: [email protected]; Sangeetha Gnanasekaran; Nikith Ganigarakoppal; Viswas G
Subject: Re: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device.
Quoted 4 lines · Anand
From
5ddec5ef3033b4fee08dcdc7ba8b434425453e9dMon Sep 17 00:00:00 2001
From: Anand Kumar Santhanam <[email protected]>
Date: Tue, 17 Sep 2013 16:47:21 +0530
Subject: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed
device.
Quoted 5 lines
Signed-off-by [email protected]--- drivers/scsi/pm8001/pm8001_hwi.c | 65
++++++++++++++++++++++++++++++++++++++
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c | 65
++++++++++++++++++++++++++++++++++++++
drivers/scsi/pm8001/pm8001_hwi.c mpi_ssp_completion(struct pm8001_hba_info
Quoted 8 lines
2 files changed, 130 insertions(+), 0 deletions(-)drivers/scsi/pm8001/pm8001_hwi.c +0
-0@@ -1868,6 +1868,13 @@ mpi_ssp_completion(struct pm8001_hba_info
*pm8001_ha , void *piomb)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info
Quoted 14 lines
drivers/scsi/pm8001/pm8001_hwi.c +7
-0if (unlikely (!t || !t->lldd_task || !t->dev))return ; ts = &t->task_status; +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive:" +"%016llx" ,SAS_ADDR (t->dev->sas_addr)-1 )); +switch (status) {case IO_SUCCESS : PM8001_IO_DBG(pm8001_ha, pm8001_printk("IO_SUCCESS"@@ -2276,6 +2283,11 @@ mpi_sata_completion(struct pm8001_hba_info
*pm8001_ha, void *piomb)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info
Quoted 12 lines
drivers/scsi/pm8001/pm8001_hwi.c +5
-0u32 param;u32 status;u32 tag; +int i, j; +u8 sata_addr_low[4 ]; +u32 temp_sata_addr_low; +u8 sata_addr_hi[4 ]; +u32 temp_sata_addr_hi;struct sata_completion_resp *psataPayload;struct task_status_struct *ts;struct ata_task_resp *resp ;@@ -2325,7 +2337,60 @@ mpi_sata_completion(struct pm8001_hba_info
*pm8001_ha, void *piomb)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2345
Quoted 9 lines
drivers/scsi/pm8001/pm8001_hwi.c +6
-0pm8001_printk("ts null\n"));return ; } +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) { +if (!((t->dev->parent) && + (DEV_IS_EXPANDER (t->dev->parent->dev_type)))) { + for (i = 0 , j = 4 ; j <= 7 && i <= 3 ; i++ ,
j++)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2346
Quoted 1 line
drivers/scsi/pm8001/pm8001_hwi.c +1
-0+ sata_addr_low[i] =
pm8001_ha->sas_addr[j];
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2348
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+for (i =0 , j =0 ; j <=3 && i <=3 ; i++ , j++) + sata_addr_hi[i] =
pm8001_ha->sas_addr[j];
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2353
Quoted 5 lines
drivers/scsi/pm8001/pm8001_hwi.c +5
-0+memcpy (&temp_sata_addr_low, sata_addr_low, +sizeof (sata_addr_low)); +memcpy (&temp_sata_addr_hi, sata_addr_hi, +sizeof (sata_addr_hi)); + temp_sata_addr_hi = (((temp_sata_addr_hi >> 24)
& 0xff)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2354
Quoted 1 line
drivers/scsi/pm8001/pm8001_hwi.c +1
-0+ |((temp_sata_addr_hi <<
8) &
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2356
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ 0xff0000) | + ((temp_sata_addr_hi >>
8)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2358
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ & 0xff00) | + ((temp_sata_addr_hi <<
24) &
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2360
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ 0xff000000)); + temp_sata_addr_low = ((((temp_sata_addr_low >>
24)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2362
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ & 0xff) | + ((temp_sata_addr_low <<
8)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2364
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ & 0xff0000) | + ((temp_sata_addr_low >>
8)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2366
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ & 0xff00) | + ((temp_sata_addr_low <<
24)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2368
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ & 0xff000000)) + + pm8001_dev->attached_phy
+
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2371
Quoted 3 lines
drivers/scsi/pm8001/pm8001_hwi.c +3
-0+ 0x10); + PM8001_FAIL_DBG(pm8001_ha, + pm8001_printk("SAS Address of IO Failure
Drive:"
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2375
Quoted 4 lines
drivers/scsi/pm8001/pm8001_hwi.c +4
-0+"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + }else { + for (i = 0 , j = 4 ; j <= 7 && i <= 3; i++ ,
j++)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2377
Quoted 2 lines
drivers/scsi/pm8001/pm8001_hwi.c +2
-0+ sata_addr_low[i] = t->dev->sas_addr[j]; + for (i = 0 , j = 0 ; j <= 3 && i <= 3 ; i++ ,
j++)
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2380
Quoted 3 lines
drivers/scsi/pm8001/pm8001_hwi.c +3
-0+ sata_addr_hi[i] = t->dev->sas_addr[j]; + temp_sata_addr_low = (sata_addr_low[0 ] <<24 ) | + (sata_addr_low[1 ] <<16 )
|
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2381
Quoted 1 line
drivers/scsi/pm8001/pm8001_hwi.c +1
-0+ (sata_addr_low[2 ] <<8 )
|
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2389
Quoted 8 lines
drivers/scsi/pm8001/pm8001_hwi.c +7
-0+ (sata_addr_low[3 ]); + temp_sata_addr_hi = (sata_addr_hi[0 ] <<24 )| + (sata_addr_hi[1 ] <<16 )| + (sata_addr_hi[2 ] <<8 )| + (sata_addr_hi[3 ]); + PM8001_FAIL_DBG(pm8001_ha, + pm8001_printk("SAS Address of IO Failure
Drive:"
drivers/scsi/pm8001/pm8001_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 2396
Quoted 7 lines
drivers/scsi/pm8001/pm8001_hwi.c +4
-0+"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + } + }switch (status) {case IO_SUCCESS :PM8001_IO_DBG (pm8001_ha,pm8001_printk ("IO_SUCCESS\n" ));
(quoted diff) +0 -0
drivers/scsi/pm8001/pm80xx_hwi.c mpi_ssp_completion(struct pm8001_hba_info
Quoted 5 lines
a/drivers/scsi/pm8001/pm80xx_hwi.cb/drivers/scsi/pm8001/pm80xx_hwi.cindex e1ab320..80a10aa 100644drivers/scsi/pm8001/pm80xx_hwi.c +0
-0@@ -1296,6 +1296,13 @@ mpi_ssp_completion(struct pm8001_hba_info
*pm8001_ha , void *piomb)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info
Quoted 14 lines
drivers/scsi/pm8001/pm80xx_hwi.c +7
-0if (unlikely (!t || !t->lldd_task || !t->dev))return ; ts = &t->task_status; +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) +PM8001_FAIL_DBG (pm8001_ha, +pm8001_printk ("SAS Address of IO Failure Drive" +":%016llx" ,SAS_ADDR (t->dev->sas_addr)-1 )); +switch (status) {case IO_SUCCESS : PM8001_IO_DBG(pm8001_ha,@@ -1719,6 +1726,10 @@ mpi_sata_completion(struct pm8001_hba_info
*pm8001_ha, void *piomb)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info
Quoted 11 lines
drivers/scsi/pm8001/pm80xx_hwi.c +4
-0u32 param;u32 status;u32 tag; +int i, j; +u8 sata_addr_low[4 ]; +u32 temp_sata_addr_low, temp_sata_addr_hi; +u8 sata_addr_hi[4 ];struct sata_completion_resp *psataPayload;struct task_status_struct *ts;struct ata_task_resp *resp ;@@ -1768,7 +1779,61 @@ mpi_sata_completion(struct pm8001_hba_info
*pm8001_ha, void *piomb)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1787
Quoted 9 lines
drivers/scsi/pm8001/pm80xx_hwi.c +6
-0pm8001_printk("ts null\n"));return ; } +/* Print sas address of IO failed device */ +if ((status !=IO_SUCCESS ) && (status !=IO_OVERFLOW ) && + (status !=IO_UNDERFLOW )) { +if (!((t->dev->parent) && + (DEV_IS_EXPANDER (t->dev->parent->dev_type)))) { + for (i = 0 , j = 4 ; i <= 3 && j <= 7 ; i++ ,
j++)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1788
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ sata_addr_low[i] =
pm8001_ha->sas_addr[j];
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1790
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+for (i =0 , j =0 ; i <=3 && j <=3 ; i++ , j++) + sata_addr_hi[i] =
pm8001_ha->sas_addr[j];
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1795
Quoted 5 lines
drivers/scsi/pm8001/pm80xx_hwi.c +5
-0+memcpy (&temp_sata_addr_low, sata_addr_low, +sizeof (sata_addr_low)); +memcpy (&temp_sata_addr_hi, sata_addr_hi, +sizeof (sata_addr_hi)); + temp_sata_addr_hi = (((temp_sata_addr_hi >> 24)
& 0xff)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1796
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ |((temp_sata_addr_hi <<
8) &
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1798
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ 0xff0000) | + ((temp_sata_addr_hi >>
8)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1800
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ & 0xff00) | + ((temp_sata_addr_hi <<
24) &
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1802
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ 0xff000000)); + temp_sata_addr_low = ((((temp_sata_addr_low >>
24)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1804
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ & 0xff) | + ((temp_sata_addr_low <<
8)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1806
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ & 0xff0000) | + ((temp_sata_addr_low >>
8)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1808
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ & 0xff00) | + ((temp_sata_addr_low <<
24)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1810
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ & 0xff000000)) + + pm8001_dev->attached_phy
+
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1813
Quoted 3 lines
drivers/scsi/pm8001/pm80xx_hwi.c +3
-0+ 0x10); + PM8001_FAIL_DBG(pm8001_ha, + pm8001_printk("SAS Address of IO Failure
Drive:"
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1818
Quoted 5 lines
drivers/scsi/pm8001/pm80xx_hwi.c +5
-0+"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low)); + + }else { + for (i = 0 , j = 4 ; i <= 3 && j <= 7; i++ ,
j++)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1820
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+ sata_addr_low[i] = t->dev->sas_addr[j]; + for (i = 0 , j = 0 ; i <= 3 && j <= 3 ; i++ ,
j++)
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1823
Quoted 3 lines
drivers/scsi/pm8001/pm80xx_hwi.c +3
-0+ sata_addr_hi[i] = t->dev->sas_addr[j]; + temp_sata_addr_low = (sata_addr_low[0 ] <<24 ) | + (sata_addr_low[1 ] <<16 )
|
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1824
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ (sata_addr_low[2 ] <<8 )
|
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1832
Quoted 8 lines
drivers/scsi/pm8001/pm80xx_hwi.c +7
-0+ (sata_addr_low[3 ]); + temp_sata_addr_hi = (sata_addr_hi[0 ] <<24 )| + (sata_addr_hi[1 ] <<16 )| + (sata_addr_hi[2 ] <<8 )| + (sata_addr_hi[3 ]); + PM8001_FAIL_DBG(pm8001_ha, + pm8001_printk("SAS Address of IO Failure
Drive:"
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1834
Quoted 2 lines
drivers/scsi/pm8001/pm80xx_hwi.c +2
-0+"%08x%08x" , temp_sata_addr_hi, + temp_sata_addr_low));
you don't need convert for second else case just use
drivers/scsi/pm8001/pm80xx_hwi.c mpi_sata_completion(struct pm8001_hba_info · line 1835
Quoted 1 line
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ ":%016llx", SAS_ADDR(t->dev->sas_addr)-1)); should be
fine?
Jack
Quoted 5 lines
drivers/scsi/pm8001/pm80xx_hwi.c +1
-0+ }switch (status) {case IO_SUCCESS :PM8001_IO_DBG (pm8001_ha,pm8001_printk ("IO_SUCCESS\n" ));