Skip to contentSkip to conversation

video: mxsfb: Add missing break

PATCH New Marek Vasut 3 participants 4 messages Sep 26, 2013 – Sep 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Add missing break into the restore function.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Tomi Valkeinen <[email protected]>
---
 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +1 -0
index d250ed0..27197a8 100644
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
 		break;
 	case 3:
 		bits_per_pixel = 32;
+		break;
 	case 1:
 	default:
 		return -EINVAL;
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Quoted 16 lines · Marek Vasut

Add missing break into the restore function.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Tomi Valkeinen <[email protected]>
---
 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +0 -0
index d250ed0..27197a8 100644

drivers/video/mxsfb.c static int mxsfb_restore_mode(struct mxsfb_info *host) · line 626

Quoted 7 lines
drivers/video/mxsfb.c +1 -0
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
 		break;
 	case 3:
 		bits_per_pixel = 32;
+		break;
 	case 1:
 	default:
 		return -EINVAL;

Thanks, queued for 3.12 fixes.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130926/d3beecaa/attachment-0001.sig>

#2 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Hi Tomi,

Quoted 24 lines · Marek Vasut
Quoted 23 lines

Add missing break into the restore function.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Tomi Valkeinen <[email protected]>

---

 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +0 -0
index d250ed0..27197a8 100644
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
 *host)
 
 		break;
 
 	case 3:
 		bits_per_pixel = 32;
Quoted 8 lines

drivers/video/mxsfb.c static int mxsfb_restore_mode(struct mxsfb_info *host) · line 626

Quoted 6 lines
drivers/video/mxsfb.c +1 -0
+		break;
drivers/video/mxsfb.c +0 -0
 	case 1:
 
 	default:
 		return -EINVAL;

Thanks, queued for 3.12 fixes.

Can you please also queue this for stable 3.10? It's broken there too.

Thanks!

Best regards,
Marek Vasut

#3 lore raw

PATCH 1/1 video: mxsfb: Add missing break

Quoted 28 lines · Marek Vasut

Hi Tomi,

Quoted 26 lines · Marek Vasut
Quoted 25 lines

Add missing break into the restore function.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Tomi Valkeinen <[email protected]>

---

 drivers/video/mxsfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/mxsfb.c +1 -0
index d250ed0..27197a8 100644
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
 *host)
 
 		break;
 
 	case 3:
 		bits_per_pixel = 32;
 
+		break;
Quoted 8 lines
Quoted 6 lines

drivers/video/mxsfb.c static int mxsfb_restore_mode(struct mxsfb_info *host) · line 626

Quoted 4 lines
drivers/video/mxsfb.c +0 -0
 	case 1:
 
 	default:
 		return -EINVAL;

Thanks, queued for 3.12 fixes.

Can you please also queue this for stable 3.10? It's broken there too.

this you have to do it by yourself by cc stable

Greg will take it not us

Best Regards,
J.

Quoted 9 lines

Thanks!

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html